BIP68: fix wrong upper bound for nHeight #2178

pull pythcoiner wants to merge 1 commits into bitcoin:master from pythcoiner:bip_68 changing 1 files +1 −1

pythcoiner commented at 1:45 AM on May 28, 2026: contributor

65_535 is a valid value for nHeight, see bitcoin-core code here, here and here.
pythcoiner commented at 1:46 AM on May 28, 2026: contributor

cc @darosior @hugohn
jonatack added the label Fixups on May 28, 2026

in bip-0068.mediawiki:243 in a96c65f2a2

 239 | @@ -240,7 +240,7 @@ Additionally, this BIP specifies only 16 bits to actually encode relative lock-t
 240 |  The most efficient way to calculate sequence number from relative lock-time is with bit masks and shifts:
 241 |  
 242 |  <pre>
 243 | -    // 0 <= nHeight < 65,535 blocks (1.25 years)
 244 | +    // 0 <= nHeight < 65,536 blocks (1.25 years)

darosior commented at 1:41 PM on May 28, 2026:

nit

    // 0 <= nHeight <= 65,535 blocks (1.25 years)

So both bounds are inclusive

pythcoiner commented at 2:13 PM on May 28, 2026:

done

darosior approved
darosior commented at 1:42 PM on May 28, 2026: member

The comment was indeed incorrect, and your change makes it matches what the snippet actually implements (nSequence & 0x0000ffff).
BIP68: fix wrong upper bound for nHeight 6ac8c26870
pythcoiner force-pushed on May 28, 2026
darosior approved
darosior commented at 2:44 PM on May 28, 2026: member

ACK 6ac8c268704a479bdf65fad642c46d43cf19677e
murchandamus approved
murchandamus commented at 5:05 PM on May 28, 2026: member

LGTM, will merge tomorrow unless new information suggests otherwise.
jonatack commented at 7:20 PM on May 28, 2026: member

ACK 6ac8c268704a479bdf65fad642c46d43cf19677e
hugohn commented at 1:07 AM on May 29, 2026: contributor

ACK https://github.com/bitcoin/bips/commit/6ac8c268704a479bdf65fad642c46d43cf19677e
murchandamus merged this on May 29, 2026
murchandamus closed this on May 29, 2026

Contributors

Labels