BIP-434: Add ref impl, mark complete / CI: add version check #2197

pull ajtowns wants to merge 2 commits into bitcoin:master from ajtowns:202606-434-complete changing 3 files +17 −5

ajtowns commented at 5:19 AM on June 11, 2026: contributor

No description provided.
ajtowns force-pushed on Jun 11, 2026
ajtowns force-pushed on Jun 11, 2026
ajtowns commented at 5:23 AM on June 11, 2026: contributor

I'm assuming "Deployed" should wait until there are features on the network actively using this protocol.
jonatack added the label BIP Update by Owner on Jun 11, 2026
in bip-0434.md:12 in f0af5efc7b

jonatack commented at 1:33 PM on June 11, 2026:

Per BIP 3, version 1.0.0 is used to label the promotion to Complete.

ajtowns commented at 1:56 PM on June 11, 2026:

Fixed, added a commit for CI to check this.
jonatack commented at 1:36 PM on June 11, 2026: member

Concept ACK, it looks like https://github.com/bitcoin/bitcoin/pull/35221/ contains the per-BIP3 required "comprehensive test vectors before they can be moved to Complete."
BIP-434: Add reference implementation, bump to 1.0.0, mark complete b14d7c34e5
ajtowns force-pushed on Jun 11, 2026
process: Check for pre-1.0 versions in complete/deployed bips 50eaa0d730
jonatack commented at 1:59 PM on June 11, 2026: member

Good idea to add the version check to the CI. In a separate PR, it could be good to add a check to ensure the Version header and the latest version in the changelog (if present) are the same.

in scripts/buildtable.pl:234 in 50eaa0d730

 228 | @@ -228,6 +229,11 @@
 229 |  	if (defined $ValidStatus{$status}) {
 230 |  		print " style=\"" . $ValidStatus{$status} . "\"";
 231 |  	}
 232 | +	if (defined $version and $version =~ m/^0+[.]/) {
 233 | +		if ($status eq "Complete" or $status eq "Deployed") {
 234 | +			die "$fn marked as $status despite pre-1.0 version ($version)";

jonatack commented at 2:06 PM on June 11, 2026:

-  Version: 1.0.0
+  Version: 0.0.1

$ ./scripts/buildtable.pl > devnull
bip-0434.md marked as Complete despite pre-1.0 version (0.0.1) at ./scripts/buildtable.pl line 234, <$F> line 13.

jonatack commented at 2:06 PM on June 11, 2026: member

ACK, tested the CI update locally
jonatack renamed this:
~~BIP-434: Add reference implementation, mark complete~~
BIP-434: Add ref impl, mark complete / CI: add version check
on Jun 11, 2026
jonatack added the label CI on Jun 11, 2026
jonatack merged this on Jun 11, 2026
jonatack closed this on Jun 11, 2026

Contributors

ajtowns

jonatack

Labels

CI BIP Update by Owner