Update the link format check to scan nested .mediawiki files as well as top-level BIP files.
script: check link format in nested mediawiki files #2199
pull reflecttypefor wants to merge 2 commits into bitcoin:master from reflecttypefor:master changing 1 files +7 −5-
reflecttypefor commented at 4:13 PM on June 17, 2026: none
-
14332848ef
script: check link format in nested mediawiki files
Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
- jonatack added the label CI on Jun 17, 2026
-
jonatack commented at 2:04 AM on June 18, 2026: member
Thanks for your proposal. Are there any nested mediawiki files? (I don't think we have any.)
-
reflecttypefor commented at 2:41 AM on June 18, 2026: none
Thanks for your proposal. Are there any nested mediawiki files? (I don't think we have any.)
Yes, there are currently 5 nested mediawiki files:
- bip-0008/assignments.mediawiki
- bip-0009/assignments.mediawiki
- bip-0016/qa.mediawiki
- bip-0070/extensions.mediawiki
- bip-0174/type-registry.mediawiki
There are 197 top-level .mediawiki files and 202 .mediawiki files in total. So the current script only checks the top-level files and misses these nested ones.
-
067b06a20a
script: check link format in nested mediawiki files
Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
-
in scripts/link-format-chk.sh:11 in 14332848ef
6 | @@ -7,14 +7,16 @@ 7 | # Check wrong mediawiki link format 8 | 9 | ECODE=0 10 | -for fname in *.mediawiki; do 11 | +while IFS= read -r fname; do 12 | GRES=$(grep -n '](http' "$fname")
jonatack commented at 3:07 AM on June 18, 2026:Tested.
Would you like to add also matching on relative urls like:
')\[../bip-'')\[/bip-'
reflecttypefor commented at 7:11 AM on June 18, 2026:Thanks. I have updated to also match Markdown-style relative BIP links using
](../bip-...)and](/bip-...), in addition to](http...)/](https...).I also adjusted the diagnostic text to refer to links more generally.
Verified with:
scripts/link-format-chk.shscripts/diffcheck.shtyposgit diff --check
reflecttypefor commented at 7:12 AM on June 18, 2026: none@jonatack Please review it again. If there's anything need I to do, please feel free to let me know. 😄
ContributorsLabels
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-19 17:10 UTC
More mirrored repositories can be found on mirror.b10c.me