BIP-327: correct PartialSigAgg session-value unpacking and a typo #2260

Found during a review of BIP327's normative pseudocode against its reference implementation (reference.py).

• PartialSigAgg unpacks GetSessionValues as a 7-tuple, but the algorithm returns a 6-tuple — cf. the 6-slot unpacks in Sign and PartialSigVerifyInternal, and the reference implementation itself, which passes all 56 published vector cases with the 6-slot form:

  # bip-0327/reference.py
  def get_session_values(session_ctx: SessionContext) -> Tuple[Point, int, int, int, Point, int]:
      ...
      return (Q, gacc, tacc, b, R, e)
  

• Fix "in the of public nonces" → "in the list of public nonces".

• Bump Version to 1.0.4 with a changelog entry, per the BIP's PATCH-version convention (precedent: #2071).

Although I guess these changes are very small, and are essentially 'obvious' typos, and therefore a version bump isn't needed?

Although I guess these changes are very small, and are essentially 'obvious' typos, and therefore a version bump isn't needed?

No strong opinion, but commit e2f9fe0c04123553644a (https://github.com/bitcoin/bips/pull/2071) added a similar entry (the current version).

ACK

مساعدة