bip-0352: do not require the optional expected argument #2279

pull fametrano wants to merge 1 commits into bitcoin:master from fametrano:bip352-guard-optional-expected changing 1 files +14 −11

fametrano commented at 6:50 PM on September 7, 2026: contributor

create_outputs and scanning declare expected with a default of None but dereference expected.get(...) unconditionally, so calling either without it raises AttributeError, although the parameter is documented optional.

Guard the expected-value checks with if expected is not None:. The self-test, which always passes expected, is unaffected; a standalone call with expected=None now returns its result instead of raising.

If the harness coupling is intentional, I am happy to close this or turn it into a docs note instead.
murchandamus added the label Proposed BIP modification on Sep 9, 2026
murchandamus added the label Pending acceptance on Sep 9, 2026
murchandamus commented at 3:24 PM on September 9, 2026: member

cc: @theStack
fametrano force-pushed on Sep 12, 2026

bip-0352: do not require the optional expected argument

create_outputs and scanning declare expected with a default of None but
dereference it unconditionally (expected.get(...)), so calling either
without it raises AttributeError, although the parameter is documented
optional. Guard the expected-value checks with `if expected is not None:`.

The self-test, which always passes expected, is unaffected.

8754690b72

fametrano force-pushed on Sep 19, 2026
jonatack removed the label Proposed BIP modification on Sep 22, 2026
jonatack removed the label Pending acceptance on Sep 22, 2026
jonatack added the label Fixups on Sep 22, 2026
jonatack commented at 5:04 AM on September 22, 2026: member

ACK, tightly scoped robustness fix that makes reference.py more usable outside its own test harness.
jonatack merged this on Sep 22, 2026
jonatack closed this on Sep 22, 2026
theStack commented at 3:27 PM on September 22, 2026: contributor

post-merge ACK

Contributors

Labels