bip-89, bip-114, bip-441: add missing <references/> tag #2289

pull kriss39 wants to merge 2 commits into bitcoin:master from kriss39:fix/missing-references-tag changing 3 files +12 −0
  1. kriss39 commented at 4:16 PM on September 13, 2026: contributor

    BIP 89, BIP 114 and BIP 441 use <ref>…</ref> footnotes but none of them contains a <references/> tag. GitHub's mediawiki renderer only emits the footnote bodies where that tag appears, so on the rendered pages the footnote text is missing and the [n] superscripts point at #cite_note-n anchors that do not exist (e.g. BIP 89's notes on lift_x, auxiliary randomness and blindsecnonce; BIP 441's five rationale notes).

    This adds a Footnotes section with <references/> to BIP 89 and BIP 441 (before Acknowledgements/Thanks, matching BIP 340), and puts the tag under BIP 114's existing References section.

    Rendering-only change, no text of the BIPs is modified, so no changelog entries were added; happy to add one for BIP 89 if preferred.

  2. bip-89, bip-114, bip-441: add missing <references/> tag
    These three BIPs use <ref> footnotes but never place a <references/>
    tag, so GitHub's mediawiki renderer drops the footnote text entirely and
    the [n] superscripts link to anchors that do not exist. Add a Footnotes
    section (BIP 89, BIP 441) or the tag under the existing References
    section (BIP 114) so the notes are rendered.
    5ffa11cf18
  3. jonatack added the label Fixups on Sep 14, 2026
  4. in bip-0114.mediawiki:378 in 5ffa11cf18 outdated
     373 | @@ -374,5 +374,7 @@ uint256 ComputeMerkleRootFromBranch(const uint256& leaf, const std::vector<uint2
     374 |  == References ==
     375 |  *[[bip-0141.mediawiki|BIP141 Segregated Witness (Consensus layer)]]
     376 |  
     377 | +<references/>
     378 | +
    


    jonatack commented at 9:14 PM on September 14, 2026:

    Seems it would be better to add Footnotes here too, unless I'm missing something.

    +== Footnotes ==
    <references/>
    
  5. jonatack commented at 9:14 PM on September 14, 2026: member

    ACK good fixes, modulo one question below

  6. bip-0114: use Footnotes section for references tag
    Match the convention used in BIP89 and BIP441: place <references/>
    under a dedicated Footnotes section rather than directly under
    References, per jonatack's review comment on PR #2289.
    50777eb01f
  7. kriss39 commented at 9:27 PM on September 14, 2026: contributor

    Fixed in 50777eb: moved <references/> in bip-0114 under a dedicated Footnotes section, matching the convention used in BIP89 and BIP441.

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-14 22:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me