bip98: fix the third SKIP hash in the example proof #2306

pull 0xShadowX wants to merge 1 commits into bitcoin:master from 0xShadowX:bip98-example-proof changing 1 files +2 −2
  1. 0xShadowX commented at 12:01 PM on September 25, 2026: contributor

    The example in the Inclusion Proofs section lists the skipped hashes as 0x00..., 0x66... and 0x22..., in that order, and the diagram source (bip-0098/traversal-example.dot) agrees: 0x22... is the SKIP branch of D. The base64 proof under it decodes to 06 bd8440 03, then 32 bytes of 0x00, 32 of 0x66 and 32 of 0x44. 0x44... is E's right child, which is a VERIFY hash and shouldn't be in the proof.

    This re-encodes the proof with 0x22... as the third hash. The header, the node codes and the 101-byte length stay the same, only the last 32 bytes change. It also drops a stray "." after "base64:".

    python3 -c "import base64; print(base64.b64encode(bytes.fromhex('06bd844003')+b'\x00'*32+b'\x66'*32+b'\x22'*32).decode())"
    
  2. bip98: fix the third SKIP hash in the example proof
    The example says the skipped hashes are 0x00..., 0x66... and 0x22...,
    and traversal-example.dot has 0x22... as the SKIP branch of D, but the
    base64 proof ended with 32 bytes of 0x44, which is one of the VERIFY
    hashes. Re-encode the proof with 0x22... as the last hash. The length
    (101 bytes) and the tree serialization are unchanged.
    b48abb1624
  3. jonatack added the label Fixups on Sep 25, 2026
  4. jonatack commented at 6:49 PM on September 25, 2026: member

    ACK

  5. jonatack merged this on Sep 25, 2026
  6. jonatack closed this on Sep 25, 2026

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-30 16:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me