BIP-352: add sprt as the regtest hrp #2312

i saw bdk-sp and sparrow using "sprt" as the regtest hrp, so updated here in the BIP as well.

NACK 5bdc91ee47c7aa510c0e1d8eb6a1d5de414de445

I was surprised to find out that there was something I hadn't extracted from the BIP for bdk-sp implementation, but after doing some digging, I found the possible origin of its introduction:

• #1458 (review)

In that comment thread, _@josibake concluded to not include sprt in the BIP spec, although bitcoin-core silent payments PR from that moment did, as well as the recently merged bitcoin/bitcoin#35301 does.

The crux of the issue is in bitcoin/bitcoin#12314, where you can get an overview of the reasons for and against doing it.

Technically, the removal of sprt would be beneficial for bdk-sp, as the non binary distinction of the network introduced some bugs in the past: https://github.com/bitcoindevkit/bdk-sp/pull/70, but I consider #1458 (review) enough of an answer to keep the BIP as it is, and wait for bitcoin/bitcoin#12314 to be fixed (if ever), to reconsider this stance.

Thanks for refreshing me this!

well thanks for clearing this up @nymius

i did follow the BIP in my embit implementation, it was looking at bdk-sp and sparrow that confused me. (would really appreciate a review on that PR too if you get time)

i will raise an issue with sparrow for the same.

closing.