BIP 54 editorial clarifications #2313

pull darosior wants to merge 3 commits into bitcoin:master from darosior:2609_bip54_wording_nits changing 1 files +3 −3
  1. darosior commented at 4:18 PM on September 28, 2026: member

    Calvin Kim implemented BIP 54 for btcd solely from the specifications here, as a way of testing the specs. It's been a while, but he raised a couple wording nits that were worth clarifying, which i'm only getting to doing now.

  2. jonatack added the label BIP Update by Owner on Sep 28, 2026
  3. in bip-0054.md:73 in 992a7458fa
      69 | @@ -70,7 +70,7 @@ over all transaction inputs is strictly higher than 2500, the transaction is inv
      70 |  same as for [bip-0016][BIP16 specs], evaluating the scriptSig, scriptPubKey, and P2SH redeemScript
      71 |  separately:
      72 |  
      73 | -1. `CHECKSIG` and `CHECKSIGVERIFY` count as 1 signature operation, whether or not they are evaluated.
      74 | +1. Each `CHECKSIG` and `CHECKSIGVERIFY` count as 1 signature operation, whether or not they are evaluated.
    


    jonatack commented at 4:56 PM on September 28, 2026:

    If I'm understanding your intention correctly

    1. `CHECKSIG` and `CHECKSIGVERIFY` each count as 1 signature operation, whether or not they are evaluated.
    

    darosior commented at 11:02 AM on October 2, 2026:

    Yes that's even better, thanks.

  4. bip 54: make it extra clear it's not the pair of CHECKSIG, CMS that counts as one ed35941077
  5. bip 54: explicitly qualify the unit for 7200 constant is seconds f33b8b5b2b
  6. bip-0054: extra clarity in legacy sigops accounting e929ced308
  7. in bip-0054.md:67 in 992a7458fa


    jonatack commented at 5:06 PM on September 28, 2026:

    Aside, would this be clearer? (if I understand correctly)

    --- a/bip-0054.md
    +++ b/bip-0054.md
    @@ -69,7 +69,7 @@ A limit is set on the number of signature operations present in the scripts use
     transaction. It applies to all transactions in the block except the coinbase transaction[^1]. For
    -each input in the transaction, count the number of `CHECKSIG` and `CHECKMULTISIG` in the input
    +each input in the transaction, count the number of signature operations from `CHECKSIG`, `CHECKSIGVERIFY`, `CHECKMULTISIG`, and `CHECKMULTISIGVERIFY` in the input
     scriptSig and previous output's scriptPubKey, including the P2SH redeemScript. If the total summed
     over all transaction inputs is strictly higher than 2500, the transaction is invalid. The accounting is the
     same as for [bip-0016][BIP16 specs], evaluating the scriptSig, scriptPubKey, and P2SH redeemScript
    

    darosior commented at 11:09 AM on October 2, 2026:

    Yeah i guess it makes sense to be extra clear in there. Added as a new commit while i'm here.

  8. darosior force-pushed on Oct 2, 2026
  9. jonatack merged this on Oct 2, 2026
  10. jonatack closed this on Oct 2, 2026

  11. jonatack commented at 1:28 PM on October 2, 2026: member

    ACK, thanks for updating.

  12. jonatack renamed this:
    Address some wording nits in BIP 54
    BIP 54 editorial clarifications
    on Oct 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-03 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me