BIP373: replace the duplicated x-only output participant vector #2345

pull MrHodlX wants to merge 1 commits into bitcoin:master from MrHodlX:bip373-output-vector changing 1 files +2 −2

MrHodlX commented at 2:02 PM on November 4, 2026: contributor

The invalid vector for an x only output participant pubkey is a straight copy of the one right before it. So that case never actually gets tested. An implementation that only looks at the keydata passes both.

I rebuilt it the same way as the input side pair. The keydata holds the 33 byte aggregate pubkey and the first participant key in the value is x only. Doing the same thing on the input side gives you the BIP's own input participant vector exactly. Only the hex and base64 for that one vector change.

Found this while testing a BIP 373 verifier against the vectors.
BIP373: replace the duplicated x-only output participant vector e315654e75
jonatack added the label Fixups on Nov 4, 2026
jonatack commented at 3:13 PM on November 4, 2026: member

ACK, previously effectively untested case is now properly covered.

Decoded both the old and new base64 vectors, walked the PSBT maps and inspected the PSBT_OUT_MUSIG2_PARTICIPANT_PUBKEYS (type 0x08) field.
jonatack merged this on Nov 4, 2026
jonatack closed this on Nov 4, 2026
achow101 commented at 6:43 PM on November 4, 2026: member

post-merge ACK

This matches the vector for this case in Bitcoin Core.

Contributors

Labels