Adds multisig support #253

pull matiu wants to merge 2 commits into bitcoin:master from matiu:patch-2 changing 1 files +16 −0

matiu commented at 2:37 AM on December 1, 2015: contributor
- defines 48' a purpose for multisig wallets
- adds p2sh address generate procedure
- adds Copay to 'compatible wallets'

Adds multisig support

- defines 48' a purpose for multisig wallets
- adds p2sh address generate procedure
- adds Copay to 'compatible wallets'

03f57ba308

Update bip-0044.mediawiki 332f04e259
afk11 commented at 5:32 PM on December 1, 2015: contributor

BIP's aren't usually amended after the fact, it might be an issue to introducing this a year and a half in.
matiu commented at 6:26 PM on December 1, 2015: contributor

Given that the multisig extension uses a new purpose number, I dont think there could be an issue. This was done in coordination with the BIP author.

Note that there are some BIP are received conceptually similar extensions like: https://github.com/bitcoin/bips/commit/2e6e5cf9589778ea55c7e71aa27e2b9ff122b737
luke-jr commented at 7:06 AM on December 11, 2015: member

It's still Draft status, so this just needs an ACK from @slush0 or @prusnak
luke-jr added the label Proposed BIP modification on Dec 11, 2015
prusnak commented at 9:44 AM on December 11, 2015: contributor

NACK. This should go into BIP 48 according to BIP 43 specification.
prusnak commented at 9:45 AM on December 11, 2015: contributor

Also you should clearly state in BIP 45 that this BIP is obsoleted by BIP 48.
andre-amorim commented at 9:57 AM on December 11, 2015: none

Time Stamp ?

On 11 December 2015 at 09:44, Pavol Rusnak notifications@github.com wrote:

NACK. This should go into BIP 48 according to BIP 43 specification.

— Reply to this email directly or view it on GitHub #253 (comment).

in bip-0044.mediawiki:None in 332f04e259

 124 | @@ -125,6 +125,20 @@ internal chains receive only coins that come from the associated external chains
 125 |  Wallet software should warn when the user is trying to exceed the gap limit on
 126 |  an external chain by generating a new address.
 127 |  
 128 | +==Multisignature Wallets==
 129 | +
 130 | +===Purpose===
 131 | +Because seeds that are part of a multisignature wallet cannot be scanned individually, a different
 132 | +purpose constant is must be used: 48'.

amacneil commented at 6:01 PM on December 11, 2015:

typo/grammar

a different purpose constant is must be used

in bip-0044.mediawiki:None in 332f04e259

 130 | +===Purpose===
 131 | +Because seeds that are part of a multisignature wallet cannot be scanned individually, a different
 132 | +purpose constant is must be used: 48'. 
 133 | +
 134 | +===Address generation===
 135 | +To generate multisig addresses each party must use the same derivation path of a given address, and the resulting public

amacneil commented at 6:22 PM on December 11, 2015:

nit: line length not consistent with rest of file

matiu commented at 6:48 PM on December 11, 2015: contributor

OK, closing this one then. I will submit a new proposal.

This do not completely obsoletes BIP45, since with BIP45 it is possible to create wallet addresses without parties synchronization.
matiu closed this on Dec 11, 2015

Contributors

Labels

Proposed BIP modification