[BIP 152] Update compact block BIP for banning behavior #473

pull sdaftuar wants to merge 2 commits into bitcoin:master from sdaftuar:bip152-invalid-blocks changing 1 files +3 −1
  1. sdaftuar commented at 12:37 PM on November 3, 2016: member

    @TheBlueMatt I tried to draft something to reflect the p2p banning behavior being properly implemented by signaling the version bump, how does this look to you?

    In particular, do you think the first SHOULD NOT I added (regarding not banning peers for an invalid compact block) should be a MUST NOT?

  2. [BIP 152] Fix invalid link 78c3b0a244
  3. TheBlueMatt commented at 12:40 PM on November 3, 2016: contributor

    I might prefer pointing out that nodes SHOULD NOT relay prior to validating unless their peer has sufficient version as well.

    On November 3, 2016 8:37:12 AM EDT, Suhas Daftuar notifications@github.com wrote:

    @TheBlueMatt I tried to draft something to reflect the p2p banning behavior being properly implemented by signaling the version bump, how does this look to you?

    In particular, do you think the first SHOULD NOT I added (regarding not banning peers for an invalid compact block) should be a MUST NOT? You can view, comment on, or merge this pull request online at:

    #473

    -- Commit Summary --

    • [BIP 152] Fix invalid link
    • [BIP 152] Bump p2p protocol for proper banning behavior

    -- File Changes --

    M bip-0152.mediawiki (4)

    -- Patch Links --

    #473.patch #473.diff

    You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #473

  4. [BIP 152] Bump p2p protocol for proper banning behavior 30620da93c
  5. sdaftuar force-pushed on Nov 3, 2016
  6. sdaftuar commented at 12:45 PM on November 3, 2016: member

    Makes sense, updated.

  7. TheBlueMatt commented at 1:04 PM on November 3, 2016: contributor

    ACK

    On November 3, 2016 8:37:12 AM EDT, Suhas Daftuar notifications@github.com wrote:

    @TheBlueMatt I tried to draft something to reflect the p2p banning behavior being properly implemented by signaling the version bump, how does this look to you?

    In particular, do you think the first SHOULD NOT I added (regarding not banning peers for an invalid compact block) should be a MUST NOT? You can view, comment on, or merge this pull request online at:

    #473

    -- Commit Summary --

    • [BIP 152] Fix invalid link
    • [BIP 152] Bump p2p protocol for proper banning behavior

    -- File Changes --

    M bip-0152.mediawiki (4)

    -- Patch Links --

    #473.patch #473.diff

    You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #473

  8. sdaftuar cross-referenced this on Nov 3, 2016 from issue Fix handling of invalid compact blocks by sdaftuar
  9. luke-jr merged this on Nov 3, 2016
  10. luke-jr closed this on Nov 3, 2016

  11. TheBlueMatt cross-referenced this on Nov 4, 2016 from issue Compact blocks (BIP152) by dagurval

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me