BIP 114: Add DROP after CLTV/CSV opcodes in flattened branches #689

1. 
   afk11 commented at 5:25 pm on June 3, 2018: contributor

   In the HTLC example https://github.com/bitcoin/bips/blob/master/bip-0114.mediawiki#hashed-time-lock-contract I think there DROP is required after the CSV / CLTV opcodes

   There was branch by the same author @jl2012 to make CSV/CLTV actually pop from the stack in MAST, but the behavior is not described or referred to in BIP114 at the moment.

2. BIP 114: Add DROP opcodes to flattened branches 50fbe24d5e
3. 
   luke-jr commented at 5:16 am on July 5, 2018: member

   @jl2012
4. luke-jr added the label Proposed BIP modification on Jul 5, 2018
5. 
   afk11 commented at 6:41 pm on January 6, 2019: contributor

   Hi @jl2012 - have you time to consider this PR?
6. 
   fivepiece commented at 7:37 pm on January 6, 2019: none

   The bip states that the reference implementation is https://github.com/jl2012/bitcoin/tree/bip114v2 , which does have :

   https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L463-L464 and https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L423-L424

   Isn’t it better to /add/ a note about these opcodes popping the value instead of adding a DROP to the scripts?

7. 
   afk11 commented at 9:44 pm on January 6, 2019: contributor

   @fivepiece

   Isn’t it better to /add/ a note about these opcodes popping the value instead of adding a DROP to the scripts?

   Either’s good to be honest - I was unsure if that branch was meant to the just the BIP, or included nice-to-haves as well.

8. 
   andreaskern commented at 3:41 pm on March 1, 2022: none

   yes, please add this comment
9. bitcoin deleted a comment on Mar 3, 2022
10. bitcoin deleted a comment on Mar 3, 2022
11. 
    jonatack commented at 4:11 pm on May 6, 2024: contributor

    Pinging @jl2012. Considering this pull has been open since 2018 and the author hasn’t responded to the preceding pings and doesn’t appear to have any GitHub activity in the past year, I propose to close this pull on June 1st, 2024, if no response in the interim.

    Also, the last update to the reference implementation was 8 years ago: https://github.com/jl2012/bitcoin/tree/bip114v2.

12. murchandamus added the label Pending acceptance on May 8, 2024
13. 
    TheCharlatan commented at 6:32 pm on May 12, 2024: none

    Should there be a policy against opening PRs for rejected proposals?
14. 
    murchandamus commented at 4:56 pm on May 13, 2024: contributor

    Closing this PR, because the BIP was moved to the Rejected status since this PR was opened.
15. murchandamus closed this on May 13, 2024

    ---

Contributors
afk11 luke-jr fivepiece andreaskern jonatack TheCharlatan murchandamus

Labels
Proposed BIP modification Pending acceptance