Have the server sign PROTOCOL_SUPPORT/PROTOCOL_VERSION #731

pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:fix-6 changing 1 files +840 −0

TheBlueMatt commented at 3:02 AM on October 10, 2018: contributor

No description provided.
Add mining protocol BIP draft 02f70408e1

Have the server sign PROTOCOL_SUPPORT/PROTOCOL_VERSIONs

This closes #6, ensuring no future MiTM-based downgrade attacks can
occur. Note that obviously this doesn't do anything for TOFU
clients as any MiTM attacker can also replace the pubkey, but it
does protect either connection-reset-based MiTM attackers as the
pubkey must not change and also any clients which specify the
expected public key.

509bee8777

TheBlueMatt commented at 3:03 AM on October 10, 2018: contributor

@jonasnick
TheBlueMatt closed this on Oct 10, 2018
TheBlueMatt commented at 3:03 AM on October 10, 2018: contributor

Oops wrong head, sorry.

Contributors

TheBlueMatt