Add SegWit v0 (P2WPKH+P2WSH) filter type #896

pull nopara73 wants to merge 3 commits into bitcoin:master from nopara73:patch-4 changing 1 files +6 −2

nopara73 commented at 2:15 PM on February 28, 2020: none
- Add 0x01 to the Basic filter type to reflect Bitcoin Core's codebase.
- Add 0xFF, Invalid filter filter type to reflect Bitcoin Core's codebase.
- Add new 0x02, V0 filter type, which incorporates P2WPKH+P2WSH scripts to map to PR https://github.com/bitcoin/bitcoin/pull/18223. Thus this PR cannot be merged until https://github.com/bitcoin/bitcoin/pull/18223 PR is merged.
Add P2WPKH filter type 2594ce1e2e
Update bip-0158.mediawiki 960a4cc856
in bip-0158.mediawiki:266 in 2594ce1e2e outdated
```
 263 | @@ -264,7 +264,10 @@ against the decompressed GCS contents. See
 264 |  === Block Filters ===
 265 |  
 266 |  This BIP defines one initial filter type:
```
schildbach commented at 2:33 PM on February 28, 2020:

Now there are two initial filter types.

nopara73 commented at 2:43 PM on February 28, 2020:

Thank you!
luke-jr commented at 4:54 PM on February 28, 2020: member

@aakselrod @Roasbeef
luke-jr added the label Proposed BIP modification on Feb 28, 2020
nopara73 commented at 5:39 PM on February 28, 2020: none

For the record there is a discussion about that probably it should combine both P2WPKH and P2WSH scripts: https://github.com/bitcoin/bitcoin/issues/18222#issuecomment-592631517
Update new filter proposal to V0 and add Invalid to reflect the code 4d4592fe2d
nopara73 commented at 1:58 PM on March 1, 2020: none

There seems to be a consensus that P2WPKH+P2SH is better than P2WPKH alone, so I updated this PR with that. There is still no consensus if new type should be added or not.
nopara73 renamed this:
~~Add P2WPKH filter type~~
Add SegWit v0 (P2WPKH+P2WSH) filter type
on Mar 1, 2020
nopara73 commented at 8:59 AM on March 27, 2020: none

This has been rejected, so closing.
nopara73 closed this on Mar 27, 2020
adamjonas cross-referenced this on Aug 3, 2022 from issue Add `blockfilterindex = p2wpkh` by nopara73

Contributors

nopara73

schildbach

luke-jr

Labels

Proposed BIP modification