As discussed on the mailing list.
bip-341: Commit to all scriptPubKeys in SigMsg #920
pull jonasnick wants to merge 2 commits into bitcoin:master from jonasnick:spk-commit-all changing 1 files +6 −4-
jonasnick commented at 12:57 PM on May 15, 2020: contributor
-
bip-341: Commit to all scriptPubKeys in SigMsg dde165749e
-
bip-341: add missing Post-History 15fba98cf4
-
gmaxwell commented at 3:17 PM on May 15, 2020: contributor
Is there a discussion as to why amounts and scriptpubkey are separately hashed instead of just being one hash interleaved with the amounts? (more similar to the anyonecan pay case)
-
jonasnick commented at 4:44 PM on May 15, 2020: contributor
Yes, the current design was suggested by @roconnor on the mailing list (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2020-May/017808.html) because it saves signers from receiving and hashing the scriptPubKeys if they're just interested in the amounts.
-
gmaxwell commented at 6:32 PM on May 15, 2020: contributor
I can't figure out what use a signer would have for the scriptpubkeys without the values. Values without scriptpubkeys would be useful if the signer is always going to assume all inputs are its own.
-
jonasnick commented at 7:26 PM on May 15, 2020: contributor
Yeah, scriptPubKeys but not values seems useless. But since values without scriptPubKeys are useful, hashing them separately is better than having a single hash for all TxOuts. Or am I misunderstanding your suggestion?
-
gmaxwell commented at 5:22 AM on May 16, 2020: contributor
Hm. On the basis that scripts without amounts are likely not useful the commitment to scriptpubkeys could be inside the commitment to the amounts, which I think would save some hashing in verifiers and reduce data needing to be sent to signers that don't care about either, but I suppose it doesn't matter much.
- sipa cross-referenced this on May 22, 2020 from issue Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa
-
sipa commented at 12:14 AM on May 23, 2020: member
ACK, also included in https://github.com/bitcoin/bitcoin/pull/17977 now.
-
ajtowns commented at 3:59 AM on May 25, 2020: contributor
ACK
-
gmaxwell commented at 4:34 AM on May 26, 2020: contributor
ACK
-
prusnak commented at 4:08 PM on June 1, 2020: contributor
ACK
- luke-jr added the label Proposed BIP modification on Jun 1, 2020
- luke-jr merged this on Jun 1, 2020
- luke-jr closed this on Jun 1, 2020
- pinheadmz cross-referenced this on May 22, 2022 from issue Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by pinheadmz
