Both BIP341 and BIP342 were using a mix of "TapSighash" and "TapSigHash". As existing implementations and tests use the former, use that one.
Originally pointed out here: https://github.com/bitcoin/bitcoin/pull/17977#discussion_r459531548
Use consistent capitalization of tag TapSighash #954
pull sipa wants to merge 1 commits into bitcoin:master from sipa:202007_tapsighash_capitalization changing 2 files +2 −2-
sipa commented at 8:52 PM on July 28, 2020: member
-
Use consistent capitalization of tag TapSighash b9ea863727
- sipa cross-referenced this on Jul 28, 2020 from issue Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa
-
jonasnick commented at 9:50 AM on July 29, 2020: contributor
ACK
-
Sjors commented at 6:10 PM on July 31, 2020: member
I think it would be early enough in the process to use
TapSigHash, which doesn't break any tests in your PR.On the other hand we have a long history of treating "sighash" as a single word (e.g.
SIGHASH_ALL).ACK b9ea863727c8e53d69afc1a816feed8944cc1e58
- luke-jr merged this on Aug 1, 2020
- luke-jr closed this on Aug 1, 2020
