The database log size recently increased from 10MB to 100MB, but CheckDiskSpace() is still only checking for 15MB free before warning. That needs to be increased "because database could create another 100MB log file at any time".
database log size has increased so CheckDiskSpace needs to change #1003
pull dooglus wants to merge 3 commits into bitcoin:master from dooglus:checkdiskspace_110mb changing 3 files +10 −4-
dooglus commented at 6:07 PM on March 28, 2012: contributor
-
database log size has increased so CheckDiskSpace needs to check for more space b987ae4c81
-
TheBlueMatt commented at 7:09 PM on March 28, 2012: member
Should that number be dynamically generated because the cache size can be changed?
-
TheBlueMatt commented at 7:12 PM on March 28, 2012: member
ACK on the concept for 0.6.
-
dooglus commented at 7:12 PM on March 28, 2012: contributor
Maybe. I wanted to make the change as simple as possible for now, but could make it some multiplier of (or addition to) the log size.
-
Use a single definition for the max db log file size rather than having to keep it in sync in 2 places. 0f1ffe97b8
-
Define the max logfile size to be 10 times the in-memory log buffer size. 4a3cad5d8b
-
dooglus commented at 8:30 PM on March 28, 2012: contributor
Should that number be dynamically generated because the cache size can be changed?
I added a couple of constants to db.h to define the in-memory log buffer size, and the max on-disk log file size, and used those in both places. I don't think this is related to the cache size - did you mean the in-memory log buffer?
-
TheBlueMatt commented at 8:52 PM on March 28, 2012: member
Oh, Im sorry, I thought the max log size was set based on cli parameters now, didnt realize it was still constant. Anyway, like the addition of the constants too...ACK
-
Diapolo commented at 9:46 PM on March 28, 2012: none
Small and good change!
-
gavinandresen commented at 5:27 PM on March 29, 2012: contributor
Log file size has a negligible effect on performance, so it was dropped back down to 10M. It is the cache size that really mattered.
- gavinandresen closed this on Mar 29, 2012
-
dooglus commented at 5:36 PM on March 29, 2012: contributor
Isn't it still a good idea to have the size in one place only rather than in two places?
-
gavinandresen commented at 5:41 PM on March 29, 2012: contributor
Yes, that is a good idea. Can you put another pull together for 0.7?
-
dooglus commented at 6:00 PM on March 29, 2012: contributor
@gavinandresen I've updated this pull request with the change, but can't reopen the issue.
- suprnurd referenced this in commit b31ee8441a on Dec 5, 2017
- ptschip referenced this in commit 21d56ff45b on Mar 15, 2018
- lateminer referenced this in commit a89f4e6603 on Oct 30, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors