Ping @jnewbery introduced on https://github.com/bitcoin/bitcoin/commit/dab804c18a427901684ebe936b2069a97e04a268
[QA] Fix typo in fundrawtransaction test #10069
pull NicolasDorier wants to merge 1 commits into bitcoin:master from NicolasDorier:patch-3 changing 1 files +1 −1-
NicolasDorier commented at 10:10 AM on March 24, 2017: contributor
-
803e6a3503
[QA] Fix typo in fundrawtransaction test
Ping @jnewbery introduced on https://github.com/bitcoin/bitcoin/commit/dab804c18a427901684ebe936b2069a97e04a268
- fanquake added the label Tests on Mar 24, 2017
-
laanwj commented at 11:45 AM on March 24, 2017: member
I don't get it, how did this typo pass the tests?
-
NicolasDorier commented at 11:48 AM on March 24, 2017: contributor
@laanwj becuse
rawtxis an actual variable used above, which is planned to fail with this reason. -
laanwj commented at 11:53 AM on March 24, 2017: member
Oh wow. Two variables with the same name and different casing, this is confusing.
-
jnewbery commented at 12:41 PM on March 24, 2017: member
ouch. Mea culpa. Good spot @NicolasDorier.
Tested ACK 803e6a35037e7371f767585fec36ba17bdd36f4a
-
laanwj commented at 12:49 PM on March 24, 2017: member
I think the underlying problem should be solved too. We shouldn't use
rawTxandrawtxin a single function, this is the code equivalent of a minefield. -
MarcoFalke commented at 1:14 PM on March 24, 2017: member
utACK 803e6a3. Agree that the underlying problem should be solved as well. As a first step you can get rid of the camelCase and use a single name for the variable. In a second step, the scopes could be limited to the minimum necessary. (Maybe refactor the blocks into separate functions?)
-
jonasschnelli commented at 1:15 PM on March 24, 2017: contributor
utACK 803e6a35037e7371f767585fec36ba17bdd36f4a
-
sipa commented at 8:42 PM on March 24, 2017: member
utACK
- dcousens approved
-
MarcoFalke commented at 3:10 PM on March 25, 2017: member
This has too much review to keep open any longer. Lets do the follow up cleanup in separate pulls.
- MarcoFalke merged this on Mar 25, 2017
- MarcoFalke closed this on Mar 25, 2017
- MarcoFalke referenced this in commit 111849345b on Mar 25, 2017
-
NicolasDorier commented at 5:48 AM on March 26, 2017: contributor
- PastaPastaPasta referenced this in commit 842c72113a on Mar 14, 2019
- PastaPastaPasta referenced this in commit 565a89400e on May 20, 2019
- PastaPastaPasta referenced this in commit 1781c7a701 on May 21, 2019
- PastaPastaPasta referenced this in commit 93330de5c2 on May 21, 2019
- barrystyle referenced this in commit 1ed5d81112 on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
Labels