Follow up from #10069
fundrawtransaction.py is using two variables: rawtx and rawTx, which can be easily confused (see #10069). This PR rename everything in rawtx.
It was discussed to have separate function for each test case of fundrawtransaction.py, however, it seems a bit overkill to me, I think this PR is good enough. (Other followup #10078)
utACK dd5be2c7b35f0ecd1650a7f8cf08e692f6f41ccb
Yes, utACK, thanks, this should have been the solution in the first place.
Just curious, any reason why rawtx was chosen over rawTx? Personally, I prefer the latter. Making everything lowercase obfuscates the fact that multiple words/abbreviations are being used. There's also some inconsistency in the code's variable names at that point. Not a big deal, just something I'm curious about.
@droark Feel free to use raw_tx if you think that it is clearer than rawtx. Though, the python code should stay free of camelCase in variable names of local scope.
Fair enough. Thanks for clarifying.
