This commit uses the new skip test funcationality added in 232b6665bc3e5b134821dc7584968fb439fd5f44 to skip the zmq tests if the python zmq module is not available or if bitcoind has been built without zmq support.
This removes the zmq-specific logic from test_runner.py. In general it's better if test_runner.py has no knowledge of special cases for individual tests and is a general purpose test runner.
Concept ACK
On Mon, Mar 27, 2017 at 6:15 PM, John Newbery notifications@github.com wrote:
This commit uses the new skip test funcationality added in 232b666 https://github.com/bitcoin/bitcoin/commit/232b6665bc3e5b134821dc7584968fb439fd5f44 to skip the zmq tests if the python zmq module is not available or if bitcoind has been built without zmq support.
This removes the zmq-specific logic from test_runner.py. In general it's better if test_runner.py has no knowledge of special cases for individual tests and is a general purpose test runner.
You can view, comment on, or merge this pull request online at:
#10097 Commit Summary
- Move zmq test skipping logic into individual test case.
File Changes
- M test/functional/test_runner.py https://github.com/bitcoin/bitcoin/pull/10097/files#diff-0 (25)
- M test/functional/zmq_test.py https://github.com/bitcoin/bitcoin/pull/10097/files#diff-1 (21)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10097, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv4BZGpuh9duLpkF5cPOQke7I_8zmks5rp-CdgaJpZM4MqfhX .
Needs a rebase. Will test.
utACK
rebased
This commit uses the new skip test funcationality added in
232b6665bc3e5b134821dc7584968fb439fd5f44 to skip the zmq tests if the
python zmq module is not available or if bitcoind has been built without
zmq support.
This removes the zmq-specific logic from test_runner.py. In general it's
better if test_runner.py has no knowledge of special cases for
individual tests and is a general purpose test runner.
rebased
ACK 6803e09e6eeb2dbc820bb1025475a50a4352e30d
Tested with pyzmq not installed (skipped as expected) Tested with zmq not enabled in binary (skipped as expected) Tested with zmq and pyzmq enabled (tested as expected)
utACK 6803e09 @jimmysong Thanks for testing.