Feature request: Client whitelist for bandwidth limiting (maxuploadtarget) #10131

1. 
   ghost commented at 5:24 am on March 31, 2017: none

   maxuploadtarget limit applies also for localhost clients

   When using option maxuploadtarget and that limit is reached, even clients on localhost (where Bitcoin is running) do not get any more data from Bitcoin (Bitcoind says “historical block serving limit reached, disconnect peer”).

   E.g. this let to disfunction of Bitsquare, which could not connect to Bitcoin on localhost anymore. See https://github.com/bitsquare/bitsquare/issues/758, where the workaround solution was to disable maxuploadtarget.

   I would like to be able to whitelist localhost to be excluded from traffic limiting.

   Version

   Bitcoin 0.14.0 amd64 binary for Linux

2. laanwj added the label Feature on Mar 31, 2017
3. laanwj added the label P2P on Mar 31, 2017
4. 
   laanwj commented at 5:52 am on March 31, 2017: member

   Huh, I seriously thought this it was already the case that whitelisted peers could get around this limit. In any case a more fine-grained whitelisting configuration where ‘allow client to ignore serving limit’ is an option would make sense to me.

   ping @theuni (would make sense to take this into account in #10051 (comment))

5. 
   gmaxwell commented at 8:59 pm on April 2, 2017: contributor

   Whitelisted peers are exempted. Localhost is not whitelisted (in part because that includes all Tor HS inbound.)

   Please do not use general ‘whitelist’ functionality for this, the general whitelist functionality changes transaction relay behavior in a way that is almost never wanted.

   I think if not for the fact that Tor HS inbound is localhost it would make sense to except localhost. I don’t know what to do about that except for hacky solutions like having a probablyLocal flag set for any peer which has a <1ms minimum pingtime.

   if (send && connman.OutboundTargetReached(true) && ( ((pindexBestHeader != NULL) && (pindexBestHeader->GetBlockTime() - mi->second->GetBlockTime() > nOneWeek)) || inv.type == MSG_FILTERED_BLOCK) && ***** !pfrom->fWhitelisted ***** )

6. MarcoFalke deleted a comment on May 9, 2020
7. MarcoFalke closed this on May 9, 2020

   ---

8. MarcoFalke referenced this in commit b1b1739944 on Jun 6, 2020
9. sidhujag referenced this in commit 925a6e6bb2 on Jun 8, 2020
10. DrahtBot locked this on Feb 15, 2022

Contributors
ghost laanwj gmaxwell

Labels
Feature P2P