Pull-Requests
pull
Fix and add test for empty chain and reorg consistency for gettxoutsetinfo.
#10445
gmaxwell on May 23, 2017 Tests
gmaxwell on May 23, 2017 Tests
pull
Add an explanation of quickly hashing onto a non-power of two range.
#10577
gmaxwell on June 11, 2017 Docs
gmaxwell on June 11, 2017 Docs
pull
Batch flushing operations to the walletdb during top up and increase keypool size.
#10831
gmaxwell on July 15, 2017 Wallet
gmaxwell on July 15, 2017 Wallet
pull
Avoid using sizes on non-fixed-width types to derive protocol constants.
#10854
gmaxwell on July 17, 2017 Validation
gmaxwell on July 17, 2017 Validation
pull
Update defaultAssumeValid according to release-process.md.
#10945
gmaxwell on July 28, 2017 Validation
gmaxwell on July 28, 2017 Validation
pull
[Trivial] Add a comment on the use of prevector in script.
#11011
gmaxwell on August 8, 2017 Docs
gmaxwell on August 8, 2017 Docs
pull
Remove nBlockMaxSize from miner opt struct as it is no longer used.
#11362
gmaxwell on September 18, 2017 Mining
gmaxwell on September 18, 2017 Mining
pull
Kill warning from unavoidable signed/unsigned comparison in bitcoinrpc.cpp.
#1237
gmaxwell on May 9, 2012
gmaxwell on May 9, 2012
pull
Skip stale tip checking if outbound connections are off or if reindexing.
#14027
gmaxwell on August 22, 2018 P2P
gmaxwell on August 22, 2018 P2P
pull
Remove some rule differences which aren't needed with testnet3.
#1503
gmaxwell on June 22, 2012
gmaxwell on June 22, 2012
pull
Update assumevalid, minimumchainwork, and getchaintxstats to height 563378
#15429
gmaxwell on February 17, 2019 Validation
gmaxwell on February 17, 2019 Validation
pull
Do not consider inbound peers for outbound network group exclusion.
#1546
gmaxwell on July 2, 2012
gmaxwell on July 2, 2012
pull
Switch testnet3's message bytes to avoid connecting to old nodes.
#1634
gmaxwell on July 26, 2012
gmaxwell on July 26, 2012
pull
Correctly handle missing inputs in signrawtransaction. Fixes #1654.
#1655
gmaxwell on August 6, 2012
gmaxwell on August 6, 2012
pull
Apply BIP30 checks to all blocks except the two historic violations.
#1814
gmaxwell on September 10, 2012
gmaxwell on September 10, 2012
pull
In listaddressgroupings push down the IsMine check to run on each input.
#1872
gmaxwell on September 27, 2012
gmaxwell on September 27, 2012
pull
Fixes a race condition in CreateNewBlock and a future null deref on testnet.
#1953
gmaxwell on October 24, 2012
gmaxwell on October 24, 2012
pull
If the prio. will be enough after the next block don't force fees. [wallet]
#2129
gmaxwell on December 26, 2012
gmaxwell on December 26, 2012
pull
Signrawtransaction shouldn't require redeemScript for non-p2sh txins.
#2264
gmaxwell on February 2, 2013
gmaxwell on February 2, 2013
pull
ApproximateBestSubset internal RNG to prevent degenerate behavior.
#2312
gmaxwell on February 15, 2013
gmaxwell on February 15, 2013
pull
Deleting everything except the wallet will not help recover from BDB errors.
#2384
gmaxwell on March 19, 2013
gmaxwell on March 19, 2013
pull
Make explicitly requested salvage operations keep going when there is an error.
#2410
gmaxwell on March 24, 2013
gmaxwell on March 24, 2013
pull
It's after 2013-05-15 forever now, so remove the code for the May 15 fork
#2657
gmaxwell on May 16, 2013
gmaxwell on May 16, 2013
pull
Update the bloom state on the real object, not the temporary one.
#2919
gmaxwell on August 21, 2013
gmaxwell on August 21, 2013
pull
[Fee logic] Don't count txins for priority to encourage sweeping.
#2945
gmaxwell on August 28, 2013
gmaxwell on August 28, 2013
pull
[wallet] Consider generated coins mature at COINBASE_MATURITY+1
#2947
gmaxwell on August 28, 2013
gmaxwell on August 28, 2013
pull
[raw] reject insanely high fees by default in sendrawtransaction
#2949
gmaxwell on August 28, 2013
gmaxwell on August 28, 2013
pull
Longer term workaround for chainstate corruption from negative versions.
#2982
gmaxwell on September 9, 2013
gmaxwell on September 9, 2013
pull
[doc] Add testnet hidden service port to the example tor config.
#3089
gmaxwell on October 14, 2013
gmaxwell on October 14, 2013
pull
Remove the IRC triggered hard last-seen check from the peer selection.
#326
gmaxwell on June 18, 2011
gmaxwell on June 18, 2011
pull
"getnetworkhashps" with defaults was yielding "0", the hashrate is not 0
#3474
gmaxwell on December 29, 2013
gmaxwell on December 29, 2013
pull
Rename IsConfirmed to IsTrusted to better match the intended behavior.
#3662
gmaxwell on February 13, 2014
gmaxwell on February 13, 2014
pull
Make the signrawtransaction docs explicit that the arguments can be 'null'
#3731
gmaxwell on February 22, 2014
gmaxwell on February 22, 2014
pull
Make GetAvailableCredit run GetHash() only once per transaction.
#3973
gmaxwell on March 28, 2014
gmaxwell on March 28, 2014
pull
Move assert(pindexNew) to above where we dereference pindexNew.
#4010
gmaxwell on April 6, 2014
gmaxwell on April 6, 2014
pull
Make -proxy set all network types, avoiding a connect leak.
#5358
gmaxwell on November 23, 2014
gmaxwell on November 23, 2014
pull
Disable SSLv3 (in favor of TLS) for the RPC client and server.
#5434
gmaxwell on December 6, 2014
gmaxwell on December 6, 2014
pull
Apply AreSane() checks to the fees from the network.
#5481
gmaxwell on December 16, 2014 Wallet
gmaxwell on December 16, 2014 Wallet
pull
Enforce minRelayTxFee on wallet created tx and add a maxtxfee option.
#5485
gmaxwell on December 16, 2014 Wallet
gmaxwell on December 16, 2014 Wallet
pull
Add unconfirmed and immature balances to getwalletinfo.
#5540
gmaxwell on December 25, 2014 Wallet
gmaxwell on December 25, 2014 Wallet
pull
Assert inside leveldbwrapper to avoid continuing after failure.
#5621
gmaxwell on January 8, 2015 Bug
gmaxwell on January 8, 2015 Bug
pull
Increase block download timeout base from 10 to 20 minutes.
#5647
gmaxwell on January 12, 2015 P2P
gmaxwell on January 12, 2015 P2P
pull
Add a -rpckeepalive and disable RPC use of HTTP persistent connections.
#5655
gmaxwell on January 14, 2015
gmaxwell on January 14, 2015
pull
Cap nAttempts penalty at 8 and switch to pow instead of a division loop.
#6029
gmaxwell on April 19, 2015
gmaxwell on April 19, 2015
pull
Avoid counting failed connect attempts when probably offline.
#6030
gmaxwell on April 19, 2015 P2P
gmaxwell on April 19, 2015 P2P
pull
Correct the help description for prune so it doesn't claim that it doesn't work with wallets.
#6644
gmaxwell on September 7, 2015 Docs
gmaxwell on September 7, 2015 Docs
pull
Enable wallet key imports without rescan in pruned mode.
#6645
gmaxwell on September 7, 2015 Wallet
gmaxwell on September 7, 2015 Wallet
pull
[Trivial] [logging] Rm extraneous cleansubver in serveral debug messages
#6646
gmaxwell on September 7, 2015 Docs
gmaxwell on September 7, 2015 Docs
pull
Test LowS in standardness, removes nuisance malleability vector.
#6769
gmaxwell on October 6, 2015 TX fees and policy
gmaxwell on October 6, 2015 TX fees and policy
pull
Reject invalid pubkeys when reading ckey items from the wallet.
#6906
gmaxwell on October 29, 2015 Wallet
gmaxwell on October 29, 2015 Wallet
pull
Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN.
#7016
gmaxwell on November 14, 2015 RPC/REST/ZMQ
gmaxwell on November 14, 2015 RPC/REST/ZMQ
pull
Move the blocknotify callback ahead of peer announcement.
#7037
gmaxwell on November 17, 2015 Mining
gmaxwell on November 17, 2015 Mining
pull
Prevent peer flooding inv request queue (redux) (redux)
#7079
gmaxwell on November 23, 2015 P2P
gmaxwell on November 23, 2015 P2P
pull
Do not absolutely protect local peers and make eviction more aggressive.
#7082
gmaxwell on November 23, 2015 P2P
gmaxwell on November 23, 2015 P2P
pull
Address mempool information leak and resource wasting attacks.
#7093
gmaxwell on November 24, 2015 P2PPrivacy
gmaxwell on November 24, 2015 P2PPrivacy
pull
Add whitelistforcerelay setting [PR changed to no longer default to off.]
#7099
gmaxwell on November 25, 2015 FeatureP2P
gmaxwell on November 25, 2015 FeatureP2P
pull
[WIP] Make trickle logic useful again, delay trickle when past upload limit.
#7123
gmaxwell on November 28, 2015 P2PPrivacy
gmaxwell on November 28, 2015 P2PPrivacy
pull
Disconnect on mempool requests from peers when over the upload limit.
#7166
gmaxwell on December 3, 2015 P2P
gmaxwell on December 3, 2015 P2P
pull
Do not absolutely protect local peers; decide group ties based on time.
#7438
gmaxwell on January 28, 2016 P2P
gmaxwell on January 28, 2016 P2P
pull
Add whitelistforcerelay to control forced relaying. [#7099 redux]
#7439
gmaxwell on January 28, 2016 P2P
gmaxwell on January 28, 2016 P2P
pull
Eliminate TX trickle bypass, sort TX invs for privacy and priority.
#7805
gmaxwell on April 4, 2016 P2P
gmaxwell on April 4, 2016 P2P
pull
Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().
#792
gmaxwell on February 1, 2012
gmaxwell on February 1, 2012
pull
Have bitcoind recommend a secure RPC password. Increase invalid password delay.
#798
gmaxwell on February 5, 2012
gmaxwell on February 5, 2012
pull
Have bitcoind recommend a secure RPC password. Increase invalid password delay.
#799
gmaxwell on February 5, 2012
gmaxwell on February 5, 2012
pull
Remove unneeded feerate param from RelayTransaction/AcceptToMemoryPool.
#8059
gmaxwell on May 16, 2016 Refactoring
gmaxwell on May 16, 2016 Refactoring
pull
Do not use mempool for GETDATA for tx accepted after the last mempool req.
#8080
gmaxwell on May 21, 2016 P2PMempool
gmaxwell on May 21, 2016 P2PMempool
pull
Add recently accepted blocks and txn to AttemptToEvictConnection.
#8084
gmaxwell on May 22, 2016 P2P
gmaxwell on May 22, 2016 P2P
pull
Evict orphans which are included or precluded by accepted blocks.
#8179
gmaxwell on June 9, 2016 P2P
gmaxwell on June 9, 2016 P2P
pull
[0.13 backport] Check for compatibility with download in FindNextBlocksToDownload
#8644
gmaxwell on September 2, 2016 Backport
gmaxwell on September 2, 2016 Backport
pull
[0.13 backport] Reduce default number of blocks to check at startup
#8646
gmaxwell on September 2, 2016 Backport
gmaxwell on September 2, 2016 Backport
pull
Do not set an addr time penalty when a peer advertises itself.
#8661
gmaxwell on September 3, 2016 P2P
gmaxwell on September 3, 2016 P2P
pull
Fetch w/o CB if mempool empty, don't use HB mode if blocks only.
#8800
gmaxwell on September 23, 2016 P2P
gmaxwell on September 23, 2016 P2P
pull
Be more agressive in getting connections to peers with relevant services.
#8949
gmaxwell on October 17, 2016 P2P
gmaxwell on October 17, 2016 P2P
pull
Use RelevantServices instead of node_network in AttemptToEvict.
#9052
gmaxwell on November 1, 2016 P2P
gmaxwell on November 1, 2016 P2P
pull
IBD using chainwork instead of height and not using header timestamps
#9053
gmaxwell on November 1, 2016 RefactoringConsensus
gmaxwell on November 1, 2016 RefactoringConsensus
pull
Always drop the least preferred HB peer when adding a new one.
#9199
gmaxwell on November 22, 2016 P2P
gmaxwell on November 22, 2016 P2P
pull
Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings
#9236
gmaxwell on November 29, 2016 Refactoring
gmaxwell on November 29, 2016 Refactoring
pull
Resolves issue #922 - "wallet passphrase timeout of several years doesn't work"
#926
gmaxwell on March 10, 2012
gmaxwell on March 10, 2012
pull
Time-based expiration in LimitOrphanTxSize only when map is full.
#9286
gmaxwell on December 6, 2016
gmaxwell on December 6, 2016
pull
Make RelayWalletTransaction attempt to AcceptToMemoryPool.
#9290
gmaxwell on December 6, 2016 Wallet
gmaxwell on December 6, 2016 Wallet
pull
[0.13 Backport] IBD using chainwork instead of height and not using header timestamp (#9053)
#9293
gmaxwell on December 6, 2016 RefactoringConsensus
gmaxwell on December 6, 2016 RefactoringConsensus
pull
Break addnode out from the outbound connection limits.
#9319
gmaxwell on December 11, 2016 RefactoringP2P
gmaxwell on December 11, 2016 RefactoringP2P
pull
[0.13] Add release notes for wallet/mempool rejections. (PR #9302 and #9290)
#9323
gmaxwell on December 11, 2016 Docs
gmaxwell on December 11, 2016 Docs
pull
Do not run functions with necessary side-effects in assert()
#9344
gmaxwell on December 14, 2016 Refactoring
gmaxwell on December 14, 2016 Refactoring
pull
Reduce latency of ThreadMessageHandler. (3.2x speedup for IBD to 200k)
#9415
gmaxwell on December 23, 2016 P2P
gmaxwell on December 23, 2016 P2P
pull
Change LogAcceptCategory to use uint32_t rather than sets of strings.
#9424
gmaxwell on December 25, 2016 RefactoringUtils/log/libs
gmaxwell on December 25, 2016 RefactoringUtils/log/libs
pull
Do not use signals for communication between net and net_processing.
#9442
gmaxwell on December 29, 2016
gmaxwell on December 29, 2016
pull
[Wallet] Do not perform ECDSA signing in the fee calculation inner loop.
#9465
gmaxwell on January 4, 2017 Wallet
gmaxwell on January 4, 2017 Wallet
pull
Introduce assumevalid setting to skip validation presumed valid scripts.
#9484
gmaxwell on January 6, 2017 Validation
gmaxwell on January 6, 2017 Validation
pull
Make FindLatestBefore use GetMedianTimePast instead of GetBlockTime.
#9489
gmaxwell on January 8, 2017
gmaxwell on January 8, 2017
pull
Replace FindLatestBefore used by importmuti with FindEarliestAtLeast.
#9490
gmaxwell on January 8, 2017 WalletValidation
gmaxwell on January 8, 2017 WalletValidation
pull
Trim down the XP notice and say more about what we support.
#9550
gmaxwell on January 14, 2017 Docs
gmaxwell on January 14, 2017 Docs
pull
Send final alert message to older peers after connecting.
#9594
gmaxwell on January 20, 2017 P2P
gmaxwell on January 20, 2017 P2P
pull
Update nMinimumChainWork and defaultAssumeValid.
#9779
gmaxwell on February 16, 2017 Validation
gmaxwell on February 16, 2017 Validation
pull
In feerate ties, prefer larger packages first.
#9886
gmaxwell on February 28, 2017 TX fees and policyMempool
gmaxwell on February 28, 2017 TX fees and policyMempool
Issues
issue
nested invalidate block doesn't work like I expect
#10439
gmaxwell on May 22, 2017 RPC/REST/ZMQ
gmaxwell on May 22, 2017 RPC/REST/ZMQ
issue
%1 instead of "Bitcoin core" on the tooltip for the open config file button
#11197
gmaxwell on August 30, 2017 GUI
gmaxwell on August 30, 2017 GUI
issue
Add release notes for how to rescan an encrypted wallet in 0.15.
#11248
gmaxwell on September 5, 2017
gmaxwell on September 5, 2017
issue
Multiwallet rescan sequentially scans multiple wallets instead of in parallel
#11756
gmaxwell on November 23, 2017 Wallet
gmaxwell on November 23, 2017 Wallet
issue
During initial sync, chain download pauses if peer goes away
#1234
gmaxwell on May 9, 2012 Bug
gmaxwell on May 9, 2012 Bug
issue
Usability: During initial sync its not obvious that txn will not be displayed
#1236
gmaxwell on May 9, 2012
gmaxwell on May 9, 2012
issue
getblockstats run with no special aguments either works or doesn't work without txindex enabled, based on what block you call it on
#14499
gmaxwell on October 16, 2018 RPC/REST/ZMQ
gmaxwell on October 16, 2018 RPC/REST/ZMQ
issue
Implement auto-fee leveling when spending unconfirmed outputs
#15553
gmaxwell on March 7, 2019 TX fees and policy
gmaxwell on March 7, 2019 TX fees and policy
issue
Bitcoind crashes if signrawtransaction on a transaction with unknown inputs
#1654
gmaxwell on August 6, 2012
gmaxwell on August 6, 2012
issue
GUI shows generic out of sync warning when the clock is wrong.
#2001
gmaxwell on November 11, 2012 GUI
gmaxwell on November 11, 2012 GUI
issue
signrawtransaction returns "complete" : false sometimes when it really is complete
#2265
gmaxwell on February 2, 2013 Bug
gmaxwell on February 2, 2013 Bug
issue
OSX apparently defaults to 256 maximum file descriptors and bad things happen
#2522
gmaxwell on April 13, 2013
gmaxwell on April 13, 2013
issue
Assert at shutdown after calling getblocktemplate a couple times at runtime (0.8.2rc2)
#2687
gmaxwell on May 23, 2013
gmaxwell on May 23, 2013
issue
Should the GUI have a "you're sending again to the same place you sent before"?
#3266
gmaxwell on November 16, 2013 GUI
gmaxwell on November 16, 2013 GUI
issue
Exposed / Compromised (must sweep) / Used / Imported (?) flags on addresses
#3314
gmaxwell on November 25, 2013 FeatureGUI
gmaxwell on November 25, 2013 FeatureGUI
issue
CBasicKeyStore::AddCScript() : redeemScripts > 520 bytes are invalid
#4313
gmaxwell on June 9, 2014 Wallet
gmaxwell on June 9, 2014 Wallet
issue
Proxy support broken when onlynet=tor is set, causing connection leak.
#5355
gmaxwell on November 23, 2014 Bug
gmaxwell on November 23, 2014 Bug
issue
Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]
#6568
gmaxwell on August 18, 2015 BrainstormingPrivacy
gmaxwell on August 18, 2015 BrainstormingPrivacy
issue
mempoolminfee returns incorrect data before the dynamic mempool limit has changed
#6941
gmaxwell on November 4, 2015 DocsRPC/REST/ZMQgood first issue
gmaxwell on November 4, 2015 DocsRPC/REST/ZMQgood first issue
issue
Deadlock during startup (Appears to be AddAddress / DNSSeed related)
#737
gmaxwell on January 2, 2012
gmaxwell on January 2, 2012
issue
"last wallet synchronisation goes beyond pruned data" on totally new pruned node
#7494
gmaxwell on February 10, 2016 BugWallet
gmaxwell on February 10, 2016 BugWallet
issue
Reindex is slow due to signature checks.
#7875
gmaxwell on April 14, 2016 ValidationResource usage
gmaxwell on April 14, 2016 ValidationResource usage
issue
Include more information sources in BIP152 decoding implementation
#8243
gmaxwell on June 22, 2016 FeatureP2P
gmaxwell on June 22, 2016 FeatureP2P
issue
Reindex seems really slow (at least with default dbcache)
#8245
gmaxwell on June 23, 2016 Validation
gmaxwell on June 23, 2016 Validation
issue
Cookie auth picks passwords which are incompatible with some URL parsers
#8399
gmaxwell on July 24, 2016 RPC/REST/ZMQgood first issue
gmaxwell on July 24, 2016 RPC/REST/ZMQgood first issue
issue
Persist mempool, arrival times, and prioritisetransaction across restarts
#8433
gmaxwell on July 31, 2016 Mempool
gmaxwell on July 31, 2016 Mempool
issue
QT: tooltip for hovering over status bar produces "Last received block was generated %n second ago."
#874
gmaxwell on February 20, 2012 BugGUI
gmaxwell on February 20, 2012 BugGUI
issue
Cannot obtain lock warning now isn't visible when daemonized.
#9009
gmaxwell on October 25, 2016 Linux/Unix
gmaxwell on October 25, 2016 Linux/Unix
issue
mempool saving doesn't save mempoolminfee
#9103
gmaxwell on November 8, 2016 TX fees and policyMempool
gmaxwell on November 8, 2016 TX fees and policyMempool
issue
Prevent fee overpayment when nFeeNeeded decreases in CreateTransaction iterations
#9466
gmaxwell on January 4, 2017 BugTX fees and policy
gmaxwell on January 4, 2017 BugTX fees and policy
issue
Importmulti api is confusing in a way that could lead to funds loss.
#9491
gmaxwell on January 8, 2017 BugWalletRPC/REST/ZMQ
gmaxwell on January 8, 2017 BugWalletRPC/REST/ZMQ