Remove unused import. Remove accidental trailing semicolons. #10137

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:python-20170402 changing 4 files +3 −7
  1. practicalswift commented at 11:30 PM on April 1, 2017: contributor

    No description provided.

  2. jnewbery commented at 11:50 PM on April 1, 2017: member

    Again? Wasn't this already done here: #10107

    and here: #9607

    Can we limit this kind of PR to one at the beginning of each release cycle?

  3. practicalswift commented at 12:28 AM on April 2, 2017: contributor

    @jnewbery Seems like the same issues are being re-introduced again and again:-)

  4. jnewbery commented at 12:43 AM on April 2, 2017: member

    Seems like it! Can I suggest the following:

    • keep one PR open with a title like "WIP: post 0.14.1 python code style nits"
    • update it with all the style nits you find during the release cycle
    • rebase it as soon as 0.14.1 is branched from master.
    • only then ask for review/merge.

    Thank you for your efforts to clean up the code. It's appreciated, but let's do it in a way that doesn't create undue work for reviewers and maintainers.

  5. MarcoFalke commented at 10:10 AM on April 2, 2017: member

    Agree with @jnewbery. This is basically the same as with Wshadow: As long as we can not enforce a specific style, such pull requests tend to harm development on the master branch. I'd suggest to do a "Fix Wshadow" and "Remove trailing semicolons" pull request after each branch off of master. It is totally fine to have style nits sit around in master and clear them up prior to a release.

  6. fanquake added the label Tests on Apr 2, 2017
  7. jonasschnelli commented at 6:43 PM on April 2, 2017: contributor

    Sorry, my fault. Though I don't think its worth to do an extra cleanup PR. Maybe someone can fix it when he touched that file for a better reason.

  8. practicalswift force-pushed on Apr 4, 2017
  9. Remove unused import b8d9a86dc3
  10. Remove accidental trailing semicolons 73b37219d4
  11. practicalswift force-pushed on Apr 4, 2017
  12. practicalswift commented at 7:31 PM on April 4, 2017: contributor

    A few additional unused imports were introduced during the last few days - removed those, squashed, rebased and pushed :-)

  13. MarcoFalke merged this on May 2, 2017
  14. MarcoFalke closed this on May 2, 2017

  15. MarcoFalke referenced this in commit 75171f099e on May 2, 2017
  16. PastaPastaPasta referenced this in commit 8431708a06 on Jun 10, 2019
  17. PastaPastaPasta referenced this in commit c40128f40e on Jun 10, 2019
  18. PastaPastaPasta referenced this in commit 8b908ba572 on Jun 10, 2019
  19. PastaPastaPasta referenced this in commit f0ce66f34b on Jun 11, 2019
  20. PastaPastaPasta referenced this in commit 0e5f1b1347 on Jun 11, 2019
  21. PastaPastaPasta referenced this in commit ad3fa7f832 on Jun 15, 2019
  22. PastaPastaPasta referenced this in commit dff1d68cd9 on Jun 19, 2019
  23. PastaPastaPasta referenced this in commit b2dd9b27f6 on Jun 19, 2019
  24. PastaPastaPasta referenced this in commit 9a38c1080e on Jun 19, 2019
  25. PastaPastaPasta referenced this in commit 43f56c1d7a on Jun 19, 2019
  26. PastaPastaPasta referenced this in commit d158702318 on Jun 19, 2019
  27. PastaPastaPasta referenced this in commit 9419534249 on Jun 19, 2019
  28. PastaPastaPasta referenced this in commit 33b4f18711 on Jun 19, 2019
  29. PastaPastaPasta referenced this in commit 2ae7e2ca2a on Jun 20, 2019
  30. barrystyle referenced this in commit 326cba2290 on Jan 22, 2020
  31. practicalswift deleted the branch on Apr 10, 2021
  32. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me