Pull-Requests
pull
[trivial] Fix a typo (introduced two days ago) in the default fee warning
#10008
practicalswift on March 16, 2017 GUI
practicalswift on March 16, 2017 GUI
pull
Fix parameter naming inconsistencies between .h and .cpp files
#10029
practicalswift on March 18, 2017 Refactoring
practicalswift on March 18, 2017 Refactoring
pull
Remove unused C++ code not covered by unit tests
#10075
practicalswift on March 25, 2017 Refactoring
practicalswift on March 25, 2017 Refactoring
pull
Remove unused variable. Remove accidental trailing semicolons in Python code
#10107
practicalswift on March 28, 2017 Tests
practicalswift on March 28, 2017 Tests
pull
Remove unused import. Remove accidental trailing semicolons.
#10137
practicalswift on April 1, 2017 Tests
practicalswift on April 1, 2017 Tests
pull
[trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)
#10180
practicalswift on April 10, 2017 Docs
practicalswift on April 10, 2017 Docs
pull
Make sure parameter names in .cpp and .h files are in sync
#10212
practicalswift on April 14, 2017 Docs
practicalswift on April 14, 2017 Docs
pull
Silence "warning: "MSG_DONTWAIT" redefined" when compiling under Linux
#10246
practicalswift on April 20, 2017
practicalswift on April 20, 2017
pull
Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)
#10314
practicalswift on May 2, 2017
practicalswift on May 2, 2017
pull
Remove unused argument from MarkBlockAsInFlight(...)
#10319
practicalswift on May 2, 2017 Refactoring
practicalswift on May 2, 2017 Refactoring
pull
Remove redundant on-the-same-line-repetition of type names (DRY): RepeatedTypeName foo = static_cast<RepeatedTypeName>(bar)
#10343
practicalswift on May 5, 2017 Refactoring
practicalswift on May 5, 2017 Refactoring
pull
Use range-based for loops (C++11) when looping over vector elements
#10346
practicalswift on May 5, 2017
practicalswift on May 5, 2017
pull
Use range-based for loops (C++11) when looping over vector elements
#10347
practicalswift on May 5, 2017 Refactoring
practicalswift on May 5, 2017 Refactoring
pull
Rename TxConfirmStats to CTxConfirmStats to achieve class naming consistency
#10378
practicalswift on May 9, 2017 Refactoring
practicalswift on May 9, 2017 Refactoring
pull
Replace boost::function with std::function (C++11)
#10395
practicalswift on May 13, 2017 Refactoring
practicalswift on May 13, 2017 Refactoring
pull
[tests] Add fuzz testing for BlockTransactions and BlockTransactionsRequest
#10409
practicalswift on May 16, 2017 Tests
practicalswift on May 16, 2017 Tests
pull
[tests] Speed up fuzzing by ~200x when using afl-fuzz
#10415
practicalswift on May 17, 2017 Tests
practicalswift on May 17, 2017 Tests
pull
[qt] Remove excess logic: Prefer "return foo;" to "if (foo) { return true; } else { return false; }"
#10421
practicalswift on May 18, 2017 Refactoring
practicalswift on May 18, 2017 Refactoring
pull
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL
#10483
practicalswift on May 31, 2017 Refactoring
practicalswift on May 31, 2017 Refactoring
pull
Use range-based for loops (C++11) when looping over map elements
#10493
practicalswift on June 1, 2017 Refactoring
practicalswift on June 1, 2017 Refactoring
pull
Use static_cast instead of C-style casts for non-fundamental types
#10498
practicalswift on June 1, 2017 Refactoring
practicalswift on June 1, 2017 Refactoring
pull
Perform member initialization in initialization lists where possible
#10523
practicalswift on June 3, 2017 Refactoring
practicalswift on June 3, 2017 Refactoring
pull
Use parentheses to clarify intended precedence when using bitwise operations
#10527
practicalswift on June 4, 2017 Refactoring
practicalswift on June 4, 2017 Refactoring
pull
Remove unreachable or otherwise redundant code
#10536
practicalswift on June 5, 2017 Refactoring
practicalswift on June 5, 2017 Refactoring
pull
[trivial] Fix typo: "occurrences" (misspelled as "occurrances")
#10538
practicalswift on June 6, 2017 Docs
practicalswift on June 6, 2017 Docs
pull
Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
#10545
practicalswift on June 6, 2017 Refactoring
practicalswift on June 6, 2017 Refactoring
pull
[tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}
#10547
practicalswift on June 7, 2017 RefactoringTests
practicalswift on June 7, 2017 RefactoringTests
pull
Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}
#10548
practicalswift on June 7, 2017 Refactoring
practicalswift on June 7, 2017 Refactoring
pull
Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon.
#10553
practicalswift on June 8, 2017 Refactoring
practicalswift on June 8, 2017 Refactoring
pull
[docs] Use the "domain name setup" image (previously unused) in the gitian docs
#10566
practicalswift on June 9, 2017 Docs
practicalswift on June 9, 2017 Docs
pull
Remove unnecessary forward class declarations in header files
#10568
practicalswift on June 9, 2017 Refactoring
practicalswift on June 9, 2017 Refactoring
pull
Remove includes in .cpp files for things the corresponding .h file already included
#10574
practicalswift on June 11, 2017 Refactoring
practicalswift on June 11, 2017 Refactoring
pull
scripted-diff: Make use of the improved handling of two consecutive right angle brackets in C++11
#10597
practicalswift on June 15, 2017 Refactoring
practicalswift on June 15, 2017 Refactoring
pull
Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >)
#10602
practicalswift on June 15, 2017 Scripts and tools
practicalswift on June 15, 2017 Scripts and tools
pull
Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class
#10631
practicalswift on June 19, 2017 Refactoring
practicalswift on June 19, 2017 Refactoring
pull
rpc: Clarify pblock assumption via an assertion
#10638
practicalswift on June 20, 2017 RPC/REST/ZMQ
practicalswift on June 20, 2017 RPC/REST/ZMQ
pull
Use nullptr (C++11) instead of zero (0) as the null pointer constant
#10645
practicalswift on June 21, 2017 Refactoring
practicalswift on June 21, 2017 Refactoring
pull
Avoid division by zero in the case of a corrupt estimates file
#10672
practicalswift on June 26, 2017 TX fees and policy
practicalswift on June 26, 2017 TX fees and policy
pull
[qt] Avoid potential null pointer dereference in TransactionView::exportClicked()
#10673
practicalswift on June 26, 2017 GUI
practicalswift on June 26, 2017 GUI
pull
Avoid usage of uninitialized values in function call arguments
#10686
practicalswift on June 28, 2017 Refactoring
practicalswift on June 28, 2017 Refactoring
pull
Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
#10694
practicalswift on June 28, 2017 RefactoringUtils/log/libs
practicalswift on June 28, 2017 RefactoringUtils/log/libs
pull
Remove redundant nullptr checks before deallocation
#10696
practicalswift on June 28, 2017 Refactoring
practicalswift on June 28, 2017 Refactoring
pull
Remove the virtual specifier for functions with the override specifier
#10701
practicalswift on June 29, 2017 Refactoring
practicalswift on June 29, 2017 Refactoring
pull
Avoid printing incorrect block indexing time due to uninitialized variable
#10714
practicalswift on July 2, 2017 Refactoring
practicalswift on July 2, 2017 Refactoring
pull
scripted-diff: Prefer x.empty() over x.size() == 0 and x.length() == 0
#10715
practicalswift on July 2, 2017 Refactoring
practicalswift on July 2, 2017 Refactoring
pull
Avoid static analyzer warnings regarding uninitialized arguments
#10735
practicalswift on July 3, 2017 Refactoring
practicalswift on July 3, 2017 Refactoring
pull
scripted-diff: Use scoped enumerations (C++11, "enum class")
#10742
practicalswift on July 4, 2017 Refactoring
practicalswift on July 4, 2017 Refactoring
pull
Use compile-time constants instead of unnamed enumerations (remove "enum hack")
#10749
practicalswift on July 5, 2017 Refactoring
practicalswift on July 5, 2017 Refactoring
pull
Use quoted form when including primitives/transaction.h and wallet/wallet.h
#10752
practicalswift on July 5, 2017 Refactoring
practicalswift on July 5, 2017 Refactoring
pull
[tests] Avoid redundant assignments. Remove unused variables
#10777
practicalswift on July 8, 2017 Tests
practicalswift on July 8, 2017 Tests
pull
Simplify "!foo || (foo && bar)" as "!foo || bar"
#10780
practicalswift on July 9, 2017 Refactoring
practicalswift on July 9, 2017 Refactoring
pull
Remove declaration of unused method: void UpdatedTransaction(const uint256 &)
#10834
practicalswift on July 15, 2017 Refactoring
practicalswift on July 15, 2017 Refactoring
pull
Don't use pass by reference to const for cheaply-copied types (bool, char, etc.)
#10839
practicalswift on July 16, 2017 Refactoring
practicalswift on July 16, 2017 Refactoring
pull
Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching.
#10842
practicalswift on July 16, 2017 Docs
practicalswift on July 16, 2017 Docs
pull
Add attribute [[noreturn]] (C++11) to functions that will not return
#10843
practicalswift on July 16, 2017 Refactoring
practicalswift on July 16, 2017 Refactoring
pull
Enable devirtualization opportunities by using the final specifier (C++11)
#10847
practicalswift on July 16, 2017 Refactoring
practicalswift on July 16, 2017 Refactoring
pull
Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition".
#10862
practicalswift on July 18, 2017 Refactoring
practicalswift on July 18, 2017 Refactoring
pull
Avoid redundant redeclaration of GetWarnings(const string&)
#10864
practicalswift on July 18, 2017 Refactoring
practicalswift on July 18, 2017 Refactoring
pull
Fix -Wthread-safety-analysis warnings. Compile with -Wthread-safety-analysis if available.
#10866
practicalswift on July 18, 2017 Refactoring
practicalswift on July 18, 2017 Refactoring
pull
[wallet] Fix wallet memory leaks in cases of unsuccessful CreateWalletFromFile calls
#10895
practicalswift on July 21, 2017 Refactoring
practicalswift on July 21, 2017 Refactoring
pull
Fix invalid checks (NULL checks after dereference, redundant checks, etc.)
#10898
practicalswift on July 21, 2017 Refactoring
practicalswift on July 21, 2017 Refactoring
pull
[tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp
#10912
practicalswift on July 22, 2017 Tests
practicalswift on July 22, 2017 Tests
pull
[qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)
#10920
practicalswift on July 24, 2017 GUI
practicalswift on July 24, 2017 GUI
pull
travis: Build with --enable-werror under OS X
#10923
practicalswift on July 25, 2017 Build system
practicalswift on July 25, 2017 Build system
pull
[init] Check non-emptiness of -blocknotify command prior to executing
#10939
practicalswift on July 26, 2017
practicalswift on July 26, 2017
pull
Avoid returning a BIP9Stats object with uninitialized values
#10957
practicalswift on July 30, 2017 Refactoring
practicalswift on July 30, 2017 Refactoring
pull
Improve readability of DecodeBase58Check(...)
#10961
practicalswift on July 31, 2017 Refactoring
practicalswift on July 31, 2017 Refactoring
pull
[bench] Restore format state of cout after printing with std::fixed/setprecision
#10963
practicalswift on July 31, 2017 Tests
practicalswift on July 31, 2017 Tests
pull
Replace deprecated throw() with noexcept specifier (C++11)
#10965
practicalswift on July 31, 2017 Refactoring
practicalswift on July 31, 2017 Refactoring
pull
Declare single-argument (non-converting) constructors "explicit"
#10969
practicalswift on August 1, 2017 Refactoring
practicalswift on August 1, 2017 Refactoring
pull
[Qt] Check return value of addr.GetKeyID(keyid) on custom change address change
#10972
practicalswift on August 1, 2017 GUI
practicalswift on August 1, 2017 GUI
pull
[script] Return early if no valid opcodes found in CountWitnessSigOps(...)
#10975
practicalswift on August 2, 2017 Refactoring
practicalswift on August 2, 2017 Refactoring
pull
[net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)
#10977
practicalswift on August 2, 2017 P2P
practicalswift on August 2, 2017 P2P
pull
wallet: Fix potential memory leak when loading a corrupted wallet file
#11007
practicalswift on August 8, 2017 Wallet
practicalswift on August 8, 2017 Wallet
pull
tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt
#11024
practicalswift on August 10, 2017 RefactoringTests
practicalswift on August 10, 2017 RefactoringTests
pull
[contrib] Add Valgrind suppressions file
#11035
practicalswift on August 12, 2017 TestsScripts and tools
practicalswift on August 12, 2017 TestsScripts and tools
pull
Use std::unique_ptr (C++11) where possible
#11043
practicalswift on August 14, 2017 Refactoring
practicalswift on August 14, 2017 Refactoring
pull
Document the preference of nullptr over NULL or (void*)0
#11066
practicalswift on August 16, 2017 Docs
practicalswift on August 16, 2017 Docs
pull
Use static_assert(…, …) (C++11) instead of assert(…) where appropriate
#11071
practicalswift on August 16, 2017 Refactoring
practicalswift on August 16, 2017 Refactoring
pull
0.15 release-notes nits: fix redundancy, remove accidental parenthesis & fix range style
#11076
practicalswift on August 17, 2017 Docs
practicalswift on August 17, 2017 Docs
pull
[script] Avoid implicit casts from bool to CScriptNum
#11110
practicalswift on August 22, 2017 Refactoring
practicalswift on August 22, 2017 Refactoring
pull
[developer-notes] By default, declare single-argument constructors "explicit"
#11112
practicalswift on August 22, 2017 Docs
practicalswift on August 22, 2017 Docs
pull
Document assumptions that are being made to avoid NULL pointer dereferences
#11132
practicalswift on August 25, 2017 Docs
practicalswift on August 25, 2017 Docs
pull
Document assumptions that are being made to avoid division by zero
#11133
practicalswift on August 25, 2017 Refactoring
practicalswift on August 25, 2017 Refactoring
pull
[tests] Remove unused imports (script.OP_0 and script.sha256)
#11190
practicalswift on August 29, 2017 Tests
practicalswift on August 29, 2017 Tests
pull
[Qt] Terminate string *pszExePath after readlink and without using memset
#11193
practicalswift on August 29, 2017 GUI
practicalswift on August 29, 2017 GUI
pull
[WIP] Add Clang thread safety analysis annotations: GUARDED_BY(lock) / EXCLUSIVE_LOCKS_REQUIRED(lock)
#11226
practicalswift on September 3, 2017 Refactoring
practicalswift on September 3, 2017 Refactoring
pull
scripted-diff: Use <cxxx> instead of deprecated <xxx.h> when including C compatibility headers
#11261
practicalswift on September 6, 2017 Refactoring
practicalswift on September 6, 2017 Refactoring
pull
[doc] Fix broken Markdown table in dependencies.md
#11264
practicalswift on September 7, 2017 Docs
practicalswift on September 7, 2017 Docs
pull
Remove redundant LOCK(…) and AssertLockHeld(…)
#11361
practicalswift on September 18, 2017 Refactoring
practicalswift on September 18, 2017 Refactoring
pull
doc: Document locks - increase LOCK(...) comment coverage from 2 % to 77 %
#11369
practicalswift on September 19, 2017 Docs
practicalswift on September 19, 2017 Docs
pull
build: Make "make clean" remove all files created when running "make check"
#11435
practicalswift on October 1, 2017 Build system
practicalswift on October 1, 2017 Build system
pull
Avoid assertion failure in coin control dialog. Fixes #11501.
#11509
practicalswift on October 16, 2017
practicalswift on October 16, 2017
pull
crypto: Add test cases covering the relevant HMAC-SHA{256,512} key length boundaries
#11516
practicalswift on October 17, 2017 Refactoring
practicalswift on October 17, 2017 Refactoring
pull
Avoid unintentional unsigned integer wraparounds
#11535
practicalswift on October 20, 2017 Refactoring
practicalswift on October 20, 2017 Refactoring
pull
Avoid unintended unsigned integer wraparounds in FormatScript(...) and SplitHostPort(...)
#11547
practicalswift on October 22, 2017
practicalswift on October 22, 2017
pull
Fix unsigned integer wrap-around in GetBlockProofEquivalentTime
#11551
practicalswift on October 23, 2017 Refactoring
practicalswift on October 23, 2017 Refactoring
pull
Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN
#11577
practicalswift on October 30, 2017 RefactoringP2P
practicalswift on October 30, 2017 RefactoringP2P
pull
net: Add missing lock in ProcessHeadersMessage(...)
#11578
practicalswift on October 30, 2017 P2P
practicalswift on October 30, 2017 P2P
pull
Fix warnings when building with -Wthread-safety-analysis
#11587
practicalswift on October 31, 2017 P2P
practicalswift on October 31, 2017 P2P
pull
wallet: Assert holding cs_wallet lock in GetAvailableCredit/GetAvailableWatchOnlyCredit [wip]
#11591
practicalswift on November 1, 2017 Wallet
practicalswift on November 1, 2017 Wallet
pull
Add missing cs_main locks when accessing chainActive
#11596
practicalswift on November 2, 2017 Refactoring
practicalswift on November 2, 2017 Refactoring
pull
Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning
#11617
practicalswift on November 6, 2017 Validation
practicalswift on November 6, 2017 Validation
pull
rpc: Lock cs_main in blockToJSON/blockheaderToJSON
#11618
practicalswift on November 6, 2017 RPC/REST/ZMQ
practicalswift on November 6, 2017 RPC/REST/ZMQ
pull
wallet: Add missing cs_wallet/cs_KeyStore locks to wallet
#11634
practicalswift on November 8, 2017 Wallet
practicalswift on November 8, 2017 Wallet
pull
Add missing locks: validation.cpp + related
#11652
practicalswift on November 10, 2017 Refactoring
practicalswift on November 10, 2017 Refactoring
pull
tests: Initialize recently introduced non-static class member lastCycles to zero in constructor
#11654
practicalswift on November 10, 2017 Tests
practicalswift on November 10, 2017 Tests
pull
net: Assert state.m_chain_sync.m_work_header in ConsiderEviction
#11655
practicalswift on November 10, 2017 P2P
practicalswift on November 10, 2017 P2P
pull
wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...)
#11682
practicalswift on November 14, 2017 Wallet
practicalswift on November 14, 2017 Wallet
pull
tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports.
#11683
practicalswift on November 14, 2017 Tests
practicalswift on November 14, 2017 Tests
pull
mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…)
#11689
practicalswift on November 14, 2017 Mempool
practicalswift on November 14, 2017 Mempool
pull
rpc: Add missing lock in getblocktemplate(...). Work around Clang thread safety analysis quirks.
#11691
practicalswift on November 15, 2017 RPC/REST/ZMQ
practicalswift on November 15, 2017 RPC/REST/ZMQ
pull
Remove unused Boost include. Move Boost include.
#11692
practicalswift on November 15, 2017 Refactoring
practicalswift on November 15, 2017 Refactoring
pull
rpc: Add missing cs_main lock in getblocktemplate(...)
#11694
practicalswift on November 15, 2017 RPC/REST/ZMQ
practicalswift on November 15, 2017 RPC/REST/ZMQ
pull
rpc: Work around Clang thread safety analysis quirks
#11734
practicalswift on November 20, 2017 RPC/REST/ZMQ
practicalswift on November 20, 2017 RPC/REST/ZMQ
pull
wallet: Set m_last_block_processed to nullptr in SetNull()
#11749
practicalswift on November 22, 2017 Wallet
practicalswift on November 22, 2017 Wallet
pull
wallet: Add missing cs_wallet locks when accessing m_last_block_processed
#11754
practicalswift on November 22, 2017 Wallet
practicalswift on November 22, 2017 Wallet
pull
Avoid locking mutexes that are already held by the same thread
#11762
practicalswift on November 24, 2017 Refactoring
practicalswift on November 24, 2017 Refactoring
pull
net: Avoid locking cs_vNodes twice when calling FindNode(...). Add NodeExists(...).
#11795
practicalswift on November 30, 2017 RefactoringP2P
practicalswift on November 30, 2017 RefactoringP2P
pull
wallet: Add compile-time checking of (non-)locking assumptions for BlockUntilSyncedToCurrentChain() [wip]
#11799
practicalswift on November 30, 2017 Wallet
practicalswift on November 30, 2017 Wallet
pull
tests: Remove unused variable (firstAddrnServices)
#11946
practicalswift on December 19, 2017 Tests
practicalswift on December 19, 2017 Tests
pull
Remove assigned but never used local variables. Enable Travis checking for unused local variables.
#12284
practicalswift on January 28, 2018 Tests
practicalswift on January 28, 2018 Tests
pull
Enable flake8 warnings for all currently non-violated rules
#12295
practicalswift on January 29, 2018 Tests
practicalswift on January 29, 2018 Tests
pull
Fix Windows build errors introduced in #10498
#12416
practicalswift on February 12, 2018 GUIWindows
practicalswift on February 12, 2018 GUIWindows
pull
Avoid unintentional unsigned integer wraparounds in tests
#12516
practicalswift on February 23, 2018 Tests
practicalswift on February 23, 2018 Tests
pull
tests: List skipped flake8 warnings (rather than listing enabled warnings)
#12534
practicalswift on February 25, 2018 Tests
practicalswift on February 25, 2018 Tests
pull
Remove redundant includes. Conform to header include guidelines.
#12542
practicalswift on February 26, 2018 Refactoring
practicalswift on February 26, 2018 Refactoring
pull
util: Print timestamp strings in logs using ISO 8601 formatting
#12567
practicalswift on February 28, 2018 Utils/log/libs
practicalswift on February 28, 2018 Utils/log/libs
pull
net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s
#12569
practicalswift on February 28, 2018 Utils/log/libs
practicalswift on February 28, 2018 Utils/log/libs
pull
interpreter: Use safer casting in IsValidSignatureEncoding(...)
#12611
practicalswift on March 6, 2018 RefactoringConsensus
practicalswift on March 6, 2018 RefactoringConsensus
pull
bitcoin-cli: Provide a better error message when bitcoind is not running
#12652
practicalswift on March 9, 2018 Utils/log/libs
practicalswift on March 9, 2018 Utils/log/libs
pull
Add compile time checking for run time locking assertions
#12665
practicalswift on March 10, 2018 Refactoring
practicalswift on March 10, 2018 Refactoring
pull
mempool: Avoid locking mutex that is already held by the same thread
#12671
practicalswift on March 11, 2018
practicalswift on March 11, 2018
pull
Add -ftrapv to CFLAGS and CXXFLAGS when --enable-debug is used. Enable -ftrapv in Travis.
#12686
practicalswift on March 14, 2018 Tests
practicalswift on March 14, 2018 Tests
pull
log: Be less confusing in the way we inform the user that logging has started
#12707
practicalswift on March 16, 2018 Utils/log/libs
practicalswift on March 16, 2018 Utils/log/libs
pull
tests: Add note about test suite naming convention in developer-notes.md
#12719
practicalswift on March 18, 2018 Tests
practicalswift on March 18, 2018 Tests
pull
tests: Remove unused argument max_invalid from check_estimates(...)
#12746
practicalswift on March 21, 2018 Tests
practicalswift on March 21, 2018 Tests
pull
Initialize nVersionDummy to zero in deserialization code
#12767
practicalswift on March 23, 2018 Refactoring
practicalswift on March 23, 2018 Refactoring
pull
Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion
#12770
practicalswift on March 23, 2018 Refactoring
practicalswift on March 23, 2018 Refactoring
pull
Don't test size_t variables for negative values
#12781
practicalswift on March 25, 2018 Refactoring
practicalswift on March 25, 2018 Refactoring
pull
Explicitly state our assumptions about LookupBlockIndex(...) return values
#12782
practicalswift on March 26, 2018 Refactoring
practicalswift on March 26, 2018 Refactoring
pull
Fix bug in memory usage calculation (unintended integer division)
#12784
practicalswift on March 26, 2018
practicalswift on March 26, 2018
pull
wallet: Initialize m_last_block_processed to nullptr
#12785
practicalswift on March 26, 2018 Wallet
practicalswift on March 26, 2018 Wallet
pull
rpc: Adjust ifdef to avoid unreachable code
#12787
practicalswift on March 26, 2018 RefactoringRPC/REST/ZMQ
practicalswift on March 26, 2018 RefactoringRPC/REST/ZMQ
pull
Don't return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...)
#12789
practicalswift on March 26, 2018 Refactoring
practicalswift on March 26, 2018 Refactoring
pull
doc: Add note about our preference for scoped enumerations ("enum class")
#12800
practicalswift on March 27, 2018
practicalswift on March 27, 2018
pull
Add shell script linting: Check for shellcheck warnings in shell scripts
#12871
practicalswift on April 3, 2018 Scripts and tools
practicalswift on April 3, 2018 Scripts and tools
pull
tests: Make test_bitcoin pass under ThreadSanitzer (clang). Fix lock-order-inversion (potential deadlock).
#12882
practicalswift on April 4, 2018 Tests
practicalswift on April 4, 2018 Tests
pull
tests: Add note about test suite name uniqueness requirement to developer notes
#12895
practicalswift on April 5, 2018 Tests
practicalswift on April 5, 2018 Tests
pull
docs: Fix conflicting statements about initialization in developer notes
#12896
practicalswift on April 5, 2018 Docs
practicalswift on April 5, 2018 Docs
pull
Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash
#12897
practicalswift on April 5, 2018 Refactoring
practicalswift on April 5, 2018 Refactoring
pull
build: Show enabled sanitizers in configure output
#12901
practicalswift on April 6, 2018 Build system
practicalswift on April 6, 2018 Build system
pull
scripted-diff: Remove redundant license reference (HTTP URL)
#12914
practicalswift on April 8, 2018 Docs
practicalswift on April 8, 2018 Docs
pull
qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor
#12928
practicalswift on April 9, 2018 GUI
practicalswift on April 9, 2018 GUI
pull
logs: Make the columns in subsequent UpdateTip log entries horizontally aligned
#12984
practicalswift on April 14, 2018 Utils/log/libs
practicalswift on April 14, 2018 Utils/log/libs
pull
tests/tools: Enable additional Python flake8 rules for automatic linting via Travis
#12987
practicalswift on April 15, 2018 Scripts and tools
practicalswift on April 15, 2018 Scripts and tools
pull
tests: Remove compatibility code not needed now when we're on Python 3
#12993
practicalswift on April 16, 2018 Tests
practicalswift on April 16, 2018 Tests
pull
Print to console by default when not run with -daemon
#13004
practicalswift on April 17, 2018 Utils/log/libs
practicalswift on April 17, 2018 Utils/log/libs
pull
Make --enable-debug to pick better options
#13005
practicalswift on April 17, 2018 Build system
practicalswift on April 17, 2018 Build system
pull
build: Add linter checking for accidental introduction of locale dependence
#13041
practicalswift on April 20, 2018 Scripts and tools
practicalswift on April 20, 2018 Scripts and tools
pull
tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
#13054
practicalswift on April 22, 2018 Tests
practicalswift on April 22, 2018 Tests
pull
Add compile time checking for all cs_KeyStore runtime locking assertions
#13077
practicalswift on April 25, 2018 Refactoring
practicalswift on April 25, 2018 Refactoring
pull
mempool: Add compile time checking for ::mempool.cs runtime locking assertions
#13080
practicalswift on April 25, 2018 Refactoring
practicalswift on April 25, 2018 Refactoring
pull
wallet: Add compile time checking for cs_wallet runtime locking assertions
#13081
practicalswift on April 25, 2018 Refactoring
practicalswift on April 25, 2018 Refactoring
pull
Add compile time checking for cs_main runtime locking assertions
#13083
practicalswift on April 25, 2018 Refactoring
practicalswift on April 25, 2018 Refactoring
pull
tests: Make it clear that MAX_INV_SZ is not covered by functional tests
#13113
practicalswift on April 29, 2018 Tests
practicalswift on April 29, 2018 Tests
pull
wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore
#13114
practicalswift on April 29, 2018 Refactoring
practicalswift on April 29, 2018 Refactoring
pull
addrman: Add Clang thread safety annotations for variables guarded by CAddrMan.cs
#13115
practicalswift on April 29, 2018 Refactoring
practicalswift on April 29, 2018 Refactoring
pull
Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}
#13116
practicalswift on April 29, 2018 Refactoring
practicalswift on April 29, 2018 Refactoring
pull
net: Add Clang thread safety annotations for guarded variables in the networking code
#13123
practicalswift on April 30, 2018 RefactoringP2P
practicalswift on April 30, 2018 RefactoringP2P
pull
scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending
#13125
practicalswift on April 30, 2018 Refactoring
practicalswift on April 30, 2018 Refactoring
pull
util: Add Clang thread safety annotations for variables guarded by cs_args
#13126
practicalswift on April 30, 2018 Utils/log/libs
practicalswift on April 30, 2018 Utils/log/libs
pull
wallet: Add Clang thread safety annotations for variables guarded by cs_db
#13127
practicalswift on April 30, 2018 Wallet
practicalswift on April 30, 2018 Wallet
pull
policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator
#13128
practicalswift on April 30, 2018 Refactoring
practicalswift on April 30, 2018 Refactoring
pull
logging: Fix potential use-after-free in LogPrintStr(...)
#13148
practicalswift on May 2, 2018 Utils/log/libs
practicalswift on May 2, 2018 Utils/log/libs
pull
Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP)
#13159
practicalswift on May 3, 2018 Utils/log/libs
practicalswift on May 3, 2018 Utils/log/libs
pull
Make it clear which functions that are intended to be translation unit local
#13163
practicalswift on May 3, 2018 Refactoring
practicalswift on May 3, 2018 Refactoring
pull
Enable Travis checking for two Python linting rules we are currently not violating
#13214
practicalswift on May 11, 2018 Scripts and tools
practicalswift on May 11, 2018 Scripts and tools
pull
travis: Rename the build stage "check_doc" to "lint"
#13221
practicalswift on May 12, 2018 Tests
practicalswift on May 12, 2018 Tests
pull
Simplify include analysis by enforcing the developer guide's include syntax
#13230
practicalswift on May 14, 2018 Scripts and tools
practicalswift on May 14, 2018 Scripts and tools
pull
build: Use -DDEBUG_ADDRMAN when building with --enable-debug
#13232
practicalswift on May 14, 2018 Build system
practicalswift on May 14, 2018 Build system
pull
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
#13249
practicalswift on May 16, 2018 Refactoring
practicalswift on May 16, 2018 Refactoring
pull
Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
#13294
practicalswift on May 21, 2018 Linux/Unix
practicalswift on May 21, 2018 Linux/Unix
pull
docs: Update OpenBSD build instructions for OpenBSD 6.3
#13295
practicalswift on May 21, 2018 DocsLinux/Unix
practicalswift on May 21, 2018 DocsLinux/Unix
pull
docs: Add a note about the source code filename naming convention
#13312
practicalswift on May 23, 2018 Docs
practicalswift on May 23, 2018 Docs
pull
Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling
#13355
practicalswift on May 31, 2018 Tests
practicalswift on May 31, 2018 Tests
pull
util: Don't throw in GetTime{Millis,Micros}(). Mark as noexcept.
#13382
practicalswift on June 3, 2018 Utils/log/libs
practicalswift on June 3, 2018 Utils/log/libs
pull
bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
#13383
practicalswift on June 3, 2018 Tests
practicalswift on June 3, 2018 Tests
pull
build: Guard against accidental introduction of new Boost dependencies
#13385
practicalswift on June 3, 2018 Scripts and tools
practicalswift on June 3, 2018 Scripts and tools
pull
Make tinyformat noexcept: Use default error handling (assert(0 && reason)) on incorrect format strings
#13391
practicalswift on June 4, 2018 Utils/log/libs
practicalswift on June 4, 2018 Utils/log/libs
pull
util: Make strprintf noexcept. Improve error message on format string error.
#13392
practicalswift on June 4, 2018 Utils/log/libs
practicalswift on June 4, 2018 Utils/log/libs
pull
Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python
#13448
practicalswift on June 12, 2018 Scripts and tools
practicalswift on June 12, 2018 Scripts and tools
pull
Add linter: Enforce the source code file naming convention described in the developer notes
#13450
practicalswift on June 12, 2018 Scripts and tools
practicalswift on June 12, 2018 Scripts and tools
pull
Make sure LC_ALL=C is set in all shell scripts
#13454
practicalswift on June 13, 2018 Build systemScripts and tools
practicalswift on June 13, 2018 Build systemScripts and tools
pull
Follow-up to #13454: Fix broken build by exporting LC_ALL=C
#13494
practicalswift on June 18, 2018 Scripts and tools
practicalswift on June 18, 2018 Scripts and tools
pull
Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions.
#13503
practicalswift on June 19, 2018 Linux/Unix
practicalswift on June 19, 2018 Linux/Unix
pull
Don't assert(foo()) where foo() has side effects
#13534
practicalswift on June 25, 2018 Refactoring
practicalswift on June 25, 2018 Refactoring
pull
tests: Fix test case streams_serializedata_xor. Remove Boost dependency.
#13545
practicalswift on June 27, 2018 Tests
practicalswift on June 27, 2018 Tests
pull
wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...)
#13546
practicalswift on June 27, 2018 Wallet
practicalswift on June 27, 2018 Wallet
pull
Document assumptions made in PeerLogicValidation::SendMessages(...) and rescanblockchain(...)
#13548
practicalswift on June 27, 2018 Refactoring
practicalswift on June 27, 2018 Refactoring
pull
tests: Fix incorrect documentation for test case cuckoocache_hit_rate_ok
#13551
practicalswift on June 27, 2018 Tests
practicalswift on June 27, 2018 Tests
pull
wallet: Introduce assertion to document the assumption that cache and cache_used are always set in tandem
#13683
practicalswift on July 17, 2018 Wallet
practicalswift on July 17, 2018 Wallet
pull
script: Avoid side effect in RHS operand (MISRA-C). Clarify intended logic.
#13684
practicalswift on July 17, 2018 Refactoring
practicalswift on July 17, 2018 Refactoring
pull
Remove redundant variables, statements and forward declarations
#13691
practicalswift on July 17, 2018 Refactoring
practicalswift on July 17, 2018 Refactoring
pull
wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation.
#13712
practicalswift on July 19, 2018 Wallet
practicalswift on July 19, 2018 Wallet
pull
build: Make lint-locale-dependence.sh work with BSD grep (avoid empty subexpressions)
#13720
practicalswift on July 19, 2018 Tests
practicalswift on July 19, 2018 Tests
pull
Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers.
#13766
practicalswift on July 26, 2018 Refactoring
practicalswift on July 26, 2018 Refactoring
pull
gui: Don't access static members from class instances
#13768
practicalswift on July 26, 2018 GUIRefactoring
practicalswift on July 26, 2018 GUIRefactoring
pull
Mark single-argument constructors "explicit"
#13769
practicalswift on July 26, 2018 Refactoring
practicalswift on July 26, 2018 Refactoring
pull
wallet: Fix accidental use of the comma operator
#13773
practicalswift on July 26, 2018 Refactoring
practicalswift on July 26, 2018 Refactoring
pull
Return void instead of bool for functions that cannot fail
#13774
practicalswift on July 26, 2018 Refactoring
practicalswift on July 26, 2018 Refactoring
pull
net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)
#13776
practicalswift on July 27, 2018 P2P
practicalswift on July 27, 2018 P2P
pull
build: Add missing [[noreturn]] to handleRunawayException(...). Enable -Wsuggest-attribute=noreturn if available.
#13795
practicalswift on July 29, 2018 Build system
practicalswift on July 29, 2018 Build system
pull
Don't use zero as null pointer constant. Use nullptr (C++11).
#13802
practicalswift on July 30, 2018 Refactoring
practicalswift on July 30, 2018 Refactoring
pull
util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
#13815
practicalswift on July 31, 2018 Scripts and tools
practicalswift on July 31, 2018 Scripts and tools
pull
validation: Document where we are intentionally ignoring bool return values from validation related functions
#13864
practicalswift on August 3, 2018 RefactoringDocs
practicalswift on August 3, 2018 RefactoringDocs
pull
clientversion: Define only macros we’ll use
#13897
practicalswift on August 6, 2018 Refactoring
practicalswift on August 6, 2018 Refactoring
pull
build: Enable -Wredundant-decls where available. Remove redundant redeclarations.
#13899
practicalswift on August 6, 2018 Build system
practicalswift on August 6, 2018 Build system
pull
prevector: Suppress two -Wmaybe-uninitialized (gcc) warnings in indirect_ptr(...)
#13902
practicalswift on August 7, 2018 Refactoring
practicalswift on August 7, 2018 Refactoring
pull
validation: Pass chainparams in AcceptToMemoryPoolWorker(...)
#13909
practicalswift on August 8, 2018 Refactoring
practicalswift on August 8, 2018 Refactoring
pull
build: Enable -Wdocumentation (clang) if available
#13914
practicalswift on August 8, 2018 Docs
practicalswift on August 8, 2018 Docs
pull
refactor: Make globals easier to identify by prefixing them g_. Avoid declaring variable and type in the same statement.
#13919
practicalswift on August 8, 2018
practicalswift on August 8, 2018
pull
lint: Make format string linter understand basic template parameter syntax
#13939
practicalswift on August 10, 2018 Tests
practicalswift on August 10, 2018 Tests
pull
Warn (don't fail!) on spelling errors. Fix typos reported by codespell.
#13954
practicalswift on August 13, 2018 Tests
practicalswift on August 13, 2018 Tests
pull
Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*)
#13969
practicalswift on August 14, 2018
practicalswift on August 14, 2018
pull
Add tests and error handling to DecodeExtPubKey/DecodeExtKey. Add [[nodiscard]].
#13971
practicalswift on August 14, 2018
practicalswift on August 14, 2018
pull
tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization
#14010
practicalswift on August 20, 2018
practicalswift on August 20, 2018
pull
Move cs_main locking annotations from .cpp to .h
#14063
practicalswift on August 25, 2018 Refactoring
practicalswift on August 25, 2018 Refactoring
pull
tests: Dry run bench_bitcoin as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code
#14092
practicalswift on August 28, 2018 Build systemTests
practicalswift on August 28, 2018 Build systemTests
pull
tests: Fix accidental trunction from int to bool
#14093
practicalswift on August 28, 2018 Tests
practicalswift on August 28, 2018 Tests
pull
refactoring: Remove unreferenced local variables
#14094
practicalswift on August 28, 2018 Refactoring
practicalswift on August 28, 2018 Refactoring
pull
wallet: Remove unused function GetLabelDestination
#14107
practicalswift on August 30, 2018 Wallet
practicalswift on August 30, 2018 Wallet
pull
tests: Add missing locking annotations and locks (g_cs_orphans)
#14108
practicalswift on August 30, 2018 Tests
practicalswift on August 30, 2018 Tests
pull
lint: Make all linters work under the default macOS dev environment (build-osx.md)
#14115
practicalswift on August 30, 2018 Scripts and tools
practicalswift on August 30, 2018 Scripts and tools
pull
wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG.
#14138
practicalswift on September 3, 2018 Wallet
practicalswift on September 3, 2018 Wallet
pull
windows: Fix remaining compiler warnings (MSVC)
#14151
practicalswift on September 5, 2018 WindowsValidation
practicalswift on September 5, 2018 WindowsValidation
pull
lint: Make Travis linting output less verbose in case of no violations
#14159
practicalswift on September 6, 2018 Tests
practicalswift on September 6, 2018 Tests
pull
Improve code readability. Exhaustive changes for each class of cleanup.
#14178
practicalswift on September 9, 2018
practicalswift on September 9, 2018
pull
Annotate unused parameters with [[maybe_unused]]
#14194
practicalswift on September 10, 2018 Build system
practicalswift on September 10, 2018 Build system
pull
Don’t condition on expressions known already at compile time to always evaluate to true (or false). Use assertions instead.
#14201
practicalswift on September 11, 2018 Refactoring
practicalswift on September 11, 2018 Refactoring
pull
lint: Check for use of NULL instead of nullptr
#14205
practicalswift on September 12, 2018 Tests
practicalswift on September 12, 2018 Tests
pull
Use MakeUnique to construct objects owned by unique_ptrs
#14211
practicalswift on September 12, 2018 Refactoring
practicalswift on September 12, 2018 Refactoring
pull
mempool: Document unsigned integer wraparounds in CTxMemPoolEntry::UpdateAncestorState(...)
#14218
practicalswift on September 14, 2018 Docs
practicalswift on September 14, 2018 Docs
pull
mempool: Fix unsigned integer wraparounds in the mempool code
#14223
practicalswift on September 15, 2018 Mempool
practicalswift on September 15, 2018 Mempool
pull
Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations
#14224
practicalswift on September 15, 2018 RefactoringTests
practicalswift on September 15, 2018 RefactoringTests
pull
mempool: Fix unintended unsigned integer wraparound in CTxMemPool::UpdateAncestorsOf(bool add, …) when add is false
#14226
practicalswift on September 15, 2018 Mempool
practicalswift on September 15, 2018 Mempool
pull
net: Avoid using the value of a potentially invalid pointer (hSocket after close)
#14233
practicalswift on September 16, 2018
practicalswift on September 16, 2018
pull
Avoid dividing by zero in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet)
#14239
practicalswift on September 17, 2018 Wallet
practicalswift on September 17, 2018 Wallet
pull
Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...)
#14242
practicalswift on September 17, 2018 Refactoring
practicalswift on September 17, 2018 Refactoring
pull
build: Run functional tests and benchmarks under the undefined behaviour sanitizer (UBSan)
#14252
practicalswift on September 18, 2018 Tests
practicalswift on September 18, 2018 Tests
pull
build: Add address sanitizer (ASan) Travis job
#14254
practicalswift on September 18, 2018 Tests
practicalswift on September 18, 2018 Tests
pull
Remove redundant parameter fCheckDuplicateInputs from CheckTransaction(...)
#14258
practicalswift on September 18, 2018 Refactoring
practicalswift on September 18, 2018 Refactoring
pull
tests: Use MakeUnique to construct objects owned by unique_ptrs
#14287
practicalswift on September 21, 2018 DocsTests
practicalswift on September 21, 2018 DocsTests
pull
rest: Do not re-use the function name ParseHashStr (core_io.h) for a function with different behaviour in rest.cpp
#14288
practicalswift on September 21, 2018 RefactoringRPC/REST/ZMQ
practicalswift on September 21, 2018 RefactoringRPC/REST/ZMQ
pull
streams: Fix broken streams_vector_reader test. Remove unused seek(size_t).
#14357
practicalswift on September 30, 2018
practicalswift on September 30, 2018
pull
tests: Add Python dead code linter (vulture) to Travis
#14365
practicalswift on October 2, 2018 Tests
practicalswift on October 2, 2018 Tests
pull
Remove redundant run time assertions for locks already checked at compile time
#14443
practicalswift on October 9, 2018 Refactoring
practicalswift on October 9, 2018 Refactoring
pull
Add compile time checking for cs_main locks which we assert at run time
#14444
practicalswift on October 9, 2018 Refactoring
practicalswift on October 9, 2018 Refactoring
pull
serialize: Document integer width assumptions we are making when calculating compact sizes
#14475
practicalswift on October 13, 2018 Refactoring
practicalswift on October 13, 2018 Refactoring
pull
serialization: Don't invoke undefined behaviour when doing type punning
#14479
practicalswift on October 14, 2018 Refactoring
practicalswift on October 14, 2018 Refactoring
pull
build: Pin to specific versions of Python packages we install from PyPI in Travis
#14496
practicalswift on October 16, 2018 Tests
practicalswift on October 16, 2018 Tests
pull
test: Add linter to make sure single parameter constructors are marked explicit
#14505
practicalswift on October 17, 2018 Tests
practicalswift on October 17, 2018 Tests
pull
Remove redundancies: redundant forward declaration, redundant namespace, redundant copying, redundant conditionals
#14506
practicalswift on October 17, 2018 Refactoring
practicalswift on October 17, 2018 Refactoring
pull
Avoid triggering undefined behaviour in base_uint<BITS>::bits()
#14510
practicalswift on October 18, 2018
practicalswift on October 18, 2018
pull
Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
#14513
practicalswift on October 18, 2018 Refactoring
practicalswift on October 18, 2018 Refactoring
pull
wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held
#14560
practicalswift on October 24, 2018 RefactoringWallet
practicalswift on October 24, 2018 RefactoringWallet
pull
refactor: remove usage of locale dependent std::isspace
#14585
practicalswift on October 26, 2018 Refactoring
practicalswift on October 26, 2018 Refactoring
pull
Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. Remove the use of locale dependent boost::is_space(...)
#14599
practicalswift on October 29, 2018 Refactoring
practicalswift on October 29, 2018 Refactoring
pull
rpc: Make HTTP RPC debug logging more informative
#14618
practicalswift on October 31, 2018 RPC/REST/ZMQ
practicalswift on October 31, 2018 RPC/REST/ZMQ
pull
travis: Fail the UBSan Travis build in case of newly introduced UBSan errors
#14673
practicalswift on November 6, 2018 Tests
practicalswift on November 6, 2018 Tests
pull
Avoid reading uninitialized variables in serialization code (triggered when running "make check")
#14757
practicalswift on November 19, 2018
practicalswift on November 19, 2018
pull
tests: Add AddressSanitizer (ASan) Travis build
#14794
practicalswift on November 23, 2018 Tests
practicalswift on November 23, 2018 Tests
pull
travis: Enable functional tests in the ThreadSanitizer (TSan) build job
#14829
practicalswift on November 28, 2018 Tests
practicalswift on November 28, 2018 Tests
pull
tests: Test for expected return values when calling functions returning a success code
#14935
practicalswift on December 12, 2018 Tests
practicalswift on December 12, 2018 Tests
pull
scripts: Remove Python 2 import workarounds
#14947
practicalswift on December 13, 2018 TestsScripts and tools
practicalswift on December 13, 2018 TestsScripts and tools
pull
tests: Fix cuckoocache_tests TSAN failure introduced in 14935.
#14969
practicalswift on December 15, 2018 Tests
practicalswift on December 15, 2018 Tests
pull
rpc: Fix data race (UB) in InterruptRPC()
#14993
practicalswift on December 18, 2018 RPC/REST/ZMQ
practicalswift on December 18, 2018 RPC/REST/ZMQ
pull
Avoid UB (member call on nullptr) when failing to read randomness in the startup process
#15111
practicalswift on January 5, 2019
practicalswift on January 5, 2019
pull
Fix invalid memory write in case of failing mmap(...) in PosixLockedPageAllocator::AllocateLocked
#15117
practicalswift on January 6, 2019
practicalswift on January 6, 2019
pull
tests: Switch one of the Travis jobs to an unsigned char environment (-funsigned-char)
#15134
practicalswift on January 9, 2019 Tests
practicalswift on January 9, 2019 Tests
pull
fees: Complete the removal of fee-estimation file read code for old versions
#15187
practicalswift on January 17, 2019 Refactoring
practicalswift on January 17, 2019 Refactoring
pull
validation: Add missing lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId.
#15189
practicalswift on January 17, 2019
practicalswift on January 17, 2019
pull
validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations.
#15191
practicalswift on January 17, 2019 Validation
practicalswift on January 17, 2019 Validation
pull
Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache(). Add missing locking annotations.
#15192
practicalswift on January 17, 2019 RPC/REST/ZMQValidation
practicalswift on January 17, 2019 RPC/REST/ZMQValidation
pull
net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes.
#15201
practicalswift on January 18, 2019 P2P
practicalswift on January 18, 2019 P2P
pull
tests: Check for expected return values when calling functions returning a success code
#15214
practicalswift on January 20, 2019 RefactoringTests
practicalswift on January 20, 2019 RefactoringTests
pull
rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]].
#15215
practicalswift on January 20, 2019 RPC/REST/ZMQP2P
practicalswift on January 20, 2019 RPC/REST/ZMQP2P
pull
build: Enable C++14 in build, require C++14 compiler.
#15262
practicalswift on January 25, 2019 Build system
practicalswift on January 25, 2019 Build system
pull
tests: Add script checking for deterministic line coverage in unit tests
#15296
practicalswift on January 30, 2019 Scripts and tools
practicalswift on January 30, 2019 Scripts and tools
pull
tests: Make test updatecoins_simulation_test deterministic
#15327
practicalswift on February 2, 2019 Tests
practicalswift on February 2, 2019 Tests
pull
tests: Reduce noise level in test_bitcoin output
#15352
practicalswift on February 6, 2019 Tests
practicalswift on February 6, 2019 Tests
pull
Add compile time verification of assumptions we're currently making implicitly/tacitly
#15391
practicalswift on February 12, 2019
practicalswift on February 12, 2019
pull
tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree
#15413
practicalswift on February 15, 2019 Tests
practicalswift on February 15, 2019 Tests
pull
Document sizeof(size_t) assumptions and compiler assumptions in assumptions.h
#15522
practicalswift on March 4, 2019 Refactoring
practicalswift on March 4, 2019 Refactoring
pull
Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter
#15532
practicalswift on March 4, 2019 Refactoring
practicalswift on March 4, 2019 Refactoring
pull
tests: Teach lint-whitespace.sh to detect missing newline at end of file
#15589
practicalswift on March 13, 2019 Tests
practicalswift on March 13, 2019 Tests
pull
Remove global symbols: Avoid using the global namespace if possible
#15622
practicalswift on March 19, 2019 Refactoring
practicalswift on March 19, 2019 Refactoring
pull
Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
#15699
practicalswift on March 29, 2019 Refactoring
practicalswift on March 29, 2019 Refactoring
pull
validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld)
#15721
practicalswift on April 2, 2019 Validation
practicalswift on April 2, 2019 Validation
pull
log: Increase signal-to-noise in bitcoind standard output. Don't print debug output "Pre-allocating to position ..." and "Leaving block file ..." when running with -nodebug (default).
#15805
practicalswift on April 12, 2019 Utils/log/libs
practicalswift on April 12, 2019 Utils/log/libs
pull
contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py
#15806
practicalswift on April 12, 2019 Scripts and tools
practicalswift on April 12, 2019 Scripts and tools
pull
Add tests for (or remove) untested unused methods
#15814
practicalswift on April 14, 2019 Refactoring
practicalswift on April 14, 2019 Refactoring
pull
Remove unused OpenSSL includes to make it more clear where OpenSSL is used
#15919
practicalswift on April 29, 2019 RefactoringBuild system
practicalswift on April 29, 2019 RefactoringBuild system
pull
refactor: Silence "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp
#15938
practicalswift on May 2, 2019 Refactoring
practicalswift on May 2, 2019 Refactoring
pull
Add locking annotations for RewindBlockIndex and GetNetworkHashPS. Add missing locks.
#15962
practicalswift on May 6, 2019 WalletTestsRPC/REST/ZMQMiningValidation
practicalswift on May 6, 2019 WalletTestsRPC/REST/ZMQMiningValidation
pull
validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue
#15971
practicalswift on May 7, 2019 Validation
practicalswift on May 7, 2019 Validation
pull
validation: Hold cs_main when reading chainActive in RewindBlockIndex
#16015
practicalswift on May 12, 2019 Validation
practicalswift on May 12, 2019 Validation
pull
Hold cs_main when reading chainActive via getTipLocator(). Remove assumeLocked().
#16033
practicalswift on May 16, 2019 Refactoring
practicalswift on May 16, 2019 Refactoring
pull
refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it
#16034
practicalswift on May 16, 2019 Refactoring
practicalswift on May 16, 2019 Refactoring
pull
Skip redundant memset(p, 0, 0) calls where p is not valid for writing
#16045
practicalswift on May 19, 2019 Refactoring
practicalswift on May 19, 2019 Refactoring
pull
scripted-diff: Complete the move from CCriticalSection to identical RecursiveMutex (both are AnnotatedMixin<std::recursive_mutex>)
#16084
practicalswift on May 24, 2019 Refactoring
practicalswift on May 24, 2019 Refactoring
pull
Don't use global (external) symbols for symbols that are used in only one translation unit
#16092
practicalswift on May 26, 2019 Refactoring
practicalswift on May 26, 2019 Refactoring
pull
Add an optional extra level of checking: ASSUME(...) - an opt-in side-effect safe assert(...)
#16136
practicalswift on June 2, 2019 Build system
practicalswift on June 2, 2019 Build system
pull
tests: Mark unit test blockfilter_index_initial_sync as non-deterministic
#16143
practicalswift on June 4, 2019 TestsScripts and tools
practicalswift on June 4, 2019 TestsScripts and tools
pull
Simplify header analysis/reasoning by splitting core_io.h into the expected core_read.h/core_write.h (matching core_read.cpp/core_write.cpp)
#16166
practicalswift on June 7, 2019 Refactoring
practicalswift on June 7, 2019 Refactoring
pull
addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors
#16212
practicalswift on June 14, 2019 Refactoring
practicalswift on June 14, 2019 Refactoring
pull
tests: Mark test coins_tests/updatecoins_simulation_test as non-deterministic
#16221
practicalswift on June 16, 2019 TestsScripts and tools
practicalswift on June 16, 2019 TestsScripts and tools
pull
tests: Make coins_tests/updatecoins_simulation_test deterministic
#16225
practicalswift on June 17, 2019 Tests
practicalswift on June 17, 2019 Tests
pull
build: Remove unused C++ standard library includes
#16238
practicalswift on June 18, 2019 Refactoring
practicalswift on June 18, 2019 Refactoring
pull
tests: Reduce memory usage by 0.5 GB when compiling script_tests.cpp
#16312
practicalswift on June 29, 2019 Tests
practicalswift on June 29, 2019 Tests
pull
ci: Add Travis check to make sure unit test coverage reports stay deterministic
#16320
practicalswift on July 1, 2019 Tests
practicalswift on July 1, 2019 Tests
pull
build: Add configure option --enable-lowmem to allow for building in low-memory environments
#16331
practicalswift on July 3, 2019 Build system
practicalswift on July 3, 2019 Build system
pull
tests: Use colors and dots in test_runner.py output only if standard output is a terminal
#16561
practicalswift on August 7, 2019 Tests
practicalswift on August 7, 2019 Tests
pull
refactoring: Remove unused includes
#16659
practicalswift on August 19, 2019 RefactoringNeeds Conceptual Review
practicalswift on August 19, 2019 RefactoringNeeds Conceptual Review
pull
tests: Avoid common Python default parameter gotcha when mutable dict/list:s are used as default parameter values
#16726
practicalswift on August 26, 2019 Tests
practicalswift on August 26, 2019 Tests
pull
doc: Document MemPoolAccept::Finalize(...) precondition
#16915
practicalswift on September 19, 2019 Docs
practicalswift on September 19, 2019 Docs
pull
tests: Add information on how to add Vulture suppressions
#16921
practicalswift on September 19, 2019 Tests
practicalswift on September 19, 2019 Tests
pull
tests: Add test_fuzzing_harnesses.sh for quick testing/verification of fuzzing harness coverage
#17000
practicalswift on September 30, 2019 TestsScripts and tools
practicalswift on September 30, 2019 TestsScripts and tools
pull
tests: Add descriptor Parse(...) fuzzing harness
#17018
practicalswift on October 2, 2019 TestsDescriptors
practicalswift on October 2, 2019 TestsDescriptors
pull
tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and HD keypaths (bip32)
#17050
practicalswift on October 4, 2019 Tests
practicalswift on October 4, 2019 Tests
pull
tests: Pass fuzzing inputs as constant references
#17069
practicalswift on October 7, 2019 RefactoringTests
practicalswift on October 7, 2019 RefactoringTests
pull
tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions
#17071
practicalswift on October 7, 2019 Tests
practicalswift on October 7, 2019 Tests
pull
tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions
#17076
practicalswift on October 8, 2019 Tests
practicalswift on October 8, 2019 Tests
pull
tests: Add fuzzing harness for various CScript related functions
#17083
practicalswift on October 9, 2019 Tests
practicalswift on October 9, 2019 Tests
pull
tests: Add fuzzing harness for various CTx{In,Out} related functions
#17093
practicalswift on October 10, 2019 Tests
practicalswift on October 10, 2019 Tests
pull
tests: Add fuzzing harness for various functions consuming only integrals
#17109
practicalswift on October 11, 2019 Tests
practicalswift on October 11, 2019 Tests
pull
tests: Add fuzzing harness for descriptor Span-parsing helpers
#17113
practicalswift on October 12, 2019 Tests
practicalswift on October 12, 2019 Tests
pull
tests: Add fuzzing harness for miniscript::FromScript(...)
#17129
practicalswift on October 13, 2019 Tests
practicalswift on October 13, 2019 Tests
pull
tests: Add fuzzing harness for various PSBT related functions
#17136
practicalswift on October 14, 2019 Tests
practicalswift on October 14, 2019 Tests
pull
ci: Enable address sanitizer (ASan) stack-use-after-return checking
#17205
practicalswift on October 21, 2019 Tests
practicalswift on October 21, 2019 Tests
pull
Make all tests pass UBSan without using any UBSan suppressions
#17208
practicalswift on October 21, 2019 Refactoring
practicalswift on October 21, 2019 Refactoring
pull
tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation.
#17209
practicalswift on October 21, 2019 Tests
practicalswift on October 21, 2019 Tests
pull
tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible.
#17225
practicalswift on October 23, 2019 Tests
practicalswift on October 23, 2019 Tests
pull
tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions
#17229
practicalswift on October 23, 2019 Tests
practicalswift on October 23, 2019 Tests
pull
tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed.
#17235
practicalswift on October 23, 2019 Tests
practicalswift on October 23, 2019 Tests
pull
tests: Fix fuzzers eval_script and script_flags by re-adding ECCVerifyHandle dependency
#17274
practicalswift on October 27, 2019 Tests
practicalswift on October 27, 2019 Tests
pull
pubkey: Assert CPubKey's ECCVerifyHandle precondition
#17275
practicalswift on October 27, 2019 Tests
practicalswift on October 27, 2019 Tests
pull
tests: Add fuzzing harness for ISO-8601 related functions
#17291
practicalswift on October 28, 2019 Tests
practicalswift on October 28, 2019 Tests
pull
Make compiler warn about tautological run-time comparisons
#17320
practicalswift on October 30, 2019 Build systemConsensusUtils/log/libs
practicalswift on October 30, 2019 Build systemConsensusUtils/log/libs
pull
tests: Add fuzzing harness for Bech32 encoding/decoding
#17357
practicalswift on November 3, 2019 Tests
practicalswift on November 3, 2019 Tests
pull
net: Fix an uninitialized read in ProcessMessage(…, "tx", …) when receiving a transaction we already have
#17624
practicalswift on November 27, 2019 P2P
practicalswift on November 27, 2019 P2P
pull
tests: Add option --valgrind to run the functional tests under Valgrind
#17633
practicalswift on November 29, 2019 Tests
practicalswift on November 29, 2019 Tests
pull
tests: Add "make check-valgrind" to run the unit tests under Valgrind
#17639
practicalswift on November 30, 2019 TestsReview club
practicalswift on November 30, 2019 TestsReview club
pull
random: Add missing thread-safety annotations for events_hasher
#17666
practicalswift on December 4, 2019 Utils/log/libs
practicalswift on December 4, 2019 Utils/log/libs
pull
tests: Add initialization order fiasco detection in Travis
#17674
practicalswift on December 5, 2019 Tests
practicalswift on December 5, 2019 Tests
pull
tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli
#17675
practicalswift on December 5, 2019 Tests
practicalswift on December 5, 2019 Tests
pull
tests: Fix bug in the descriptor parsing fuzzing harness (descriptor_parse)
#17685
practicalswift on December 6, 2019 Tests
practicalswift on December 6, 2019 Tests
pull
util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.
#17721
practicalswift on December 11, 2019 TestsUtils/log/libs
practicalswift on December 11, 2019 TestsUtils/log/libs
pull
util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.
#17753
practicalswift on December 16, 2019 TestsUtils/log/libs
practicalswift on December 16, 2019 TestsUtils/log/libs
pull
net: Don't allow resolving of std::string with embedded NUL characters. Add tests.
#17754
practicalswift on December 16, 2019 P2P
practicalswift on December 16, 2019 P2P
pull
util: Don't depend on locale when trimming strings. Add tests.
#17760
practicalswift on December 17, 2019 TestsRPC/REST/ZMQ
practicalswift on December 17, 2019 TestsRPC/REST/ZMQ
pull
tests: Add fuzzing harness for V1TransportDeserializer (P2P transport)
#17771
practicalswift on December 18, 2019 Tests
practicalswift on December 18, 2019 Tests
pull
net: Use log categories when logging events that P2P peers can trigger arbitrarily
#17828
practicalswift on December 29, 2019 P2PUtils/log/libsUp for grabs
practicalswift on December 29, 2019 P2PUtils/log/libsUp for grabs
pull
tests: Add std::to_string to list of locale dependent functions
#17851
practicalswift on January 2, 2020 Tests
practicalswift on January 2, 2020 Tests
pull
tests: Avoid accumulating allocated memory in a global state if LogPrintf is called when fuzzing
#17894
practicalswift on January 7, 2020 Tests
practicalswift on January 7, 2020 Tests
pull
build: Enable Clang's -Wconditional-uninitialized to warn on potential uninitialized reads
#17895
practicalswift on January 8, 2020 Build system
practicalswift on January 8, 2020 Build system
pull
tests: Add amount compression/decompression fuzzing to existing fuzzing harness
#17917
practicalswift on January 13, 2020 Tests
practicalswift on January 13, 2020 Tests
pull
tests: Add key_io fuzzing harness. Fuzz additional functions in existing fuzzing harnesses.
#17926
practicalswift on January 14, 2020 Tests
practicalswift on January 14, 2020 Tests
pull
tests: Add fuzzing harness for CKey and key related functions
#17972
practicalswift on January 21, 2020 Tests
practicalswift on January 21, 2020 Tests
pull
tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer.
#17989
practicalswift on January 23, 2020 Tests
practicalswift on January 23, 2020 Tests
pull
tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals
#17996
practicalswift on January 24, 2020 Tests
practicalswift on January 24, 2020 Tests
pull
tests: Add fuzzing harness for AS-mapping (asmap)
#18029
practicalswift on January 30, 2020 Tests
practicalswift on January 30, 2020 Tests
pull
tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h)
#18047
practicalswift on February 1, 2020 Tests
practicalswift on February 1, 2020 Tests
pull
tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...)
#18109
practicalswift on February 10, 2020 Tests
practicalswift on February 10, 2020 Tests
pull
init: Clarify C and C++ locale assumptions. Add locale sanity checks to verify assumptions at run-time.
#18124
practicalswift on February 11, 2020 Tests
practicalswift on February 11, 2020 Tests
pull
tests: Add fuzzing harness testing the locale independence of the strencodings.h functions
#18126
practicalswift on February 12, 2020 Tests
practicalswift on February 12, 2020 Tests
pull
qt: Kill the locale dependency bug class by not allowing Qt to mess with LC_NUMERIC
#18147
practicalswift on February 14, 2020 GUITests
practicalswift on February 14, 2020 GUITests
pull
tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker
#18155
practicalswift on February 15, 2020 Tests
practicalswift on February 15, 2020 Tests
pull
tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind
#18159
practicalswift on February 16, 2020 Tests
practicalswift on February 16, 2020 Tests
pull
util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t) by checking gmtime_s/gmtime_r return value
#18162
practicalswift on February 16, 2020 Utils/log/libs
practicalswift on February 16, 2020 Utils/log/libs
pull
ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors
#18166
practicalswift on February 17, 2020 Tests
practicalswift on February 17, 2020 Tests
pull
tests: Add fuzzing harness for CScript and CScriptNum operations
#18176
practicalswift on February 18, 2020 Tests
practicalswift on February 18, 2020 Tests
pull
tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
#18190
practicalswift on February 21, 2020 Build systemTests
practicalswift on February 21, 2020 Build systemTests
pull
build: Enable AddressSanitizer as part of --enable-debug
#18199
practicalswift on February 23, 2020 Build system
practicalswift on February 23, 2020 Build system
pull
tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter)
#18206
practicalswift on February 25, 2020 Tests
practicalswift on February 25, 2020 Tests
pull
util: Fail to parse whitespace-only strings in ParseMoney(...) (instead of parsing as zero)
#18270
practicalswift on March 5, 2020 TestsUtils/log/libs
practicalswift on March 5, 2020 TestsUtils/log/libs
pull
test: Add locale fuzzer to FUZZERS_MISSING_CORPORA
#18286
practicalswift on March 6, 2020 Tests
practicalswift on March 6, 2020 Tests
pull
build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory
#18288
practicalswift on March 7, 2020 Build systemTests
practicalswift on March 7, 2020 Build systemTests
pull
tests: Remove exclusion of the feature_block test in the Travis ThreadSanitizer (TSan) job
#18293
practicalswift on March 8, 2020 Tests
practicalswift on March 8, 2020 Tests
pull
tests: Update FUZZERS_MISSING_CORPORA to enable regression fuzzing for all harnesses in master
#18299
practicalswift on March 9, 2020
practicalswift on March 9, 2020
pull
depends: Make it possible to build Boost dependency using a clang toolset (./b2 toolset=clang)
#18308
practicalswift on March 10, 2020 Build system
practicalswift on March 10, 2020 Build system
pull
tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage.
#18314
practicalswift on March 11, 2020 Tests
practicalswift on March 11, 2020 Tests
pull
doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz
#18342
practicalswift on March 13, 2020 Docs
practicalswift on March 13, 2020 Docs
pull
tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions
#18353
practicalswift on March 15, 2020 Tests
practicalswift on March 15, 2020 Tests
pull
tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions
#18363
practicalswift on March 17, 2020 Tests
practicalswift on March 17, 2020 Tests
pull
tests: Don't assume presence of __builtin_mul_overflow(…) in MultiplicationOverflow(…) fuzzing harness
#18393
practicalswift on March 20, 2020 Tests
practicalswift on March 20, 2020 Tests
pull
tests: Add fuzzing harnesses for functions in addrdb.h, net_permissions.h and timedata.h
#18417
practicalswift on March 24, 2020 Tests
practicalswift on March 24, 2020 Tests
pull
tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing.
#18423
practicalswift on March 24, 2020 Tests
practicalswift on March 24, 2020 Tests
pull
util: Make our stringstream usage locale independent
#18432
practicalswift on March 25, 2020 Utils/log/libs
practicalswift on March 25, 2020 Utils/log/libs
pull
tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h
#18445
practicalswift on March 26, 2020 Tests
practicalswift on March 26, 2020 Tests
pull
util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting
#18450
practicalswift on March 27, 2020 RefactoringUtils/log/libs
practicalswift on March 27, 2020 RefactoringUtils/log/libs
pull
tests: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h
#18455
practicalswift on March 28, 2020 Tests
practicalswift on March 28, 2020 Tests
pull
Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx
#18539
practicalswift on April 6, 2020 RPC/REST/ZMQ
practicalswift on April 6, 2020 RPC/REST/ZMQ
pull
tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage.
#18565
practicalswift on April 8, 2020
practicalswift on April 8, 2020
pull
tests: Add std::locale::global to list of locale dependent functions
#18649
practicalswift on April 15, 2020 Tests
practicalswift on April 15, 2020 Tests
pull
chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found
#18657
practicalswift on April 15, 2020
practicalswift on April 15, 2020
pull
test: Add fuzzing harnesses for various classes/functions in util/
#18736
practicalswift on April 22, 2020 Build systemTests
practicalswift on April 22, 2020 Build systemTests
pull
doc: Document how to fuzz Bitcoin Core using Honggfuzz
#18739
practicalswift on April 22, 2020 Docs
practicalswift on April 22, 2020 Docs
pull
test: Add fuzzing harnesses for various classes/functions in primitives/
#18744
practicalswift on April 22, 2020 Tests
practicalswift on April 22, 2020 Tests
pull
test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer
#18757
practicalswift on April 24, 2020 Tests
practicalswift on April 24, 2020 Tests
pull
tests: Add fuzzing harnesses for various classes/functions in policy/ (CBlockPolicyEstimator, IsRBFOptIn(…), etc.)
#18775
practicalswift on April 26, 2020 Tests
practicalswift on April 26, 2020 Tests
pull
wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction
#18782
practicalswift on April 27, 2020 Wallet
practicalswift on April 27, 2020 Wallet
pull
tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h
#18783
practicalswift on April 27, 2020 Tests
practicalswift on April 27, 2020 Tests
pull
doc: Document differences in bitcoind and bitcoin-qt locale handling
#18817
practicalswift on April 29, 2020 GUIDocs
practicalswift on April 29, 2020 GUIDocs
pull
Remove CCoinsViewCache::GetValueIn(...)
#18859
practicalswift on May 3, 2020 TestsUTXO Db and Indexes
practicalswift on May 3, 2020 TestsUTXO Db and Indexes
pull
ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors
#18912
practicalswift on May 8, 2020 Tests
practicalswift on May 8, 2020 Tests
pull
doc: Document how to analyze Bitcoin Core using Clang Static Analysis, clang-tidy and cppcheck
#18920
practicalswift on May 9, 2020 Docs
practicalswift on May 9, 2020 Docs
pull
tests: Fill fuzzing coverage gaps for functions in consensus/validation.h, primitives/block.h and util/translation.h
#18938
practicalswift on May 10, 2020 Tests
practicalswift on May 10, 2020 Tests
pull
tests: Add fuzzing harnesses for functions in script/
#18994
practicalswift on May 17, 2020 Tests
practicalswift on May 17, 2020 Tests
pull
build: Enable some commonly enabled compiler diagnostics
#19015
practicalswift on May 19, 2020 Build system
practicalswift on May 19, 2020 Build system
pull
tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)
#19052
practicalswift on May 22, 2020 Tests
practicalswift on May 22, 2020 Tests
pull
tests: Use BasicTestingSetup to initialise fuzzing environment
#19074
practicalswift on May 26, 2020 Tests
practicalswift on May 26, 2020 Tests
pull
tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests
#19140
practicalswift on June 2, 2020 Tests
practicalswift on June 2, 2020 Tests
pull
tests: Add fuzzing harnesses for CAutoFile, CBufferedFile, LoadExternalBlockFile and other FILE* consumers
#19143
practicalswift on June 2, 2020 Build systemTests
practicalswift on June 2, 2020 Build systemTests
pull
net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket.
#19203
practicalswift on June 7, 2020 P2P
practicalswift on June 7, 2020 P2P
pull
tests: Add fuzzing harness for {Read,Write}{LE,BE}{16,32,64} (crypto/common.h)
#19247
practicalswift on June 11, 2020 Tests
practicalswift on June 11, 2020 Tests
pull
fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...)
#19259
practicalswift on June 12, 2020 Tests
practicalswift on June 12, 2020 Tests
pull
tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc.
#19286
practicalswift on June 15, 2020 Build systemTests
practicalswift on June 15, 2020 Build systemTests
pull
tests: Add fuzzing harness for AES{CBC,}256{Encrypt,Decrypt}, poly1305_auth, CHKDF_HMAC_SHA256_L32, ChaCha20 and ChaCha20Poly1305AEAD
#19296
practicalswift on June 16, 2020 Tests
practicalswift on June 16, 2020 Tests
pull
tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz.
#19366
practicalswift on June 23, 2020 Tests
practicalswift on June 23, 2020 Tests
pull
tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)
#19379
practicalswift on June 25, 2020 Tests
practicalswift on June 25, 2020 Tests
pull
log: Prefix log messages with function name and source code location if -logsourcelocations is set
#19809
practicalswift on August 25, 2020 Utils/log/libs
practicalswift on August 25, 2020 Utils/log/libs
pull
tests: Add fuzzing harness for Keccak and SHA3_256
#19934
practicalswift on September 10, 2020 Tests
practicalswift on September 10, 2020 Tests
pull
fuzz: Add fuzzing harness for node eviction logic
#19972
practicalswift on September 18, 2020 P2P
practicalswift on September 18, 2020 P2P
pull
log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)"
#19984
practicalswift on September 20, 2020 Utils/log/libs
practicalswift on September 20, 2020 Utils/log/libs
pull
log: Mitigate disk filling attacks by temporarily rate limiting LogPrintf(…)
#19995
practicalswift on September 22, 2020 Utils/log/libs
practicalswift on September 22, 2020 Utils/log/libs
pull
net: Use proxy server 127.0.0.1 if -proxy is specified without arguments (instead of continuing without proxy server)
#20001
practicalswift on September 23, 2020 P2P
practicalswift on September 23, 2020 P2P
pull
net: Exit with error message if -proxy is specified without arguments (instead of continuing without proxy server)
#20003
practicalswift on September 23, 2020 P2P
practicalswift on September 23, 2020 P2P
pull
init: Fix incorrect warning "Reducing -maxconnections from N to N-1, because of system limitations"
#20024
practicalswift on September 26, 2020
practicalswift on September 26, 2020
pull
validation: Increase robustness when loading malformed mempool.dat files (LoadMempool)
#20089
practicalswift on October 5, 2020 Validation
practicalswift on October 5, 2020 Validation
pull
Make Assert(…) usable in all contexts. Make implicit assumptions explicit.
#20122
practicalswift on October 11, 2020 P2PValidationUtils/log/libs
practicalswift on October 11, 2020 P2PValidationUtils/log/libs
pull
tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk)
#20137
practicalswift on October 12, 2020 Tests
practicalswift on October 12, 2020 Tests
pull
Taproot follow-up: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract
#20169
practicalswift on October 16, 2020 RefactoringConsensus
practicalswift on October 16, 2020 RefactoringConsensus
pull
fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 serialization.
#20247
practicalswift on October 26, 2020 Tests
practicalswift on October 26, 2020 Tests
pull
fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService
#20289
practicalswift on November 2, 2020 Tests
practicalswift on November 2, 2020 Tests
pull
net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)
#20302
practicalswift on November 4, 2020 RefactoringP2P
practicalswift on November 4, 2020 RefactoringP2P
pull
fuzz: Assert expected DecodeHexTx behaviour when using legacy decoding
#20303
practicalswift on November 4, 2020 Tests
practicalswift on November 4, 2020 Tests
pull
fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet
#20355
practicalswift on November 9, 2020 Tests
practicalswift on November 9, 2020 Tests
pull
Avoid signed integer overflow when loading a mempool.dat file with a malformed time field
#20372
practicalswift on November 11, 2020 Validation
practicalswift on November 11, 2020 Validation
pull
fuzz: Improve coverage for CPartialMerkleTree fuzzing harness
#20375
practicalswift on November 11, 2020 Tests
practicalswift on November 11, 2020 Tests
pull
tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp)
#20379
practicalswift on November 12, 2020 Tests
practicalswift on November 12, 2020 Tests
pull
doc: Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver
#20380
practicalswift on November 12, 2020 Docs
practicalswift on November 12, 2020 Docs
pull
Avoid signed integer overflow and invalid integer negation when loading malformed mempool.dat files
#20383
practicalswift on November 13, 2020 Build systemRPC/REST/ZMQMiningValidationMempoolUtils/log/libs
practicalswift on November 13, 2020 Build systemRPC/REST/ZMQMiningValidationMempoolUtils/log/libs
pull
util: Avoid invalid integer negation in FormatMoney and ValueFromAmount
#20406
practicalswift on November 16, 2020 RefactoringUtils/log/libs
practicalswift on November 16, 2020 RefactoringUtils/log/libs
pull
fuzz: Make CAddrMan fuzzing harness deterministic
#20425
practicalswift on November 19, 2020 Tests
practicalswift on November 19, 2020 Tests
pull
fuzz: Avoid time-based "non-determinism" in fuzzing harnesses by using mocked GetTime()
#20437
practicalswift on November 20, 2020 Tests
practicalswift on November 20, 2020 Tests
pull
util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)
#20452
practicalswift on November 22, 2020 Utils/log/libs
practicalswift on November 22, 2020 Utils/log/libs
pull
util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull}
#20457
practicalswift on November 23, 2020 Utils/log/libs
practicalswift on November 23, 2020 Utils/log/libs
pull
test: Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s
#20472
practicalswift on November 24, 2020 Tests
practicalswift on November 24, 2020 Tests
pull
net: Add unit testing of node eviction logic
#20477
practicalswift on November 24, 2020 TestsP2PReview club
practicalswift on November 24, 2020 TestsP2PReview club
pull
Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
#20487
practicalswift on November 25, 2020 Build systemUtils/log/libs
practicalswift on November 25, 2020 Build systemUtils/log/libs
pull
Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17).
#20499
practicalswift on November 25, 2020 Refactoring
practicalswift on November 25, 2020 Refactoring
pull
Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).
#20519
practicalswift on November 27, 2020 ValidationUtils/log/libs
practicalswift on November 27, 2020 ValidationUtils/log/libs
pull
Do not run functions with necessary side-effects in assert()
#20575
practicalswift on December 5, 2020 Refactoring
practicalswift on December 5, 2020 Refactoring
pull
Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const
#20581
practicalswift on December 6, 2020 Refactoring
practicalswift on December 6, 2020 Refactoring
pull
Declare de facto const reference variables/member functions as const
#20584
practicalswift on December 6, 2020 Refactoring
practicalswift on December 6, 2020 Refactoring
pull
fuzz: Update FuzzedDataProvider.h from upstream (LLVM)
#20740
practicalswift on December 21, 2020 Tests
practicalswift on December 21, 2020 Tests
pull
fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsanitize=integer
#21000
practicalswift on January 24, 2021 Tests
practicalswift on January 24, 2021 Tests
pull
fuzz: Avoid designated initialization (C++20) in fuzz tests
#21037
practicalswift on January 30, 2021 Tests
practicalswift on January 30, 2021 Tests
pull
log: Move "Pre-allocating up to position 0x[…] in […].dat" log message to debug category
#21041
practicalswift on January 31, 2021 Utils/log/libs
practicalswift on January 31, 2021 Utils/log/libs
pull
Add GitHub Codespaces integration to allow for easy onboarding of future generations of contributors
#21068
practicalswift on February 2, 2021 BrainstormingScripts and tools
practicalswift on February 2, 2021 BrainstormingScripts and tools
pull
fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%.
#21169
practicalswift on February 13, 2021 Tests
practicalswift on February 13, 2021 Tests
pull
test: Add test for CNetAddr::ToString IPv6 address formatting (RFC 5952)
#21477
practicalswift on March 19, 2021 Tests
practicalswift on March 19, 2021 Tests
pull
fuzz: Add fuzzing syscall sandbox: detect use of unexpected syscalls when fuzzing ("syscall sanitizer")
#21538
practicalswift on March 28, 2021 Tests
practicalswift on March 28, 2021 Tests
pull
net: Avoid calling getnameinfo when formatting IPv4 addresses in CNetAddr::ToStringIP
#21564
practicalswift on April 1, 2021 P2P
practicalswift on April 1, 2021 P2P
pull
test: Replace file level integer overflow suppression with function level suppression
#21599
practicalswift on April 4, 2021 Tests
practicalswift on April 4, 2021 Tests
pull
fuzz: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock
#21677
practicalswift on April 14, 2021 Tests
practicalswift on April 14, 2021 Tests
pull
test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic`
#21689
practicalswift on April 15, 2021 Tests
practicalswift on April 15, 2021 Tests
pull
Avoid calling `getnameinfo` when formatting IPv6 addresses in `CNetAddr::ToStringIP`
#21756
practicalswift on April 22, 2021 P2P
practicalswift on April 22, 2021 P2P
pull
fuzz: Terminate immediately if a fuzzing harness tries to perform a DNS lookup (belt and suspenders)
#21795
practicalswift on April 28, 2021 Tests
practicalswift on April 28, 2021 Tests
pull
Update reviewers file: Remove too broad (`*.sh`) entry. Keep narrower entries.
#21842
practicalswift on May 3, 2021
practicalswift on May 3, 2021
pull
fuzz: Add `-fsanitize=integer` suppression needed for RPC fuzzer (`generateblock`)
#21846
practicalswift on May 3, 2021
practicalswift on May 3, 2021
pull
fuzz: Terminate immediately if a fuzzing harness tries to create a TCP socket (belt and suspenders)
#21936
practicalswift on May 12, 2021 Tests
practicalswift on May 12, 2021 Tests
pull
Document that `ser_float_to_uint32` is not the inverse of `ser_uint32_to_float`
#21964
practicalswift on May 16, 2021
practicalswift on May 16, 2021
pull
Mark `CheckTxInputs` `[[nodiscard]]`. Avoid UUM in fuzzing harness `coins_view`.
#22065
practicalswift on May 25, 2021 Tests
practicalswift on May 25, 2021 Tests
pull
[qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)
#9528
practicalswift on January 12, 2017 Refactoring
practicalswift on January 12, 2017 Refactoring
pull
Bug fix: Update the instance variable self.lastDate (not the locally scoped variable lastDate)
#9529
practicalswift on January 12, 2017
practicalswift on January 12, 2017
pull
[util] Remove redundant call to get() on smart pointer (thread_specific_ptr)
#9538
practicalswift on January 12, 2017
practicalswift on January 12, 2017
pull
[net] Avoid initialization to a value that is never read
#9539
practicalswift on January 12, 2017 Refactoring
practicalswift on January 12, 2017 Refactoring
pull
[trivial] Add end of namespace comments. Improve consistency.
#9544
practicalswift on January 13, 2017 Docs
practicalswift on January 13, 2017 Docs
pull
bench: Assert that division by zero is unreachable
#9547
practicalswift on January 13, 2017 Tests
practicalswift on January 13, 2017 Tests
pull
[net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...)
#9549
practicalswift on January 14, 2017 P2P
practicalswift on January 14, 2017 P2P
pull
Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0;
#9553
practicalswift on January 14, 2017 Refactoring
practicalswift on January 14, 2017 Refactoring
pull
[test] Avoid potential NULL pointer dereference in addrman_tests.cpp
#9554
practicalswift on January 14, 2017 Tests
practicalswift on January 14, 2017 Tests
pull
[test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp)
#9555
practicalswift on January 14, 2017 Tests
practicalswift on January 14, 2017 Tests
pull
[net] Avoid possibility of NULL pointer dereference in ProcessMessage(...)
#9559
practicalswift on January 14, 2017 P2P
practicalswift on January 14, 2017 P2P
pull
[rpc] Avoid possibility of NULL pointer dereference in getblocktemplate(...)
#9560
practicalswift on January 14, 2017
practicalswift on January 14, 2017
pull
[pep-8] Prefer "foo is None" to "foo == None". Prefer "foo not in bar" to "not foo in bar".
#9581
practicalswift on January 19, 2017
practicalswift on January 19, 2017
pull
Improve readability by removing redundant casts to same type
#9590
practicalswift on January 19, 2017 Refactoring
practicalswift on January 19, 2017 Refactoring
pull
Improve readability by removing redundant casts to same type (on all platforms)
#9598
practicalswift on January 20, 2017 Refactoring
practicalswift on January 20, 2017 Refactoring
pull
[trivial] Fix recently introduced typos in comments
#9696
practicalswift on February 6, 2017 Docs
practicalswift on February 6, 2017 Docs
pull
[trivial] Fix three typos introduced into walletdb.h in commit 7184e25
#9936
practicalswift on March 7, 2017 Docs
practicalswift on March 7, 2017 Docs
pull
[bench] Avoid function call arguments which are pointers to uninitialized values
#9949
practicalswift on March 8, 2017 Tests
practicalswift on March 8, 2017 Tests
Issues
issue
Feature request: Make Bitcoin libFuzzer-friendly and consider integration into the OSS-Fuzz project
#10364
practicalswift on May 8, 2017 BrainstormingTests
practicalswift on May 8, 2017 BrainstormingTests
issue
Meta-issue: Add Clang thread safety analysis annotations
#13129
practicalswift on April 30, 2018 Refactoring
practicalswift on April 30, 2018 Refactoring
issue
Revisit link-time optimization (LTO)? Some results from clang LTO compilation
#14277
practicalswift on September 20, 2018 BrainstormingBuild system
practicalswift on September 20, 2018 BrainstormingBuild system
issue
Add option to build with control-flow integrity (CFI) enabled (--enable-cfi)
#15145
practicalswift on January 10, 2019 Build system
practicalswift on January 10, 2019 Build system
issue
Reduce the number of global symbols used
#15612
practicalswift on March 17, 2019 BrainstormingRefactoring
practicalswift on March 17, 2019 BrainstormingRefactoring
issue
CClientUIInterface::[signal_name]_disconnect is a no-op
#15698
practicalswift on March 29, 2019 RPC/REST/ZMQ
practicalswift on March 29, 2019 RPC/REST/ZMQ
issue
"make depends" builds boost with g++ regardless of environment variable settings
#15914
practicalswift on April 28, 2019 Build system
practicalswift on April 28, 2019 Build system
issue
Feature request: make depends NO_ZEROMQ=1
#15918
practicalswift on April 29, 2019 Build system
practicalswift on April 29, 2019 Build system
issue
RewindBlockIndex reads chainActive (via ChainActive()) without holding cs_main
#15980
practicalswift on May 8, 2019 Validation
practicalswift on May 8, 2019 Validation
issue
getTipLocator() reads chainActive without holding cs_main despite LockAnnotation lock(::cs_main) guarantee
#16028
practicalswift on May 15, 2019
practicalswift on May 15, 2019
issue
--enable-fuzz fails in combination with --enable-wallet, --with-miniupnpc or --enable-zmq
#16094
practicalswift on May 26, 2019 Build systemTestsgood first issue
practicalswift on May 26, 2019 Build systemTestsgood first issue
issue
RFC: Improving testing under the remaining supported 32 bit platforms
#16096
practicalswift on May 26, 2019 BrainstormingTests
practicalswift on May 26, 2019 BrainstormingTests
issue
ThreadSanitizer intermittently reports data race when shutting down node
#16133
practicalswift on June 1, 2019 P2P
practicalswift on June 1, 2019 P2P
issue
GUI: Build unreproducible in the scenarios tested by the Debian Reproducible Builds project
#16137
practicalswift on June 3, 2019 GUIBuild systemUpstream
practicalswift on June 3, 2019 GUIBuild systemUpstream
issue
Line coverage non-determinism in unit test(s) calling SerializeFileDB
#16157
practicalswift on June 6, 2019 Tests
practicalswift on June 6, 2019 Tests
issue
Intermittent (and rare) unit test failure in blockfilter_index_tests/blockfilter_index_initial_sync
#16337
practicalswift on July 4, 2019 Tests
practicalswift on July 4, 2019 Tests
issue
Connection eviction logic (AttemptToEvictConnection) is not covered by our test suite
#16660
practicalswift on August 19, 2019 TestsP2P
practicalswift on August 19, 2019 TestsP2P
issue
Lifetime issue in ReleaseWallet(CWallet* wallet)
#16668
practicalswift on August 20, 2019 Walletgood first issue
practicalswift on August 20, 2019 Walletgood first issue
issue
State of the Repo + Static Analysis Report (🆕), August 2019
#16799
practicalswift on September 3, 2019
practicalswift on September 3, 2019
issue
State of the Repo Report + Static Analysis Report, September 2019
#16967
practicalswift on September 26, 2019
practicalswift on September 26, 2019
issue
CExtKey::Unserialize and CExtPubKey::Unserialize throw std::runtime_error instead of the expected std::ios_base::failure
#17130
practicalswift on October 13, 2019 Buggood first issue
practicalswift on October 13, 2019 Buggood first issue
issue
Potential PSBT issues found by the PSBT fuzzer
#17149
practicalswift on October 15, 2019 BugPSBT
practicalswift on October 15, 2019 BugPSBT
issue
Investigate potential lifetime issues in cases where we are returning "const std::string&"
#17198
practicalswift on October 19, 2019 good first issue
practicalswift on October 19, 2019 good first issue
issue
Serialization-deserialization roundtrip of CPubKey does not necessarily result in an equal object
#17238
practicalswift on October 24, 2019 Questions and Help
practicalswift on October 24, 2019 Questions and Help
issue
Theoretical (astronomically small) possibility of uninitialized read in GetRdRand()?
#17313
practicalswift on October 30, 2019 Utils/log/libs
practicalswift on October 30, 2019 Utils/log/libs
issue
RFC: Enabling some commonly enabled compiler diagnostics
#17344
practicalswift on November 1, 2019 BrainstormingBuild system
practicalswift on November 1, 2019 BrainstormingBuild system
issue
Base58 decoding is done without checking that the input size is reasonable
#17501
practicalswift on November 17, 2019 Resource usage
practicalswift on November 17, 2019 Resource usage
issue
gen_context (secp256k1) is built using gcc despite CC=clang
#17673
practicalswift on December 5, 2019 Upstream
practicalswift on December 5, 2019 Upstream
issue
DecodeBase58(const std::string& str, …) is a bit too liberal when decoding?
#17718
practicalswift on December 10, 2019 Utils/log/libs
practicalswift on December 10, 2019 Utils/log/libs
issue
UniValue upgrade needed to avoid UniValue CVE-2019-18936 (segfault via high object depth JSON)
#17742
practicalswift on December 13, 2019 BugUtils/log/libs
practicalswift on December 13, 2019 BugUtils/log/libs
issue
GetMappedAS(...) lookup on an IPv6 address against a maliciously constructed AS-map triggers heap buffer-overflow
#18033
practicalswift on January 30, 2020 P2P
practicalswift on January 30, 2020 P2P
issue
Some fuzzing crashes when running under ASan and/or UBSan
#18046
practicalswift on January 31, 2020
practicalswift on January 31, 2020
issue
Low level functions ScriptToAsmStr (core_io), i64tostr (strencodings) and itostr (strencodings) are locale dependent
#18281
practicalswift on March 6, 2020 Bug
practicalswift on March 6, 2020 Bug
issue
Signed integer overflow in CCoinsViewCache::GetValueIn(…)
#18858
practicalswift on May 3, 2020 Tests
practicalswift on May 3, 2020 Tests
issue
Add CI job that runs unit tests under rr's chaos mode
#18979
practicalswift on May 15, 2020 Tests
practicalswift on May 15, 2020 Tests
issue
Investigate where std::string should be returned instead of "const char*"
#19000
practicalswift on May 17, 2020 good first issue
practicalswift on May 17, 2020 good first issue
issue
Investigate unnecessary uses of raw pointer parameters
#19062
practicalswift on May 24, 2020 Brainstorming
practicalswift on May 24, 2020 Brainstorming
issue
Use of uninitialized memory when validating successfully deserialized CPubKey
#19235
practicalswift on June 10, 2020 Bug
practicalswift on June 10, 2020 Bug
issue
Three UBSan warnings when loading corrupt mempool.dat files
#19278
practicalswift on June 14, 2020 Refactoring
practicalswift on June 14, 2020 Refactoring
issue
Intermittent CI failure: wallet_basic.py --descriptors
#19369
practicalswift on June 24, 2020 Bug
practicalswift on June 24, 2020 Bug
issue
Some recently introduced Coverity warnings (WRAPPER_ESCAPE, UNINIT and FORWARD_NULL)
#19372
practicalswift on June 24, 2020
practicalswift on June 24, 2020
issue
Intermittent CI failure: wallet_importdescriptors.py
#19376
practicalswift on June 25, 2020 Bug
practicalswift on June 25, 2020 Bug
issue
Intermittent CI failure: ThreadSanitizer failure (data race) when running wallet_multiwallet.py --usecli
#19417
practicalswift on June 30, 2020 BugWallet
practicalswift on June 30, 2020 BugWallet
issue
Intermittent CI failure: "AssertionError: Fee of 0.00011000 BTC too low!" when running wallet_basic.py
#19418
practicalswift on June 30, 2020 Tests
practicalswift on June 30, 2020 Tests
issue
Show the "<n> of the last 100 blocks have unexpected version" warning only when running -debug=validation?
#19603
practicalswift on July 27, 2020 FeatureUtils/log/libs
practicalswift on July 27, 2020 FeatureUtils/log/libs
issue
Enable unused member function diagnostic by default
#19702
practicalswift on August 12, 2020 Build systemgood first issue
practicalswift on August 12, 2020 Build systemgood first issue
issue
Intermittent CI failure: rpc_psbt.py --descriptors
#19744
practicalswift on August 17, 2020 Bug
practicalswift on August 17, 2020 Bug
issue
Bitcoin Core does not immediately use the fixed seed nodes if DNS seeding is disabled (-dnsseed=0)
#19795
practicalswift on August 24, 2020 P2P
practicalswift on August 24, 2020 P2P
issue
Signed integer overflow when SipHasher processes inputs >= 2 GB
#19930
practicalswift on September 10, 2020 Bug
practicalswift on September 10, 2020 Bug
issue
"Site-local" addresses in the fec0::/10 range treated as routable
#19978
practicalswift on September 19, 2020 BugP2P
practicalswift on September 19, 2020 BugP2P
issue
Make non-critical unconditional logging conditional to reduce risk of disk fill attacks and to improve user experience
#20174
practicalswift on October 17, 2020 Utils/log/libs
practicalswift on October 17, 2020 Utils/log/libs
issue
Invalid integer negation in FormatMoney(CAmount n) and ValueFromAmount (CAmount n) when n = std::numeric_limits<CAmount>::min()
#20402
practicalswift on November 16, 2020
practicalswift on November 16, 2020
issue
Drop unnecessary Boost dependencies boost::optional and boost::variant
#20463
practicalswift on November 23, 2020
practicalswift on November 23, 2020
issue
Signed integer overflow in CFeeRate::GetFee(…) reachable via RPC call analyzepsbt
#20607
practicalswift on December 9, 2020
practicalswift on December 9, 2020
issue
Signed integer overflow in CTxMemPool::PrioritiseTransaction(…) reachable via RPC call prioritisetransaction
#20626
practicalswift on December 11, 2020
practicalswift on December 11, 2020
issue
Intermittent CI failure in interface_zmq: "Unexpected exception caught during testing" (zmq.error.Again)"
#20672
practicalswift on December 16, 2020
practicalswift on December 16, 2020
issue
Use HTTPS URLs instead of HTTP URLs where appropriate
#20807
practicalswift on December 30, 2020
practicalswift on December 30, 2020
issue
Null pointer derefence in CBlockIndexWorkComparator::operator() reachable via RPC call invalidateblock
#20914
practicalswift on January 12, 2021
practicalswift on January 12, 2021
issue
Unsigned integer wraparound in CCoinsViewCache::SpendCoin makes CCoinsViewCache::DynamicMemoryUsage() return bogus values
#21001
practicalswift on January 24, 2021
practicalswift on January 24, 2021
issue
Intermittent CI failure: "Transaction not eligible for abandonment (-5)" when running feature_backwards_compatibility.py --descriptors
#21352
practicalswift on March 3, 2021 Bug
practicalswift on March 3, 2021 Bug
issue
Avoid use of "socket" syscall when formatting IP addresses in CNetAddr::ToString
#21466
practicalswift on March 18, 2021 P2P
practicalswift on March 18, 2021 P2P
issue
RFC: Simplifying or removing the user agent string (strSubVersion)
#21492
practicalswift on March 21, 2021
practicalswift on March 21, 2021
issue
Add mitigation for disk fill via logging attacks
#21559
practicalswift on March 31, 2021 FeatureUtils/log/libs
practicalswift on March 31, 2021 FeatureUtils/log/libs
issue
Intermittent CI failure: p2p_compactblocks.py - wait_until() failed
#21963
practicalswift on May 16, 2021 Bug
practicalswift on May 16, 2021 Bug
issue
DNS seed node lookup is ambiguous in some (rare) scenarios
#23193
practicalswift on October 5, 2021 P2P
practicalswift on October 5, 2021 P2P
issue
Add unit tests for Taproot code in src/script/interpreter.cpp
#23279
practicalswift on October 14, 2021 Tests
practicalswift on October 14, 2021 Tests