Prioritisetransaction wasn't always updating ancestor fee #10144

1. 
   sdaftuar commented at 8:04 PM on April 3, 2017: member

   The prioritisetransaction rpc is supposed to update both the descendant and ancestor modified fees, but in the case of transactions with in-mempool descendants, the ancestor fees of those descendants was incorrect.

   First commit updates a test to include a test case, and the second addresses the bug.

2. Test prioritisetransaction and ancestor fee state

   There is already a similar test for descendant fee state.

   ba7dd8bf6f
3. Bugfix: ancestor modifed fees were incorrect for descendants

   If prioritisetransaction was called for a tx with in-mempool
   descendants, the modified ancestor fee values for those descendants was
   incorrect.

   9bef02e365
4. gmaxwell approved
5. 
   gmaxwell commented at 8:17 PM on April 3, 2017: contributor

   utACK.

   Should probably get a 0.14 tag.

6. fanquake added this to the milestone 0.14.1 on Apr 3, 2017
7. fanquake added the label Mempool on Apr 3, 2017
8. laanwj added the label Needs backport on Apr 4, 2017
9. 
   jnewbery commented at 9:09 PM on April 4, 2017: member

   utACK 9bef02e36525d0eed4e2e31678b3ff04bbb0b8cb.

   I haven't fully reviewed all the mempool ancestor/descendant fee accounting, but this looks correct.

10. dcousens approved
11. 
    laanwj commented at 6:36 AM on April 5, 2017: member

    utACK 9bef02e

12. laanwj merged this on Apr 5, 2017
13. laanwj closed this on Apr 5, 2017

    ---

14. laanwj referenced this in commit f93f9b9296 on Apr 5, 2017
15. laanwj removed the label Needs backport on Apr 5, 2017
16. laanwj referenced this in commit d947afc0f7 on Apr 5, 2017
17. laanwj referenced this in commit ea060c7495 on Apr 5, 2017
18. codablock referenced this in commit 96b457d47e on Jan 26, 2018
19. andvgal referenced this in commit b10aa18267 on Jan 6, 2019
20. CryptoCentric referenced this in commit c87714a71f on Feb 27, 2019
21. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.1