Better error handling for submitblock #10146

1. 
   gmaxwell commented at 4:04 am on April 4, 2017: contributor

   Check transaction count early in submitblock.

   There is no point in even hashing a submitted block which doesn’t have a coinbase transaction.

   This also results in more useful error reporting on corrupted input.

   Thanks to rawodb for the bug report.

2. Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn.

   This isn't actually needed anywhere, but it's less brittle.

   ada0caa165
3. Check transaction count early in submitblock.

   There is no point in even hashing a submitted block which doesn't have
    a coinbase transaction.
   
   This also results in more useful error reporting on corrupted input.
   
   Thanks to rawodb for the bug report.

   4f15ea102d
4. Add braces to submitblock per current style. 30f30c0f99
5. fanquake added the label Validation on Apr 4, 2017
6. fanquake added the label RPC/REST/ZMQ on Apr 4, 2017
7. 
   laanwj commented at 6:16 am on April 4, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/10146/commits/30f30c0f99d21d6c8476c759104de5bb3218a188
8. laanwj added this to the milestone 0.14.1 on Apr 4, 2017
9. laanwj added the label Needs backport on Apr 4, 2017
10. 
    jonasschnelli commented at 6:22 am on April 4, 2017: contributor

    utACK 30f30c0f99d21d6c8476c759104de5bb3218a188
11. 
    paveljanik commented at 6:28 am on April 4, 2017: contributor

    utACK 30f30c0
12. 
    laanwj commented at 6:58 am on April 4, 2017: member

    Reminder: this needs a functional test to prevent regression, but not necessary in this PR.
13. laanwj merged this on Apr 4, 2017
14. laanwj closed this on Apr 4, 2017

    ---

15. laanwj referenced this in commit 72bc7e1303 on Apr 4, 2017
16. laanwj referenced this in commit 2fea10ad03 on Apr 4, 2017
17. laanwj referenced this in commit a44a6a15f9 on Apr 4, 2017
18. laanwj removed the label Needs backport on Apr 5, 2017
19. 
    jnewbery commented at 8:55 pm on April 11, 2017: member

    Regression test here: #10190
20. codablock referenced this in commit ec563a0f17 on Jan 26, 2018
21. andvgal referenced this in commit 7e659c18e3 on Jan 6, 2019
22. CryptoCentric referenced this in commit 44e5c21ee7 on Feb 27, 2019
23. MarcoFalke locked this on Sep 8, 2021

Contributors
gmaxwell laanwj jonasschnelli paveljanik jnewbery

Labels
RPC/REST/ZMQ Validation

Milestone
0.14.1