[logging] initialize flag variable to 0 (and continue if GetLogCategory() fails) #10151

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:logging_initialization changing 1 files +4 −2

jnewbery commented at 7:23 PM on April 4, 2017: member

flag was previously uninitialized, and if GetLogCategory() failed we'd drop through and |= whatever was in flag's memory with logCategories.

belt-and-braces: initialize flag to 0, and continue to next iteration of loop if GetLogCategories() fails.

pinging @gmaxwell
initialize flag variable to 0 (and continue if GetLogCategory() fails) cd7f39467a
gmaxwell approved
gmaxwell commented at 7:25 PM on April 4, 2017: contributor

utACK.
fanquake added the label Refactoring on Apr 4, 2017
MarcoFalke commented at 10:31 PM on April 4, 2017: member

utACK cd7f39467afd1f2742a80d608852ebb9eb5179a0
jonasschnelli commented at 6:54 AM on April 5, 2017: contributor

utACK cd7f39467afd1f2742a80d608852ebb9eb5179a0
laanwj commented at 9:30 AM on April 5, 2017: member

Ah, you're removing the debug flag randomization feature? :-)

utACK cd7f394
laanwj merged this on Apr 5, 2017
laanwj closed this on Apr 5, 2017
laanwj referenced this in commit c7e73eafa1 on Apr 5, 2017
PastaPastaPasta referenced this in commit 6eca10d8a3 on May 21, 2019
PastaPastaPasta referenced this in commit 39a7764072 on May 21, 2019
PastaPastaPasta referenced this in commit 8e9efc3475 on May 22, 2019
PastaPastaPasta referenced this in commit 4d12e0e0a7 on May 22, 2019
PastaPastaPasta referenced this in commit aa1f8f160c on May 22, 2019
PastaPastaPasta referenced this in commit 6124150468 on May 22, 2019
markblundeberg referenced this in commit af7370b967 on Jun 21, 2019
jtoomim referenced this in commit 5f998ce5fd on Jun 29, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels