logging: Fix off-by-one for shrinkdebugfile default #10153

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1704-offbyoneDebug changing 1 files +1 −1

MarcoFalke commented at 10:49 PM on April 4, 2017: member
Reference:
```
src/qt/bitcoin-qt -?|grep -C 1 shrinkdebug
```
logging: Fix off-by-one for shrinkdebugfile faab6241d0
fanquake added the label Bug on Apr 4, 2017

in src/init.cpp:1188 in faab6241d0

1184 | @@ -1185,7 +1185,7 @@ bool AppInitMain(boost::thread_group& threadGroup, CScheduler& scheduler)
1185 |  #ifndef WIN32
1186 |      CreatePidFile(GetPidFile(), getpid());
1187 |  #endif
1188 | -    if (GetBoolArg("-shrinkdebugfile", logCategories != BCLog::NONE)) {
1189 | +    if (GetBoolArg("-shrinkdebugfile", logCategories == BCLog::NONE)) {

laanwj commented at 7:07 AM on April 5, 2017:

I never realized that shrinkdebugfile default depends on the debug logging.

laanwj commented at 7:08 AM on April 5, 2017: member

utACK faab624
laanwj merged this on Apr 5, 2017
laanwj closed this on Apr 5, 2017
laanwj referenced this in commit fade78854c on Apr 5, 2017
MarcoFalke deleted the branch on Apr 5, 2017
UdjinM6 referenced this in commit e80fa17e4d on May 16, 2019
UdjinM6 referenced this in commit 35c729615e on May 16, 2019
UdjinM6 referenced this in commit 966f9dbe82 on May 16, 2019
PastaPastaPasta referenced this in commit c1f2caf5fa on May 18, 2019
PastaPastaPasta referenced this in commit 7aef85d9b5 on May 20, 2019
PastaPastaPasta referenced this in commit eb44a9b8d5 on May 21, 2019
PastaPastaPasta referenced this in commit 4e5791c10e on May 21, 2019
PastaPastaPasta referenced this in commit a2883ae288 on May 22, 2019
PastaPastaPasta referenced this in commit d577804ca0 on May 22, 2019
UdjinM6 referenced this in commit 29194b1f5a on May 22, 2019
barrystyle referenced this in commit b773a6230f on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

MarcoFalke

laanwj

Labels

Bug