QRCodeDialog::getURI formatting of btc #1506

I think the lnReqAmount should be formatted as the the other fields that accept bitcoin amounts, so with an up-and-down field that autocorrects "." and "," (or even better with a BitcoinAmountField so that you can choose the unit). As is you can insert spaces in the lnReqAmount and the spaces will be used to calc the QR Code (because the lnReqAmount.text() is used directly)

Seems like a pretty good idea, will look into this :).

Working on this, I currently only have a small problem with updating the unit, as we don't have WalletModell or OptionsModell available in the qrcodedialog code.

@xanatos Can you try our my patch #1518 and give some feedback.

@Diapolo I don't have a C++ environment :-) In the last 5 years I have programmed only C#. And even when I was a C++ programmer, I was a Visual C++ programmer, not a QT/gcc/g++ programmer.

@xanatos Too bad :). But I guess at least you could take a quick look at the code.

@Diapolo My only problem is with the BitcoinAmount::validate()... It does two different things... It checks for non-zero value and checks for "textual" correctness and number-of-digits validation (the last two checks in the parse() call). I do think the non-zero value test isn't correct to be put there (and, for example, the MainOptionsPage doesn't use the validate() method probably for this reason, because 0.00 commissions are ok). Considering the BitcoinAmount::validate() does a "textual" validation and a number-of-digits validation, I would stop the QR code from being generated if it isn't valid.

I'll note that there is even a minor bug in the save-as button. If you put too many letters in a field the QR code on the screen will disappear, but the save button will save the last correctly generated QR code.

@xanatos Thanks for your feedback, I updated my patch to reflect your suggestions. The save button is now only enabled, when the QR Code was successfully generated. Perhaps you can take another look.

@xanatos As #1518 got merged, you can close this now. That's the new look of the QR Code dialog: