[trivial] Log calls to getblocktemplate #10162

We don't log when loggetblocktemplate() is called.

This is what any other method looks like when it's called:

2017-04-06 14:34:48 Received a POST request for / from 127.0.0.1:37080
2017-04-06 14:34:48 ThreadRPCServer method=help

and getblocktemplate:

2017-04-06 14:35:02 Received a POST request for / from 127.0.0.1:37088

This is a holdover from when getwork was introduced here: https://github.com/bitcoin/bitcoin/commit/776d0f34595fd616129d4816a337662ff39de7c6#diff-86eca98b63dcc6ac488efdc7de47be31L1421

There's no reason not to log getblocktemplate(). It's annoying not to see the log during testing/debugging.

utACK, though I also have no idea why these were being omitted in the first place.

Mostly because of the frequency for mining nodes.

Mostly because of the frequency for mining nodes.

Thanks for clarifying. In that case, I think this change is safe (and useful). They'll already be logging the Received a Post request for / event. Adding a event that logs which rpc was called won't cause too much additional logging.

utACK 1352092dbd5c59cb6460ed0cc5890271acf6efef

Mostly because of the frequency for mining nodes.

Hmm any specific resaon mining nodes have debug=rpc on? Or is this from before debug was categorized?

Yes, this is from before debug was categorised: https://github.com/bitcoin/bitcoin/commit/776d0f34595fd616129d4816a337662ff39de7c6#diff-86eca98b63dcc6ac488efdc7de47be31L1421

utACK 1352092

ACK 1352092