[trivial] Rename unused submitblock argument as 'dummy' #10191

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:remove_submit_block_params changing 1 files +4 −7

jnewbery commented at 9:29 PM on April 11, 2017: member

Dead code, not used since the submitblock RPC was introduced in #1691 5 years ago.

EDIT: This PR now renames the unused arguments in submitblock and prioritisetransaction
jnewbery closed this on Apr 11, 2017
jnewbery reopened this on Apr 12, 2017
jnewbery force-pushed on Apr 12, 2017
sipa commented at 1:45 PM on April 12, 2017: member

I assume thar argument exists for compliance with BIP 22?
fanquake added the label Mining on Apr 14, 2017
fanquake added the label RPC/REST/ZMQ on Apr 14, 2017
luke-jr commented at 6:17 PM on April 19, 2017: member

Indeed. We could perhaps trim down on the docs (since Core doesn't use it), but including the object shouldn't be made to error.
jnewbery force-pushed on Apr 19, 2017
jnewbery commented at 7:46 PM on April 19, 2017: member
ok, pushed new version:
- help text is removed
- sending a 'parameters' object does not cause an error, but is ignored.
jnewbery force-pushed on Apr 19, 2017

in src/rpc/mining.cpp:729 in 5793b9294d outdated

 723 |      if (request.fHelp || request.params.size() < 1 || request.params.size() > 2) {
 724 |          throw std::runtime_error(
 725 | -            "submitblock \"hexdata\" ( \"jsonparametersobject\" )\n"
 726 | +            "submitblock \"hexdata\"\n"
 727 |              "\nAttempts to submit new block to network.\n"
 728 | -            "The 'jsonparametersobject' parameter is currently ignored.\n"

laanwj commented at 10:41 AM on April 20, 2017:

I think this line should be kept, as well as the (\"jsonparametersobject\") above.

Removing the details of the parameters below is fine with me if they're all ignored, but just state that exlicitly.

2. \"parameters\"     (string, optional) object of optional parameters (currently ignored, but accepted for BIP22 compatbility)

TheBlueMatt commented at 7:29 PM on May 31, 2017:

Lets just call them "dummy" instead of bothering to name and define something that is ignored.

jnewbery commented at 8:53 PM on May 31, 2017:

updated to change the name of the argument to dummy

jnewbery force-pushed on May 31, 2017
jnewbery force-pushed on Jun 6, 2017
jnewbery renamed this:
~~[trivial] Remove unused submit block parameters argument~~
[trivial] Rename unused RPC arguments 'dummy'
on Jun 6, 2017
jnewbery commented at 2:47 PM on June 6, 2017: member

I've cherry-picked @TheBlueMatt's commit from #10488 into this PR since they're doing similar things. This PR now renames the unused arguments in prioritisetransaction and submitblock to dummy.
laanwj commented at 11:07 AM on June 14, 2017: member

This went in through #10488, IIRC? Anything left to do here?
jnewbery force-pushed on Jun 14, 2017
[RPCs] Remove submitblock parameters argument help text 0ef7de953f
jnewbery force-pushed on Jun 14, 2017
jnewbery commented at 5:53 PM on June 14, 2017: member

#10488 renamed the unused parameter in prioritisetransaction to dummy. This does the same for submitblock.

(I cherry-picked the commit from #10488 into here because they were doing the same thing for two different RPCs so I thought it made sense to combine them into a single PR. Now that #10488 is merged I've rebased this onto master so this PR only affects submitblock).
TheBlueMatt commented at 6:45 PM on June 19, 2017: member

utACK 0ef7de953f5eeb27651690871c18c4dc1ee4f83b
laanwj merged this on Jun 24, 2017
laanwj closed this on Jun 24, 2017
laanwj referenced this in commit 00350bd6db on Jun 24, 2017
jnewbery renamed this:
~~[trivial] Rename unused RPC arguments 'dummy'~~
[trivial] Rename unused submitblock argument as 'dummy'
on Jul 31, 2017
PastaPastaPasta referenced this in commit d005f9e3ae on Jul 6, 2019
PastaPastaPasta referenced this in commit 7290c1e595 on Jul 8, 2019
PastaPastaPasta referenced this in commit 1957c113c1 on Jul 9, 2019
PastaPastaPasta referenced this in commit 677c78516f on Jul 11, 2019
schancel referenced this in commit 411992b418 on Jul 18, 2019
jonspock referenced this in commit 158cc78d73 on Aug 29, 2019
proteanx referenced this in commit c0421f381c on Sep 4, 2019
barrystyle referenced this in commit 4a800f13f2 on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#1691 Add 'submitblock' RPC, split out from 'getblocktemplate' RPC