[0.14] net: define NodeId as an int64_t #10205

1. 
   theuni commented at 9:19 PM on April 13, 2017: member

   This should make occurances of NodeId wrapping essentially impossible for real-world usage.

   Backport of #10176

2. net: define NodeId as an int64_t

   This should make occurances of NodeId wrapping essentially impossible for
   real-world usage.

   ce0c99365a
3. MarcoFalke renamed this:
   net: define NodeId as an int64_t
   [0.14] net: define NodeId as an int64_t
   on Apr 13, 2017
4. 
   MarcoFalke commented at 10:29 PM on April 13, 2017: member

   I think you need to include the

   Github-Pull: [#10176](/bitcoin-bitcoin/10176/)
   Rebased-From: c851be4b25905977ca471c42435dc590fd2ff2f5
   

   for the release notes script to pick this up properly.

5. MarcoFalke added the label Backport on Apr 13, 2017
6. MarcoFalke added the label P2P on Apr 13, 2017
7. MarcoFalke added this to the milestone 0.14.1 on Apr 13, 2017
8. gmaxwell approved
9. 
   gmaxwell commented at 12:40 AM on April 14, 2017: contributor

   utACK

10. 
    laanwj commented at 8:03 AM on April 14, 2017: member

    for the release notes script to pick this up properly.

    Yes please, include the metadata.

    utACK otherwise

11. 
    laanwj commented at 8:36 AM on April 14, 2017: member

    Merged via 30fa231 (added metadata)

12. laanwj closed this on Apr 14, 2017

    ---

13. 
    theuni commented at 2:08 PM on April 14, 2017: member

    Sorry, will do next time.

14. MarcoFalke locked this on Sep 8, 2021

Contributors

theuniMarcoFalkegmaxwelllaanwj

Milestone
0.14.1