Follow-on to the now-merged #10178. Untested.
Stop treating coinbase outputs differently in GUI: show them at 1conf #10221
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-04-no-coinbase-display-lag changing 3 files +2 −39-
TheBlueMatt commented at 2:17 PM on April 17, 2017: member
-
[qt] Stop treating coinbase outputs differently: show them at 1conf 608bbccfb9
-
laanwj commented at 2:38 PM on April 17, 2017: member
- fanquake added the label GUI on Apr 17, 2017
- fanquake added the label Wallet on Apr 17, 2017
-
TheBlueMatt commented at 4:41 PM on April 18, 2017: member
@sdaftuar went and tested and realized at least I and a few others had a misunderstanding in #10178 - the intended goal of all this logic is to hide orphaned coinbases, but it, as far as I can tell, was always broken in >1 block reorgs (even prior to #10178), and I'm still dubious about having this logic in order to have that behavior - how is a coinbase transaction paying you getting orphaned any different from any other transaction paying you getting conflicted - it seems crazy to hide such transactions entirely because they got orphaned.
-
sipa commented at 5:28 PM on April 18, 2017: member
I assume the original reason (whether it worked or not) was because a reorg will always kill a coinbase payout, while normal transactions (in non-adverserial situations) will just migrate to the new chain.
-
TheBlueMatt commented at 5:53 PM on April 18, 2017: member
@sipa yes, I assume it predated conflicted tagging transactions. Now that we have conflict tracking, I'd still say we should remove it.
-
sipa commented at 6:06 PM on April 18, 2017: member
Concept ACK @TheBlueMatt Sure, I was just speculating why this logic existed specifically for coinbases and not other transactions.
-
jonasschnelli commented at 9:13 AM on April 19, 2017: contributor
Tested ACK 608bbccfb97e5ecb9083ac203642524a6e556e48 https://bitcoin.jonasschnelli.ch/build/101
- jonasschnelli merged this on Apr 19, 2017
- jonasschnelli closed this on Apr 19, 2017
- jonasschnelli referenced this in commit e96486cbeb on Apr 19, 2017
- PastaPastaPasta referenced this in commit e2960eeb41 on May 21, 2019
- PastaPastaPasta referenced this in commit f5e5210152 on May 21, 2019
- PastaPastaPasta referenced this in commit 4a3b36d73c on May 22, 2019
- PastaPastaPasta referenced this in commit 25a6654e0b on May 22, 2019
- PastaPastaPasta referenced this in commit cb9d0b539f on May 22, 2019
- PastaPastaPasta referenced this in commit 03365f0654 on May 22, 2019
- PastaPastaPasta referenced this in commit 4efa99c2df on May 23, 2019
- UdjinM6 referenced this in commit e7ce9bb0c8 on May 28, 2019
- barrystyle referenced this in commit 04481f7bd3 on Jan 22, 2020
- random-zebra referenced this in commit 2e510ef586 on Feb 18, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors