This doesn't crash currently because the method doesn't access any object members, but this behavior is fragile and incompatible with #10102.
[qt] Don't call method on null WalletModel object #10242
pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/rbfnull changing 1 files +3 −1-
ryanofsky commented at 7:18 PM on April 20, 2017: member
-
fb463d1717
[qt] Don't call method on null WalletModel object
This doesn't crash currently because the method doesn't access any object members, but this behavior is fragile and incompatible with #10102.
-
jonasschnelli commented at 7:20 PM on April 20, 2017: contributor
Uh. Yes. That makes much more sense. Thanks for fixing.
utACK 7ba55396a0b9e013bd08db0678eb917af5b1f0b2
-
luke-jr commented at 7:21 PM on April 20, 2017: member
Ouch, utACK.
- jonasschnelli added the label GUI on Apr 20, 2017
-
ryanofsky commented at 8:57 PM on April 20, 2017: member
If anyone wants to add a tested ack, easiest way to test this is to start bitcoin-qt with
-walletrbfflag, and make sure "Request Replace-By-Fee" checkbox is checked, then start without the-walletrbfflag and make sure the checkbox is unchecked.You can find the "Request Replace-By-Fee" checkbox under "Send", "Transaction Fee", "Choose..."
- ryanofsky force-pushed on Apr 20, 2017
-
mariodian commented at 6:21 AM on April 21, 2017: contributor
tACK (OS X 10.12.4)
- laanwj merged this on Apr 21, 2017
- laanwj closed this on Apr 21, 2017
- laanwj referenced this in commit f6f3b58a72 on Apr 21, 2017
- luke-jr referenced this in commit 651d189f51 on Jun 15, 2017
- PastaPastaPasta referenced this in commit 395f70ed5b on May 10, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels