Pull-Requests
pull
Fix "make check" on systems with qt and libxcb but no active DISPLAY
#10117
ryanofsky on March 29, 2017 Tests
ryanofsky on March 29, 2017 Tests
pull
[qt] Move some WalletModel functions into CWallet
#10295
ryanofsky on April 28, 2017 RefactoringWallet
ryanofsky on April 28, 2017 RefactoringWallet
pull
Fix importmulti failure to return rescan errors
#10403
ryanofsky on May 15, 2017 WalletRPC/REST/ZMQ
ryanofsky on May 15, 2017 WalletRPC/REST/ZMQ
pull
Add fee_est tool for debugging fee estimation code
#10443
ryanofsky on May 22, 2017 FeatureTX fees and policyNeeds rebaseCI failed
ryanofsky on May 22, 2017 FeatureTX fees and policyNeeds rebaseCI failed
pull
Simplify feebumper minimum fee code slightly
#10455
ryanofsky on May 25, 2017 RefactoringWallet
ryanofsky on May 25, 2017 RefactoringWallet
pull
Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
#10500
ryanofsky on June 1, 2017 Wallet
ryanofsky on June 1, 2017 Wallet
pull
Remove unused ResendWalletTransactions notification
#10584
ryanofsky on June 13, 2017 RefactoringWallet
ryanofsky on June 13, 2017 RefactoringWallet
pull
Simple, backwards compatible RPC multiwallet support (superseded by #10829)
#10653
ryanofsky on June 22, 2017 WalletRPC/REST/ZMQ
ryanofsky on June 22, 2017 WalletRPC/REST/ZMQ
pull
Add optional wallet=filename arguments to wallet RPCs
#10661
ryanofsky on June 23, 2017 RPC/REST/ZMQ
ryanofsky on June 23, 2017 RPC/REST/ZMQ
pull
Simple, backwards compatible RPC multiwallet support.
#10829
ryanofsky on July 14, 2017 WalletRPC/REST/ZMQ
ryanofsky on July 14, 2017 WalletRPC/REST/ZMQ
pull
Fix misleading "Method not found" multiwallet errors
#10931
ryanofsky on July 26, 2017 WalletRPC/REST/ZMQ
ryanofsky on July 26, 2017 WalletRPC/REST/ZMQ
pull
[MOVEONLY] Move some static functions out of wallet.h/cpp
#10976
ryanofsky on August 2, 2017 RefactoringWallet
ryanofsky on August 2, 2017 RefactoringWallet
pull
Avoid treating null RPC arguments different from missing arguments
#11050
ryanofsky on August 14, 2017 RPC/REST/ZMQ
ryanofsky on August 14, 2017 RPC/REST/ZMQ
pull
Acquire cs_main lock before cs_wallet during wallet initialization
#11126
ryanofsky on August 24, 2017 Wallet
ryanofsky on August 24, 2017 Wallet
pull
Avoid opening copied wallet databases simultaneously
#11476
ryanofsky on October 10, 2017 Wallet
ryanofsky on October 10, 2017 Wallet
pull
Make listsinceblock refuse unknown block hash
#11565
ryanofsky on October 26, 2017 RPC/REST/ZMQ
ryanofsky on October 26, 2017 RPC/REST/ZMQ
pull
Move RPC registration out of AppInitParameterInteraction
#11603
ryanofsky on November 3, 2017 Refactoring
ryanofsky on November 3, 2017 Refactoring
pull
Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection
#11640
ryanofsky on November 8, 2017 Refactoring
ryanofsky on November 8, 2017 Refactoring
pull
scripted-diff: Rename wallet database classes
#11851
ryanofsky on December 8, 2017 RefactoringWallet
ryanofsky on December 8, 2017 RefactoringWallet
pull
Split up key and script metadata for better type safety
#11854
ryanofsky on December 8, 2017 Wallet
ryanofsky on December 8, 2017 Wallet
pull
Drop extra script variable in ProduceSignature
#11889
ryanofsky on December 13, 2017 RefactoringValidation
ryanofsky on December 13, 2017 RefactoringValidation
pull
Free BerkeleyEnvironment instances when not in use
#11911
ryanofsky on December 15, 2017 Wallet
ryanofsky on December 15, 2017 Wallet
pull
Add test coverage for bitcoin-cli multiwallet calls
#11970
ryanofsky on December 21, 2017 WalletTests
ryanofsky on December 21, 2017 WalletTests
pull
Fix ListCoins test failure due to unset g_address_type, g_change_type
#12150
ryanofsky on January 11, 2018 Tests
ryanofsky on January 11, 2018 Tests
pull
Avoid potential null dereference in ReceiveCoinsDialog constructor
#12211
ryanofsky on January 17, 2018 GUI
ryanofsky on January 17, 2018 GUI
pull
RFC: Rename -walletdir option to -walletsdir (scripted-diff)
#12221
ryanofsky on January 18, 2018
ryanofsky on January 18, 2018
pull
test_runner: Readable output if create_cache.py fails
#12227
ryanofsky on January 19, 2018 Tests
ryanofsky on January 19, 2018 Tests
pull
Fix rescan test failure due to unset g_address_type, g_change_type
#12424
ryanofsky on February 13, 2018 Tests
ryanofsky on February 13, 2018 Tests
pull
Fix ListCoins test failure due to unset g_wallet_allow_fallback_fee
#12582
ryanofsky on March 2, 2018 Tests
ryanofsky on March 2, 2018 Tests
pull
Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER
#12681
ryanofsky on March 13, 2018 Tests
ryanofsky on March 13, 2018 Tests
pull
Avoid `interface` keyword to fix windows gitian build
#12906
ryanofsky on April 7, 2018 Windows
ryanofsky on April 7, 2018 Windows
pull
Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106
#13154
ryanofsky on May 2, 2018 Docs
ryanofsky on May 2, 2018 Docs
pull
Disable wallet and address book Qt tests on macOS minimal platform
#14011
ryanofsky on August 20, 2018 macOSTests
ryanofsky on August 20, 2018 macOSTests
pull
[wallet] Restore ability to list incoming transactions by label
#14411
ryanofsky on October 6, 2018 Wallet
ryanofsky on October 6, 2018 Wallet
pull
Refactor: Start to separate wallet from node
#14437
ryanofsky on October 9, 2018 RefactoringWallet
ryanofsky on October 9, 2018 RefactoringWallet
pull
Avoid using numeric_limits for sequence numbers and lock times
#14636
ryanofsky on November 1, 2018 Refactoring
ryanofsky on November 1, 2018 Refactoring
pull
Remove uses of chainActive and mapBlockIndex in wallet code
#14711
ryanofsky on November 12, 2018 RefactoringWallet
ryanofsky on November 12, 2018 RefactoringWallet
pull
test: Fix descriptor_tests not checking ToString output of public descriptors
#14820
ryanofsky on November 27, 2018 Tests
ryanofsky on November 27, 2018 Tests
pull
Remove wallet -> node global function calls
#15288
ryanofsky on January 30, 2019 RefactoringWallet
ryanofsky on January 30, 2019 RefactoringWallet
pull
Move ParseConfirmTarget from rpc/mining to rpc/util
#15373
ryanofsky on February 8, 2019 RefactoringUtils/log/libs
ryanofsky on February 8, 2019 RefactoringUtils/log/libs
pull
bitcoin-cli: Eliminate "Error parsing JSON" errors
#15448
ryanofsky on February 20, 2019 RPC/REST/ZMQ
ryanofsky on February 20, 2019 RPC/REST/ZMQ
pull
Move-only: Pull wallet code out of libbitcoin_server
#15638
ryanofsky on March 22, 2019 Refactoring
ryanofsky on March 22, 2019 Refactoring
pull
bitcoin-wallet tool: Drop libbitcoin_server.a dependency
#15639
ryanofsky on March 22, 2019 Wallet
ryanofsky on March 22, 2019 Wallet
pull
Merge settings one place instead of five places
#15934
ryanofsky on May 1, 2019 RefactoringUtils/log/libs
ryanofsky on May 1, 2019 RefactoringUtils/log/libs
pull
Add <datadir>/settings.json persistent settings storage
#15935
ryanofsky on May 1, 2019 Utils/log/libs
ryanofsky on May 1, 2019 Utils/log/libs
pull
interfaces: Expose settings.json methods to GUI
#15936
ryanofsky on May 1, 2019 GUIUtils/log/libs
ryanofsky on May 1, 2019 GUIUtils/log/libs
pull
Add loadwallet and createwallet load_on_startup options
#15937
ryanofsky on May 1, 2019 WalletRPC/REST/ZMQUtils/log/libsSettings
ryanofsky on May 1, 2019 WalletRPC/REST/ZMQUtils/log/libsSettings
pull
refactor: Implement missing error checking for ArgsManager flags
#16545
ryanofsky on August 4, 2019 Utils/log/libs
ryanofsky on August 4, 2019 Utils/log/libs
pull
Replace Connman and BanMan globals with NodeContext local
#16839
ryanofsky on September 9, 2019 Refactoring
ryanofsky on September 9, 2019 Refactoring
pull
refactor: Settings code cleanups
#17473
ryanofsky on November 14, 2019 RefactoringUtils/log/libs
ryanofsky on November 14, 2019 RefactoringUtils/log/libs
pull
util: Disallow network-qualified command line options
#17482
ryanofsky on November 14, 2019 TestsUtils/log/libs
ryanofsky on November 14, 2019 TestsUtils/log/libs
pull
util: Forbid ambiguous multiple assignments in config file
#17493
ryanofsky on November 15, 2019 RefactoringUtils/log/libs
ryanofsky on November 15, 2019 RefactoringUtils/log/libs
pull
test: Change feature_config_args.py not to rely on strange regtest=0 behavior
#17556
ryanofsky on November 21, 2019 Tests
ryanofsky on November 21, 2019 Tests
pull
refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags
#17580
ryanofsky on November 24, 2019 Refactoring
ryanofsky on November 24, 2019 Refactoring
pull
refactor: Remove settings merge reverse precedence code
#17581
ryanofsky on November 24, 2019 Refactoring
ryanofsky on November 24, 2019 Refactoring
pull
common: Disallow calling IsArgSet() on ALLOW_LIST options
#17783
ryanofsky on December 20, 2019 Utils/log/libs
ryanofsky on December 20, 2019 Utils/log/libs
pull
gui: Set CConnman byte counters earlier to avoid uninitialized reads
#17906
ryanofsky on January 10, 2020 P2P
ryanofsky on January 10, 2020 P2P
pull
wallet: Remove calls to Chain::Lock methods
#17954
ryanofsky on January 17, 2020 WalletReview club
ryanofsky on January 17, 2020 WalletReview club
pull
refactor: Add ChainClient setMockTime, getWallets methods
#17999
ryanofsky on January 24, 2020 Refactoring
ryanofsky on January 24, 2020 Refactoring
pull
wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition
#18067
ryanofsky on February 4, 2020 Wallet
ryanofsky on February 4, 2020 Wallet
pull
interfaces: Describe and follow some code conventions
#18278
ryanofsky on March 6, 2020 Refactoring
ryanofsky on March 6, 2020 Refactoring
pull
build: Drop bitcoin-tx and bitcoin-wallet dependencies on libevent
#18504
ryanofsky on April 2, 2020 Build system
ryanofsky on April 2, 2020 Build system
pull
refactor: drop boost::signals2 in validationinterface
#18524
ryanofsky on April 4, 2020 BugRefactoringValidation
ryanofsky on April 4, 2020 BugRefactoringValidation
pull
gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged
#18587
ryanofsky on April 10, 2020 GUIWallet
ryanofsky on April 10, 2020 GUIWallet
pull
refactor: Remove CAddressBookData::destdata
#18608
ryanofsky on April 12, 2020 RefactoringWallet
ryanofsky on April 12, 2020 RefactoringWallet
pull
test: Verify findCommonAncestor always initializes outputs
#18660
ryanofsky on April 15, 2020 Tests
ryanofsky on April 15, 2020 Tests
pull
depends: Add --sysroot option to mac os native compile flags
#18743
ryanofsky on April 22, 2020 Build system
ryanofsky on April 22, 2020 Build system
pull
Prevent valgrind false positive in rest_blockhash_by_height
#18785
ryanofsky on April 27, 2020 RPC/REST/ZMQ
ryanofsky on April 27, 2020 RPC/REST/ZMQ
pull
wallet: Minimal fix to restore conflicted transaction notifications
#18982
ryanofsky on May 15, 2020 Wallet
ryanofsky on May 15, 2020 Wallet
pull
refactor: Move wallet methods out of chain.h and node.h
#19099
ryanofsky on May 28, 2020 Refactoring
ryanofsky on May 28, 2020 Refactoring
pull
refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions
#19100
ryanofsky on May 28, 2020 RefactoringWalletRPC/REST/ZMQ
ryanofsky on May 28, 2020 RefactoringWalletRPC/REST/ZMQ
pull
refactor: remove ::vpwallets and related global variables
#19101
ryanofsky on May 28, 2020 RefactoringWallet
ryanofsky on May 28, 2020 RefactoringWallet
pull
refactor: Get rid of more redundant chain methods
#19425
ryanofsky on July 1, 2020 Refactoringinterfaces
ryanofsky on July 1, 2020 Refactoringinterfaces
pull
multiprocess: Add bitcoin-wallet -ipcconnect option
#19460
ryanofsky on July 7, 2020 WalletBuild systemUtils/log/libs
ryanofsky on July 7, 2020 WalletBuild systemUtils/log/libs
pull
multiprocess: Add bitcoin-gui -ipcconnect option
#19461
ryanofsky on July 7, 2020 GUIUtils/log/libs
ryanofsky on July 7, 2020 GUIUtils/log/libs
pull
Fix macos "integers of different signs" error from #18850
#19492
ryanofsky on July 11, 2020 Tests
ryanofsky on July 11, 2020 Tests
pull
Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp
#19619
ryanofsky on July 29, 2020 Wallet
ryanofsky on July 29, 2020 Wallet
pull
rpc: Allow named and positional arguments to be used together
#19762
ryanofsky on August 18, 2020 RPC/REST/ZMQ
ryanofsky on August 18, 2020 RPC/REST/ZMQ
pull
bitcoin-wallet salvage: Return false instead of asserting when a loaded tx isn't new
#19793
ryanofsky on August 24, 2020 Wallet
ryanofsky on August 24, 2020 Wallet
pull
scripted-diff: Restore AssertLockHeld after #19668, remove LockAssertion
#19865
ryanofsky on September 3, 2020 RefactoringNeeds rebase
ryanofsky on September 3, 2020 RefactoringNeeds rebase
pull
sync: Replace LockAssertion with AssertLockHeldUnverified
#19918
ryanofsky on September 8, 2020 Utils/log/libsNeeds rebase
ryanofsky on September 8, 2020 Utils/log/libsNeeds rebase
pull
depends: Set CMAKE_INSTALL_RPATH for native packages
#20046
ryanofsky on September 30, 2020 Build system
ryanofsky on September 30, 2020 Build system
pull
wallet: List all wallets in non-SQLite and non-BDB builds
#20275
ryanofsky on October 30, 2020 Wallet
ryanofsky on October 30, 2020 Wallet
pull
refactor: Move node and wallet code out of src/interfaces
#20494
ryanofsky on November 25, 2020 Refactoring
ryanofsky on November 25, 2020 Refactoring
pull
Remove pointer cast in CRPCTable::dumpArgMap
#21035
ryanofsky on January 29, 2021 RefactoringRPC/REST/ZMQ
ryanofsky on January 29, 2021 RefactoringRPC/REST/ZMQ
pull
refactor: Make CWalletTx sync state type-safe
#21206
ryanofsky on February 17, 2021 RefactoringWallet
ryanofsky on February 17, 2021 RefactoringWallet
pull
MOVEONLY: CWallet transaction code out of wallet.cpp/.h
#21207
ryanofsky on February 17, 2021 Wallet
ryanofsky on February 17, 2021 Wallet
pull
interfaces: Stop exposing wallet destdata to gui
#21353
ryanofsky on March 3, 2021 RefactoringWalletinterfaces
ryanofsky on March 3, 2021 RefactoringWalletinterfaces
pull
Drop JSONRPCRequest constructors after #21366
#21574
ryanofsky on April 2, 2021 WalletRPC/REST/ZMQ
ryanofsky on April 2, 2021 WalletRPC/REST/ZMQ
pull
MOVEONLY: Move common init code to init/common
#21732
ryanofsky on April 19, 2021 RefactoringBuild system
ryanofsky on April 19, 2021 RefactoringBuild system
pull
refactor: Clean up new wallet spend, receive files added #21207
#22100
ryanofsky on May 30, 2021 RefactoringWallet
ryanofsky on May 30, 2021 RefactoringWallet
pull
wallet test: Add test for subtract fee from recipient behavior
#22155
ryanofsky on June 4, 2021 WalletTests
ryanofsky on June 4, 2021 WalletTests
pull
refactor: Rearrange fillPSBT arguments
#22214
ryanofsky on June 10, 2021 GUIRefactoringWalletinterfaces
ryanofsky on June 10, 2021 GUIRefactoringWalletinterfaces
pull
refactor: Make SetupServerArgs callable without NodeContext
#22216
ryanofsky on June 10, 2021 Refactoring
ryanofsky on June 10, 2021 Refactoring
pull
refactor: Avoid wallet code writing node settings file
#22217
ryanofsky on June 10, 2021 RefactoringWalletUtils/log/libsinterfaces
ryanofsky on June 10, 2021 RefactoringWalletUtils/log/libsinterfaces
pull
multiprocess: Add ipc::Context and ipc::capnp::Context structs
#22218
ryanofsky on June 10, 2021 Build systeminterfaces
ryanofsky on June 10, 2021 Build systeminterfaces
pull
multiprocess: Start using init makeNode, makeChain, etc methods
#22219
ryanofsky on June 10, 2021 Utils/log/libsinterfaces
ryanofsky on June 10, 2021 Utils/log/libsinterfaces
pull
refactor: Clarify and disable unused ArgsManager flags
#22766
ryanofsky on August 21, 2021 RefactoringUtils/log/libs
ryanofsky on August 21, 2021 RefactoringUtils/log/libs
pull
refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method
#22937
ryanofsky on September 10, 2021 Refactoring
ryanofsky on September 10, 2021 Refactoring
pull
scripted-diff: Rename overloaded int GetArg to GetIntArg
#22976
ryanofsky on September 15, 2021 Refactoring
ryanofsky on September 15, 2021 Refactoring
pull
multiprocess: Make interfaces::Chain::isTaprootActive non-const
#23003
ryanofsky on September 17, 2021 interfaces
ryanofsky on September 17, 2021 interfaces
pull
multiprocess: add interfaces::ExternalSigner class
#23004
ryanofsky on September 17, 2021 Walletinterfaces
ryanofsky on September 17, 2021 Walletinterfaces
pull
multiprocess: Delay wallet client construction
#23005
ryanofsky on September 17, 2021 interfaces
ryanofsky on September 17, 2021 interfaces
pull
multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations
#23006
ryanofsky on September 17, 2021 GUIBuild systemUtils/log/libs
ryanofsky on September 17, 2021 GUIBuild systemUtils/log/libs
pull
Add `src/node/` and `src/wallet/` code to `node::` and `wallet::` namespaces
#23497
ryanofsky on November 12, 2021 Refactoring
ryanofsky on November 12, 2021 Refactoring
pull
multiprocess: Add interfaces::Node::broadCastTransaction method
#23499
ryanofsky on November 12, 2021 Refactoringinterfaces
ryanofsky on November 12, 2021 Refactoringinterfaces
pull
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
#23828
ryanofsky on December 20, 2021 RefactoringBuild system
ryanofsky on December 20, 2021 RefactoringBuild system
pull
scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader
#23842
ryanofsky on December 22, 2021 Refactoring
ryanofsky on December 22, 2021 Refactoring
pull
Remove cs_main lock annotation from ChainstateManager.m_blockman
#24024
ryanofsky on January 10, 2022 Validation
ryanofsky on January 10, 2022 Validation
pull
util: Restore GetIntArg saturating behavior
#24041
ryanofsky on January 11, 2022 Utils/log/libs
ryanofsky on January 11, 2022 Utils/log/libs
pull
indexes: Stop using node internal types and locking cs_main, improve sync logic
#24230
ryanofsky on February 1, 2022 UTXO Db and IndexesNeeds rebase
ryanofsky on February 1, 2022 UTXO Db and IndexesNeeds rebase
pull
bench: Represent paths with fs::path instead of std::string
#24252
ryanofsky on February 3, 2022 Tests
ryanofsky on February 3, 2022 Tests
pull
util: Make ArgsManager::GetPathArg more widely usable
#24306
ryanofsky on February 9, 2022 Utils/log/libs
ryanofsky on February 9, 2022 Utils/log/libs
pull
Do not use `LocalTestingSetup` in getarg_tests test file.
#24375
ryanofsky on February 18, 2022 Tests
ryanofsky on February 18, 2022 Tests
pull
Disallow more unsafe string->path conversions allowed by path append operators
#24470
ryanofsky on March 3, 2022 Refactoring
ryanofsky on March 3, 2022 Refactoring
pull
qt: Avoid crash on startup if int specified in settings.json
#24498
ryanofsky on March 7, 2022 GUIBuild systemUtils/log/libs
ryanofsky on March 7, 2022 GUIBuild systemUtils/log/libs
pull
init: Prevent -noproxy and -proxy=0 from interacting with other settings
#24837
ryanofsky on April 12, 2022
ryanofsky on April 12, 2022
pull
[22.x] qt: Avoid crash on startup if int specified in settings.json
#25180
ryanofsky on May 20, 2022 Backport
ryanofsky on May 20, 2022 Backport
pull
multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory
#25214
ryanofsky on May 25, 2022 Build system
ryanofsky on May 25, 2022 Build system
pull
refactor: Reduce number of LoadChainstate parameters and return values
#25308
ryanofsky on June 8, 2022 Refactoring
ryanofsky on June 8, 2022 Refactoring
pull
refactor: Add util::Result failure types and ability to merge result values
#25665
ryanofsky on July 21, 2022 Refactoring
ryanofsky on July 21, 2022 Refactoring
pull
refactor: Use util::Result class for wallet loading
#25722
ryanofsky on July 27, 2022 Refactoring
ryanofsky on July 27, 2022 Refactoring
pull
refactor, kernel: Remove gArgs accesses from dbwrapper and txdb
#25862
ryanofsky on August 17, 2022 Refactoring
ryanofsky on August 17, 2022 Refactoring
pull
refactor: Move ChainstateManager options into m_options struct
#25905
ryanofsky on August 22, 2022 Refactoring
ryanofsky on August 22, 2022 Refactoring
pull
refactor: Replace `std::optional<bilingual_str>` with `util::Result`
#25977
ryanofsky on September 1, 2022 Refactoring
ryanofsky on September 1, 2022 Refactoring
pull
index: Improve BaseIndex::BlockUntilSyncedToCurrentChain reliability
#26215
ryanofsky on September 30, 2022 UTXO Db and Indexes
ryanofsky on September 30, 2022 UTXO Db and Indexes
pull
refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a
#26298
ryanofsky on October 12, 2022 Refactoring
ryanofsky on October 12, 2022 Refactoring
pull
test: Don't pass add_to_wallet option to walletcreatefundedpsbt
#26483
ryanofsky on November 10, 2022 Tests
ryanofsky on November 10, 2022 Tests
pull
RPC: Accept options as named-only parameters
#26485
ryanofsky on November 10, 2022 RPC/REST/ZMQCI failed
ryanofsky on November 10, 2022 RPC/REST/ZMQCI failed
pull
RPC: Reject RPC requests with same named parameter specified multiple times
#26628
ryanofsky on December 3, 2022 RPC/REST/ZMQ
ryanofsky on December 3, 2022 RPC/REST/ZMQ
pull
refactor: Stop using gArgs global in system.cpp
#27170
ryanofsky on February 27, 2023 Refactoring
ryanofsky on February 27, 2023 Refactoring
pull
streams: Drop confusing DataStream::Serialize method and << operator
#27800
ryanofsky on June 1, 2023
ryanofsky on June 1, 2023
pull
validation: Stricter assumeutxo error handling when renaming chainstates
#27862
ryanofsky on June 12, 2023 Validation
ryanofsky on June 12, 2023 Validation
pull
kernel: Remove StartShutdown calls from validation code
#28048
ryanofsky on July 7, 2023 Validation
ryanofsky on July 7, 2023 Validation
pull
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
#28051
ryanofsky on July 7, 2023
ryanofsky on July 7, 2023
pull
refactor: Make IsInitialBlockDownload & NotifyHeaderTip not require a Chainstate
#28218
ryanofsky on August 4, 2023 Refactoring
ryanofsky on August 4, 2023 Refactoring
pull
wallet: Add TxStateString function for debugging and logging
#28544
ryanofsky on September 27, 2023 Wallet
ryanofsky on September 27, 2023 Wallet
pull
wallet: prevent bugs from invalid transaction heights with asserts, comments, and refactoring
#28546
ryanofsky on September 27, 2023 Wallet
ryanofsky on September 27, 2023 Wallet
pull
github actions: Fix test-one-commit when parent of head is merge commit
#28573
ryanofsky on October 3, 2023
ryanofsky on October 3, 2023
pull
assumeutxo: change getchainstates RPC to return a list of chainstates
#28590
ryanofsky on October 4, 2023
ryanofsky on October 4, 2023
pull
depends: bump libmultiprocess to fix capnproto deprecation warnings
#28907
ryanofsky on November 17, 2023 Build system
ryanofsky on November 17, 2023 Build system
pull
log, refactor: Allow log macros to accept context arguments
#29256
ryanofsky on January 16, 2024 Utils/log/libsNeeds rebase
ryanofsky on January 16, 2024 Utils/log/libsNeeds rebase
pull
depends: Update libmultiprocess library to fix C++20 macos build error
#29276
ryanofsky on January 18, 2024 Build system
ryanofsky on January 18, 2024 Build system
pull
multiprocess: Add capnp wrapper for Chain interface
#29409
ryanofsky on February 8, 2024 interfaces
ryanofsky on February 8, 2024 interfaces
pull
wallet: Avoid potentially writing incorrect best block locator
#29652
ryanofsky on March 14, 2024 Wallet
ryanofsky on March 14, 2024 Wallet
pull
kernel, refactor: return error status on all fatal errors
#29700
ryanofsky on March 21, 2024 Needs rebase
ryanofsky on March 21, 2024 Needs rebase
pull
kernel, logging: Pass Logger instances to kernel objects
#30342
ryanofsky on June 26, 2024 Needs rebase
ryanofsky on June 26, 2024 Needs rebase
pull
wallet, logging: Replace WalletLogPrintf() with LogInfo()
#30343
ryanofsky on June 26, 2024 WalletNeeds rebase
ryanofsky on June 26, 2024 WalletNeeds rebase
pull
logging: Replace LogError and LogWarning with LogAlert
#30364
ryanofsky on June 30, 2024 Needs rebase
ryanofsky on June 30, 2024 Needs rebase
pull
contrib: fix check-deps.sh to check for weak symbols
#30415
ryanofsky on July 9, 2024 Scripts and tools
ryanofsky on July 9, 2024 Scripts and tools
pull
Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior
#30529
ryanofsky on July 26, 2024
ryanofsky on July 26, 2024
pull
refactor: move util/pcp and util/netif to common/
#31011
ryanofsky on October 1, 2024 Refactoring
ryanofsky on October 1, 2024 Refactoring
pull
refactor: Clean up messy strformat and bilingual_str usages
#31072
ryanofsky on October 11, 2024 Refactoring
ryanofsky on October 11, 2024 Refactoring
pull
util: Check bilingual_str format strings at compile time
#31074
ryanofsky on October 11, 2024 Utils/log/libs
ryanofsky on October 11, 2024 Utils/log/libs
pull
tinyformat: Add compile-time checking for literal format strings
#31174
ryanofsky on October 28, 2024 Utils/log/libs
ryanofsky on October 28, 2024 Utils/log/libs
pull
scripted-diff: Type-safe settings retrieval
#31260
ryanofsky on November 8, 2024 RefactoringNeeds rebase
ryanofsky on November 8, 2024 RefactoringNeeds rebase
pull
wallet: Translate [default wallet] string in progress messages
#31296
ryanofsky on November 15, 2024 Wallet
ryanofsky on November 15, 2024 Wallet
pull
cmake: Install internal binaries to <prefix>/libexec/
#31679
ryanofsky on January 17, 2025 Build system
ryanofsky on January 17, 2025 Build system
pull
depends: Update libmultiprocess library before converting to subtree
#31740
ryanofsky on January 27, 2025 Build system
ryanofsky on January 27, 2025 Build system
pull
multiprocess: Lock CapnpProtocol::m_loop with mutex
#31815
ryanofsky on February 7, 2025 interfaces
ryanofsky on February 7, 2025 interfaces
pull
test, refactor: Add TestNode.binaries to hold binary paths
#31866
ryanofsky on February 14, 2025
ryanofsky on February 14, 2025
pull
depends: Update libmultiprocess library to fix CI failures
#31945
ryanofsky on February 24, 2025 Build system
ryanofsky on February 24, 2025 Build system
pull
cmake: Avoid fuzzer "multiple definition of `main'" errors
#31992
ryanofsky on March 4, 2025 Build system
ryanofsky on March 4, 2025 Build system
pull
doc: Document WITH_EXTERNAL_LIBMULTIPROCESS build option better
#32271
ryanofsky on April 14, 2025 Docs
ryanofsky on April 14, 2025 Docs
pull
multiprocess: Don't require bitcoin -m argument when IPC options are used
#33229
ryanofsky on August 20, 2025 interfaces
ryanofsky on August 20, 2025 interfaces
pull
clang-tidy: disable clang-analyzer UndefinedBinaryOperatorResult warning
#33281
ryanofsky on September 2, 2025
ryanofsky on September 2, 2025
pull
test: Prevent disk space warning during node_init_tests
#33391
ryanofsky on September 15, 2025 Tests
ryanofsky on September 15, 2025 Tests
pull
Update libmultiprocess subtree to fix intermittent mptest hang
#33412
ryanofsky on September 17, 2025
ryanofsky on September 17, 2025
pull
ipc, test: Add tests for unclean disconnect and thread busy behavior
#34284
ryanofsky on January 14, 2026 CI failed
ryanofsky on January 14, 2026 CI failed
pull
Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout
#34363
ryanofsky on January 21, 2026
ryanofsky on January 21, 2026
pull
Update libmultiprocess subtree to be more stable with rust IPC client
#34422
ryanofsky on January 27, 2026
ryanofsky on January 27, 2026
pull
refactor: separate log generation from log handling
#34465
ryanofsky on January 30, 2026 Refactoring
ryanofsky on January 30, 2026 Refactoring
pull
mining: Break compatibility with existing IPC mining clients
#34568
ryanofsky on February 12, 2026 Mining
ryanofsky on February 12, 2026 Mining
pull
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
#34661
ryanofsky on February 24, 2026
ryanofsky on February 24, 2026
pull
test: avoid interface_ipc.py race and null pointer dereference
#34715
ryanofsky on March 2, 2026 Tests
ryanofsky on March 2, 2026 Tests
pull
logging: rewrite macros to add ratelimit option, avoid unused strprintf, clarify confusing errors
#34778
ryanofsky on March 9, 2026 Needs rebase
ryanofsky on March 9, 2026 Needs rebase
pull
Update libmultiprocess subtree to fix race conditions on disconnects
#34804
ryanofsky on March 11, 2026
ryanofsky on March 11, 2026
pull
Update libmultiprocess subtree in 31.x branch to fix race conditions on disconnects
#34952
ryanofsky on March 30, 2026 Backport
ryanofsky on March 30, 2026 Backport
pull
bitcoin-cli: note -rpcclienttimeout is not implemented for IPC connections
#35015
ryanofsky on April 6, 2026 Needs rebase
ryanofsky on April 6, 2026 Needs rebase
pull
depends: fix cmake package discovery for depends-built packages
#35068
ryanofsky on April 13, 2026 Build system
ryanofsky on April 13, 2026 Build system
pull
Fixes for p2p-compactblocks.py test timeouts on travis (#8842)
#9058
ryanofsky on November 1, 2016 P2P
ryanofsky on November 1, 2016 P2P
pull
Use importmulti timestamp when importing watch only keys (on top of #9682)
#9108
ryanofsky on November 8, 2016 WalletRPC/REST/ZMQ
ryanofsky on November 8, 2016 WalletRPC/REST/ZMQ
pull
WIP: Allow wallet key import RPCs to track TxOut amounts on -prune nodes (on top of #9306)
#9137
ryanofsky on November 11, 2016 Wallet
ryanofsky on November 11, 2016 Wallet
pull
Change sync_blocks to pick smarter maxheight (on top of #9196)
#9139
ryanofsky on November 11, 2016 Tests
ryanofsky on November 11, 2016 Tests
pull
[qa] Wait for specific block announcement in p2p-compactblocks
#9159
ryanofsky on November 14, 2016 Tests
ryanofsky on November 14, 2016 Tests
pull
Send tip change notification from invalidateblock
#9196
ryanofsky on November 21, 2016 Validation
ryanofsky on November 21, 2016 Validation
pull
Make CCoinsViewCache::Cursor() return latest data
#9306
ryanofsky on December 9, 2016 UTXO Db and Indexes
ryanofsky on December 9, 2016 UTXO Db and Indexes
pull
Assert FRESH validity in CCoinsViewCache::BatchWrite
#9310
ryanofsky on December 9, 2016 UTXO Db and Indexes
ryanofsky on December 9, 2016 UTXO Db and Indexes
pull
[qa] Add test for rescan feature of wallet key import RPCs
#9331
ryanofsky on December 12, 2016 Tests
ryanofsky on December 12, 2016 Tests
pull
Let wallet importmulti RPC accept labels for standard scriptPubKeys
#9332
ryanofsky on December 12, 2016 RPC/REST/ZMQ
ryanofsky on December 12, 2016 RPC/REST/ZMQ
pull
Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry.
#9333
ryanofsky on December 12, 2016 RefactoringWallet
ryanofsky on December 12, 2016 RefactoringWallet
pull
Add test for CWalletTx::GetImmatureCredit() returning stale values.
#9359
ryanofsky on December 16, 2016 WalletTests
ryanofsky on December 16, 2016 WalletTests
pull
Factor out CWallet::nTimeSmart computation into a method.
#9369
ryanofsky on December 16, 2016 Wallet
ryanofsky on December 16, 2016 Wallet
pull
[trivial] Add documentation for CWalletTx::fFromMe member.
#9378
ryanofsky on December 19, 2016 DocsWallet
ryanofsky on December 19, 2016 DocsWallet
pull
Remove CWalletTx merging logic from AddToWallet
#9381
ryanofsky on December 19, 2016 RefactoringWallet
ryanofsky on December 19, 2016 RefactoringWallet
pull
CCoinsViewCache code cleanup & deduplication
#9384
ryanofsky on December 20, 2016 RefactoringUTXO Db and IndexesNeeds rebase
ryanofsky on December 20, 2016 RefactoringUTXO Db and IndexesNeeds rebase
pull
Return height of last block pruned by pruneblockchain RPC
#9518
ryanofsky on January 11, 2017 RPC/REST/ZMQ
ryanofsky on January 11, 2017 RPC/REST/ZMQ
pull
Enable RBF transactions in wallet by default
#9527
ryanofsky on January 12, 2017 WalletTX fees and policy
ryanofsky on January 12, 2017 WalletTX fees and policy
pull
[Qt] Add checkbox in the GUI to opt-in to RBF when creating a transaction
#9592
ryanofsky on January 19, 2017 GUIWallet
ryanofsky on January 19, 2017 GUIWallet
pull
[wallet] Clarify getbalance help string to explain interaction with bumpfee
#9613
ryanofsky on January 23, 2017 WalletRPC/REST/ZMQ
ryanofsky on January 23, 2017 WalletRPC/REST/ZMQ
pull
[wallet] [refactor] Simplify getbalance implementation
#9614
ryanofsky on January 23, 2017 RefactoringWallet
ryanofsky on January 23, 2017 RefactoringWallet
pull
Set correct metadata on bumpfee wallet transactions
#9673
ryanofsky on February 2, 2017 WalletRPC/REST/ZMQ
ryanofsky on February 2, 2017 WalletRPC/REST/ZMQ
pull
Add static_assert to prevent VARINT(<signed value>)
#9753
ryanofsky on February 13, 2017 Refactoring
ryanofsky on February 13, 2017 Refactoring
pull
Return error when importmulti called with invalid address.
#9756
ryanofsky on February 13, 2017 WalletRPC/REST/ZMQ
ryanofsky on February 13, 2017 WalletRPC/REST/ZMQ
pull
[wallet] Remove importmulti always-true check
#9760
ryanofsky on February 14, 2017 WalletRPC/REST/ZMQ
ryanofsky on February 14, 2017 WalletRPC/REST/ZMQ
pull
Use 2 hour grace period for key timestamps in importmulti rescans
#9761
ryanofsky on February 14, 2017 WalletRPC/REST/ZMQ
ryanofsky on February 14, 2017 WalletRPC/REST/ZMQ
pull
Add missing cs_wallet lock that triggers new lock held assertion
#9771
ryanofsky on February 15, 2017 Wallet
ryanofsky on February 15, 2017 Wallet
pull
Return errors from importmulti if complete rescans are not successful
#9773
ryanofsky on February 15, 2017 WalletRPC/REST/ZMQ
ryanofsky on February 15, 2017 WalletRPC/REST/ZMQ
pull
Save watch only key timestamps when reimporting keys
#9818
ryanofsky on February 21, 2017 Wallet
ryanofsky on February 21, 2017 Wallet
pull
Fix pruning test broken by 2 hour manual prune window
#9820
ryanofsky on February 21, 2017 Tests
ryanofsky on February 21, 2017 Tests
pull
Fix importmulti returning rescan errors for wrong keys
#9829
ryanofsky on February 22, 2017 BugWallet
ryanofsky on February 22, 2017 BugWallet
Issues
issue
Travis x86_64-apple-darwin11 errors: "Configuring boost... /bin/sh: 1: requires: not found"
#11906
ryanofsky on December 15, 2017 macOS
ryanofsky on December 15, 2017 macOS
issue
"Travis early exit to cache current state" message unclear
#15738
ryanofsky on April 3, 2019 Tests
ryanofsky on April 3, 2019 Tests
issue
wallet: #17261 regression: addmultisigaddress addresses not treated as solvable
#18075
ryanofsky on February 5, 2020 BugWallet
ryanofsky on February 5, 2020 BugWallet
issue
gui: segfault unloading and immediately reloading wallet with gui
#18362
ryanofsky on March 16, 2020 BugGUI
ryanofsky on March 16, 2020 BugGUI
issue
depends: should linux host should be using -sysroot?
#18915
ryanofsky on May 8, 2020 BugBuild system
ryanofsky on May 8, 2020 BugBuild system
issue
Small memory leak when BerkeleyEnvironment::Open fails
#19034
ryanofsky on May 20, 2020 BugWallet
ryanofsky on May 20, 2020 BugWallet
issue
travis arm64 errors: sudo: unable to resolve host travis-job-bitcoin-bitcoin-694885469
#19171
ryanofsky on June 5, 2020 BugTests
ryanofsky on June 5, 2020 BugTests
issue
Cirrus CI hangs following "Agent process on a persistent worker exited unexpectedly!"
#21673
ryanofsky on April 14, 2021 Bug
ryanofsky on April 14, 2021 Bug
issue
Bug: ArgsManager::ReadSettingsFile can return false even when it does load settings
#22638
ryanofsky on August 5, 2021 Bug
ryanofsky on August 5, 2021 Bug
issue
RFC: Replacing ArgsManager enum with enum class
#22977
ryanofsky on September 15, 2021 Brainstorming
ryanofsky on September 15, 2021 Brainstorming
issue
RFC: ArgsManager type and range checking
#22978
ryanofsky on September 15, 2021 Needs Conceptual Reviewinterfaces
ryanofsky on September 15, 2021 Needs Conceptual Reviewinterfaces
issue
RFC: Add multiprocess fuzz target
#23015
ryanofsky on September 17, 2021 BrainstormingTestsinterfacesFuzzing
ryanofsky on September 17, 2021 BrainstormingTestsinterfacesFuzzing
issue
test_bitcoin-qt error: "Unable to init server: Could not connect: Connection refused"
#23160
ryanofsky on October 2, 2021 BugGUI
ryanofsky on October 2, 2021 BugGUI
issue
Win64 CI failure: `wine: chdir to /tmp/wine-tOJTCJ/server-1000a1-778801 : No such file or directory`
#23357
ryanofsky on October 25, 2021 BugWindowsTestsUpstream
ryanofsky on October 25, 2021 BugWindowsTestsUpstream
issue
CI failure: `ThreadSanitizer: data race /usr/lib/llvm-12/bin/../include/c++/v1/ios:523:12 in std::__1::ios_base::width() const`
#23366
ryanofsky on October 27, 2021 BugTests
ryanofsky on October 27, 2021 BugTests
issue
Cirrus CI / Win64 doesn't print assert errors from test_bitcoin.exe
#24261
ryanofsky on February 4, 2022 Bug
ryanofsky on February 4, 2022 Bug
issue
depends bdb -Werror=format-security "format not a string literal and no format arguments"
#25211
ryanofsky on May 25, 2022 BugBuild system
ryanofsky on May 25, 2022 BugBuild system
issue
wallet_create_tx.py "Not solvable pre-selected input" exception
#27316
ryanofsky on March 23, 2023 WalletTests
ryanofsky on March 23, 2023 WalletTests
issue
CI failure "buster-backports InRelease: The following signatures couldn't be verified because the public key is not available"
#27531
ryanofsky on April 26, 2023
ryanofsky on April 26, 2023
issue
RFC: "Insufficient review" tag for closed PRs
#29839
ryanofsky on April 9, 2024 BrainstormingInsufficient Review
ryanofsky on April 9, 2024 BrainstormingInsufficient Review
issue
RFC: Assumeutxo and large forks and reorgs
#30288
ryanofsky on June 14, 2024 BrainstormingValidation
ryanofsky on June 14, 2024 BrainstormingValidation
issue
cmake: passing options from depends build to main build
#30813
ryanofsky on September 4, 2024 BrainstormingBuild system
ryanofsky on September 4, 2024 BrainstormingBuild system
issue
RFC: Adding bitcoin-{node,gui} binaries for IPC in 30.0 release
#31756
ryanofsky on January 29, 2025 Brainstorming
ryanofsky on January 29, 2025 Brainstorming
issue
RFC: Cancelling waitNext calls in the IPC mining interface
#33575
ryanofsky on October 8, 2025
ryanofsky on October 8, 2025
issue
Memory leak when using IPC mining interface
#33940
ryanofsky on November 24, 2025 BugResource usageinterfaces
ryanofsky on November 24, 2025 BugResource usageinterfaces