[test] Add tests for getconnectioncount, getnettotals and ping #10264

  36 | +        self._test_getnettotals()
  37 | +        self._test_getnetworkinginfo()
  38 | +        self._test_getaddednodeinfo()
  39 | +
  40 | +    def _test_connection_count(self):
  41 | +        assert_equal(self.nodes[0].getconnectioncount(), self.num_nodes)

jnewbery commented at 9:06 PM on April 28, 2017:

nit: I wouldn't assert these two things are equal. Number of nodes is 2, and the test framework sets up two connections between each node (see connect_nodes_bi()). The fact that these are the same number is a coincidence.

Just assert_equal(self.nodes[0].getconnectioncount(), 2) is better, with a comment explaining why.

  42 | +
  43 | +    def _test_getnettotals(self):
  44 | +        # check that getnettotals totalbytesrecv and totalbytessent
  45 | +        # are consistent with getpeerinfo
  46 | +        peer_info = self.nodes[0].getpeerinfo()
  47 | +        assert_equal(len(peer_info), self.num_nodes)

jnewbery commented at 9:07 PM on April 28, 2017:

again, this should just assert equality to 2

  57 | +        time.sleep(0.1)
  58 | +        peer_info_after_ping = self.nodes[0].getpeerinfo()
  59 | +        net_totals_after_ping = self.nodes[0].getnettotals()
  60 | +        for before, after in zip(peer_info, peer_info_after_ping):
  61 | +            assert_equal(before['bytesrecv_per_msg']['pong'] + 32,
  62 | +                         after['bytesrecv_per_msg']['pong'])

jnewbery commented at 9:12 PM on April 28, 2017:

micro-nit: I think because of indentation these are clearer if you don't wrap them over two lines. That's just my personal preference though.

  46 | +        # are consistent with getpeerinfo
  47 | +        peer_info = self.nodes[0].getpeerinfo()
  48 | +        assert_equal(len(peer_info), 2)
  49 | +        net_totals = self.nodes[0].getnettotals()
  50 | +        assert_equal(sum([peer['bytesrecv'] for peer in peer_info]),
  51 | +                     net_totals['totalbytesrecv'])

MarcoFalke commented at 10:14 AM on May 1, 2017:

nit: personally I'd prefer if it was on a single line, such that it shows up as a whole in case of a print traceback.