the default constructor was executing memset(0) twice, first in uint256 default constructor and later in the call to SetNull.
Improved efficiency in constructors of COutPoint #10277
pull mm-s wants to merge 0 commits into bitcoin:master from mm-s:master changing 0 files +0 −0-
mm-s commented at 2:18 PM on April 25, 2017: contributor
- laanwj added the label Resource usage on Apr 25, 2017
-
jonasschnelli commented at 7:32 PM on April 25, 2017: contributor
Looks good to me. But is there a reason to move the implementation away from the header?
-
sipa commented at 11:22 PM on April 25, 2017: member
Agree with @jonasschnelli. I expect that removing the ability to inline the constructor will have a worse effect than the double memset had.
-
mm-s commented at 7:13 AM on April 26, 2017: contributor
I had no strong reason to move the impl, I moved it back to the header..
-
laanwj commented at 10:19 AM on April 26, 2017: member
utACK after squash
-
mm-s commented at 12:14 PM on April 27, 2017: contributor
squashed, any further action required from my side?, thanks
-
-
MarcoFalke commented at 12:41 PM on April 27, 2017: member
Still needs a rebase, maybe try this?:
git fetch bitcoin git merge bitcoin master git reset --soft bitcoin/master git commit -m ' Improved efficiency in constructors of COutPoint' git push origin master -f
On Thu, Apr 27, 2017 at 2:14 PM, Marcos Mayorga notifications@github.com wrote:
any action required from my side?, thanks
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
-
mm-s commented at 1:26 PM on April 27, 2017: contributor
I don't know how to remove merge commit 89b5b8d without getting errors when pushing (the tip of your current branch is behind) help on how to do it is welcome,... cannot it be merged in the current state?
- mm-s closed this on Apr 28, 2017
- mm-s force-pushed on Apr 28, 2017
- MarcoFalke locked this on Sep 8, 2021
