[Makefile] Alphabetically Reorder addrdb.cpp #10302

pull spencerlievens wants to merge 1 commits into bitcoin:master from spencerlievens:patch-2 changing 1 files +1 −1
  1. spencerlievens commented at 11:25 am on April 30, 2017: contributor
    To keep conformity.
  2. [Makefile] Alphabetically Reorder addrdb.cpp
    To keep conformity.
    56f09df9d8
  3. jonasschnelli commented at 11:37 am on April 30, 2017: contributor
    sigh utACK 56f09df9d81ce635323f5eefc28f328284004203
  4. TheBlueMatt commented at 4:55 pm on April 30, 2017: member

    sigh

    ACK

  5. kallewoof commented at 6:43 am on May 1, 2017: member
    utACK 56f09df9d81ce635323f5eefc28f328284004203
  6. laanwj commented at 7:11 am on May 1, 2017: member

    Meh.

    To keep conformity.

    Conformity to what? Is alphabetic sorting of compilation units documented in doc/developer-notes.md, or any other document?

  7. kallewoof commented at 7:16 am on May 1, 2017: member
    Local conformity? (All the other files in the list are in alphabetic order.)
  8. spencerlievens commented at 8:14 am on May 3, 2017: contributor
    @laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).
  9. jonasschnelli commented at 8:17 am on May 3, 2017: contributor

    @laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).

    Such pull requests improve almost nothing while they distract the development process of other important features and stealing time from reviewers and maintainers.

    If you want to help, please improve something that has a positive net-outcome.

  10. laanwj commented at 9:36 am on May 3, 2017: member

    @laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).

    Ok, fair enough, going to merge this one, but - as @jonasschnelli already says - please don’t make a habit of it. Usually it’s best to do these kind of changes when you’re already adding/removing files in the first place.

  11. laanwj merged this on May 3, 2017
  12. laanwj closed this on May 3, 2017

  13. laanwj referenced this in commit 0912620888 on May 3, 2017
  14. PastaPastaPasta referenced this in commit ec2ba1cd66 on Jun 10, 2019
  15. PastaPastaPasta referenced this in commit e7b85a222f on Jun 10, 2019
  16. PastaPastaPasta referenced this in commit 39ffbed4cf on Jun 10, 2019
  17. PastaPastaPasta referenced this in commit b6c8e18f87 on Jun 11, 2019
  18. PastaPastaPasta referenced this in commit fcc8404d8e on Jun 11, 2019
  19. PastaPastaPasta referenced this in commit 706b2cce62 on Jun 15, 2019
  20. PastaPastaPasta referenced this in commit dd208035a6 on Jun 19, 2019
  21. PastaPastaPasta referenced this in commit 3945612d98 on Jun 19, 2019
  22. PastaPastaPasta referenced this in commit e63189a66b on Jun 19, 2019
  23. PastaPastaPasta referenced this in commit ace067adc6 on Jun 19, 2019
  24. PastaPastaPasta referenced this in commit 38b63db0fb on Jun 19, 2019
  25. PastaPastaPasta referenced this in commit d4e6ab341b on Jun 19, 2019
  26. PastaPastaPasta referenced this in commit f7f8d4090f on Jun 19, 2019
  27. PastaPastaPasta referenced this in commit 79085948fa on Jun 20, 2019
  28. barrystyle referenced this in commit 581a4290ae on Jan 22, 2020
  29. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 04:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me