This patch fixes building Bitcoin Core on apt based systems. It also now prefers Qt5, since it is the first one that is looked for by the configure script.
The comments in contrib/debian/gbp.conf are there for reference, and a hint for any distro maintainer that might need it.
Ugh, sorry havent updated that dir in a while, the contents you should probably be using are the ones from launchpad.net/~bitcoin/+archive/bitcoin Note that we cant switch to Qt5 becacuse of #9038
Ah, I wasn't aware of that Ubuntu thing. Why don't you merge your diffs here then instead of this patch?
I'm supposed to, but I never remember to :p
This patch fixes building Bitcoin Core on apt based systems. It also now prefers Qt5, since it is the first one that is looked for by the configure script.
NOte that Ubuntu there's a problem with qt5 [#8263] . This doesn't have to hold for debian though as that doesn't use the Unity environment.
In my opinion, any distro-specific bugs are still downstream and should be managed there.
I believe Qt5 has had issues on other systems as well, I believe. Is there any harm in just using Qt4 for now? We're gonna have to support it either way.
In any case, see #10328.
(and, more importantly, the PPA is the only user of contrib/debian as far as I'm aware. The Debian maintainers of the bitcoin packages there preferred to not use this over maintaing their own debian dir).
I believe Qt5 has had issues on other systems as well, I believe. Is there any harm in just using Qt4 for now? We're gonna have to support it either way.
I guess we have no automated builds / CI that compile with qt4. AFAIK non (or very fee) developers build against Qt4.
There is no harm in using Qt4. But I guess non of us actively maintains qt4 compatibility. maybe @luke-jr ?
Closing in favor of https://github.com/bitcoin/bitcoin/pull/10328