[wallet] Remove helper conversion operator from wallet #10368

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:wallet-refactor-remove-ctrans-helper changing 11 files +22 −26

kallewoof commented at 6:51 AM on May 9, 2017: member

The CTransaction&() operator in CMerkleTx makes conversion into CTransactions transparent, but was marked as to-be-removed in favor of explicitly getting the tx ivar, presumably as the operator can lead to ambiguous behavior and makes the code harder to follow.

This PR removes the operator and adapts callers. This includes some cases of static_cast<CTransaction>(wtx) → *wtx.tx, which is definitely an improvement.
[wallet] Remove CTransaction&() helper conversion operator from wallet implementation. 5a5e4e9cc1
practicalswift commented at 8:12 AM on May 9, 2017: contributor

concept ACK
fanquake added the label Wallet on May 9, 2017
laanwj commented at 5:23 PM on May 11, 2017: member

utACK 5a5e4e9
jonasschnelli commented at 7:36 PM on August 15, 2017: contributor

utACK 5a5e4e9cc19e30186ba0a15a1cf892516d419baf
laanwj merged this on Nov 9, 2017
laanwj closed this on Nov 9, 2017
laanwj referenced this in commit 77ba4bf960 on Nov 9, 2017
laanwj commented at 1:24 PM on November 9, 2017: member

This is an obvious TODO that was implemented, I think this was held up because we wanted to limit impact to the wallet code to be able to ease back-porting for 0.15.x segwit wallet release. But I think we just just push that for 0.16.0.
laanwj referenced this in commit 045a809234 on Nov 9, 2017
kallewoof deleted the branch on Oct 17, 2019
PastaPastaPasta referenced this in commit 64803a6858 on Dec 22, 2019
PastaPastaPasta referenced this in commit c2aeb98778 on Dec 22, 2019
PastaPastaPasta referenced this in commit 964069f860 on Jan 2, 2020
PastaPastaPasta referenced this in commit 18338c84b4 on Jan 4, 2020
PastaPastaPasta referenced this in commit 2e4e2c629f on Jan 12, 2020
PastaPastaPasta referenced this in commit f61aa72b3a on Jan 12, 2020
PastaPastaPasta referenced this in commit 637c9a7a14 on Jan 12, 2020
PastaPastaPasta referenced this in commit 03e4213049 on Jan 12, 2020
PastaPastaPasta referenced this in commit e1ca5976f7 on Jan 12, 2020
PastaPastaPasta referenced this in commit 0b2279aada on Jan 12, 2020
PastaPastaPasta referenced this in commit b14eee63fa on Jan 16, 2020
PastaPastaPasta referenced this in commit 354f57a838 on Jan 22, 2020
PastaPastaPasta referenced this in commit 8609237b9d on Jan 29, 2020
PastaPastaPasta referenced this in commit a38b5f3b3f on Jan 29, 2020
ckti referenced this in commit 3e54a645b8 on Mar 28, 2021
gades referenced this in commit c81143a2d2 on Jul 1, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#11644 Fix qt build broken by 5a5e4e9