A peer that runs in prune mode does by default signal NODE_BLOOM. BIP37 can't be supported in autoprune-mode (it partially could but would be unreliable).
Make sure we disable NODE_BLOOM when pruning is enabled #10384
pull jonasschnelli wants to merge 2 commits into bitcoin:master from jonasschnelli:2017/05/prune_bloom changing 3 files +40 −1-
jonasschnelli commented at 8:11 PM on May 10, 2017: contributor
-
Make sure we disable NODE_BLOOM when pruning is enabled 984849bddc
-
[QA] add service flags test (in conjunction with prune) b9b3a7577a
- jonasschnelli added the label P2P on May 10, 2017
- jonasschnelli added the label Needs backport on May 10, 2017
-
TheBlueMatt commented at 8:14 PM on May 10, 2017: member
A node which wishes to download historical blocks in filtered mode should be looking for NODE_NETWORK | NODE_BLOOM, which we signal correctly. NODE_BLOOM only imples a willingness to serve filtered blocks, not historical blocks, though maybe the BIP should be clarified?
-
jonasschnelli commented at 8:22 PM on May 10, 2017: contributor
Yes. I was misinterpreting NODE_BLOOM. @TheBlueMatt is correct. NODE_BLOOM is independent from NODE_NETWORK and someone may want to filter the mempool or some recent blocks. Closing.
- jonasschnelli closed this on May 10, 2017
- laanwj removed the label Needs backport on Sep 5, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels