Add Qt tests for wallet spends & bumpfee #10420

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/btest changing 2 files +76 −13
  1. ryanofsky commented at 2:29 PM on May 18, 2017: member

    A few code changes were needed to accompany the test:

    • Adding setObjectName() calls for a few Qt controls to make them easily accessible from the test.

    • Calling contextMenu->popup() instead of contextMenu->exec() to open the transaction list context menu without blocking the test thread.

    • Opening the context menu at the contextualMenu event point rather than the cursor position (this change was not strictly needed to make the test work, but is more correct).

    • Updating the bumped transaction row with showTransaction=true instead of false. This is needed to prevent the bumped tx from being hidden, so the last part of the test which attempts to bump the bumped tx can work. (Technically this change is a more general bugfix not limited to the testing environment, but the bug doesn't happen outside of the testing environment because in the full Qt client, a queued NotifyTransactionChanged notification causes the row to be updated twice, first with showTransaction=false, then immediately after with showTransaction=true.)

  2. fanquake added the label GUI on May 18, 2017
  3. fanquake added the label Tests on May 18, 2017
  4. fanquake added the label Wallet on May 18, 2017
  5. laanwj commented at 1:58 PM on May 22, 2017: member

    utACK - thanks!

  6. Add Qt tests for wallet spends & bumpfee
    A few code changes were needed to accompany the test:
    
    * Adding setObjectName() calls for a few Qt controls to make them easily
      accessible from the test.
    
    * Calling contextMenu->popup() instead of contextMenu->exec() to open
      the transaction list context menu without blocking the test thread.
    
    * Opening the context menu at the contextualMenu event point rather than
      the cursor position (this change was not strictly needed to make the test
      work, but is more correct).
    
    * Updating the bumped transaction row with showTransaction=true instead of
      false. This is needed to prevent the bumped tx from being hidden, so the last
      part of the test which attempts to bump the bumped tx can work. (Technically
      this change is a more general bugfix not limited to the testing environment,
      but the bug doesn't happen outside of the testing environment because in the
      full Qt client, a queued NotifyTransactionChanged notification causes the row
      to be updated twice, first with showTransaction=false, then immediately after
      with showTransaction=true.)
    5749a48821
  7. ryanofsky force-pushed on May 23, 2017
  8. ryanofsky force-pushed on May 23, 2017
  9. jonasschnelli commented at 6:45 AM on May 24, 2017: contributor

    Thanks! Tested ACK 5749a48821f6a83d17b4f4626d09d6abdada5135

  10. jonasschnelli merged this on May 24, 2017
  11. jonasschnelli closed this on May 24, 2017

  12. jonasschnelli referenced this in commit 4314544d46 on May 24, 2017
  13. pstratem commented at 2:56 AM on May 25, 2017: contributor

    breaks qt4

  14. ryanofsky referenced this in commit 620444bd59 on May 25, 2017
  15. HashUnlimited referenced this in commit 6028907097 on Mar 3, 2018
  16. PastaPastaPasta referenced this in commit 08344fc1bf on Jan 31, 2020
  17. PastaPastaPasta referenced this in commit e0849209bd on Feb 4, 2020
  18. UdjinM6 referenced this in commit 3a83c3ada0 on Feb 12, 2020
  19. ckti referenced this in commit 60faef1516 on Mar 28, 2021
  20. gades referenced this in commit 0c3abb1577 on Jun 30, 2021
  21. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me