Replace bytes_serialized with bogosize #10426

pull sipa wants to merge 1 commits into bitcoin:master from sipa:bogosize changing 3 files +16 −2
  1. sipa commented at 11:44 PM on May 18, 2017: member

    Current result:

      "bogosize": 3846482678,
  "disk_size": 2272310093,
  2. MarcoFalke added the label Needs release notes on May 18, 2017
  3. MarcoFalke added the label RPC/REST/ZMQ on May 18, 2017
  4. fanquake commented at 12:22 AM on May 19, 2017: member

    Looks like you'll need to update the blockchain RPC test here.

  5. sipa force-pushed on May 19, 2017
  6. sipa commented at 12:37 AM on May 19, 2017: member

    Fixed.

  7. laanwj commented at 2:55 PM on May 19, 2017: member

    Nice, concept ACK

  8. MarcoFalke commented at 2:58 PM on May 19, 2017: member

    Breaking changes need to be mentioned in the release notes. Mind to do it in this pull?

    On Fri, May 19, 2017 at 2:37 AM, Pieter Wuille notifications@github.com wrote:

    Fixed.

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10426#issuecomment-302577802, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv7RAjHs0G7ASE9mF7mNoTAKKXKPDks5r7ORfgaJpZM4Nf66O .

  9. sipa force-pushed on May 19, 2017
  10. sipa commented at 4:36 PM on May 19, 2017: member

    I've rebased this PR on top of #10396, as both touch the same code. A single combined release-notes.md entry was added.

  11. sipa force-pushed on May 30, 2017
  12. sipa commented at 10:21 PM on May 30, 2017: member

    Rebased, and updated the release notes a bit.

  13. sipa force-pushed on Jun 1, 2017
  14. sipa commented at 11:41 PM on June 1, 2017: member

    Rebased on top of #10195.

  15. Replace bytes_serialized with bogosize 8b22af3ee5
  16. in src/rpc/blockchain.cpp:911 in c41ef6dbbd outdated 
     906 | @@ -904,6 +907,7 @@ UniValue gettxoutsetinfo(const JSONRPCRequest& request)
 907 |              "  \"bestblock\": \"hex\",   (string) the best block hash hex\n"
 908 |              "  \"transactions\": n,      (numeric) The number of transactions\n"
 909 |              "  \"txouts\": n,            (numeric) The number of output transactions\n"
 910 | +            "  \"bogosize\": n,          (numeric) A meaningless metric for UTXO set size\n"
 911 |              "  \"hash_serialized\": \"hash\",   (string) The serialized hash\n"
    MarcoFalke commented at 9:59 AM on June 2, 2017:

    Could you suffix the name here with _2 as you are touching the file anyway?

    sipa commented at 7:44 PM on June 5, 2017:

    Done.

  17. sipa force-pushed on Jun 5, 2017
  18. laanwj commented at 9:46 AM on June 6, 2017: member

    tested ACK 8b22af3

  19. laanwj merged this on Jun 6, 2017
  20. laanwj closed this on Jun 6, 2017
  21. laanwj referenced this in commit 16f6c98fa8 on Jun 6, 2017
  22. sipa deleted the branch on Jun 23, 2017
  23. sipa removed the label Needs release notes on Aug 14, 2018
  24. PastaPastaPasta referenced this in commit 68471d1139 on Jun 22, 2019
  25. PastaPastaPasta referenced this in commit 4a2f55d9b8 on Jun 22, 2019
  26. PastaPastaPasta referenced this in commit f6ac636425 on Jun 22, 2019
  27. PastaPastaPasta referenced this in commit 9e3529af22 on Jun 22, 2019
  28. PastaPastaPasta referenced this in commit 94f7401e7e on Jun 22, 2019
  29. PastaPastaPasta referenced this in commit 400b789182 on Jun 22, 2019
  30. PastaPastaPasta referenced this in commit 9768d2e4c5 on Jun 22, 2019
  31. PastaPastaPasta referenced this in commit 666a69bb78 on Jun 22, 2019
  32. PastaPastaPasta referenced this in commit bf549c2d7b on Jun 22, 2019
  33. PastaPastaPasta referenced this in commit 728f331b0d on Jun 22, 2019
  34. PastaPastaPasta referenced this in commit 5a185cd9f0 on Jun 22, 2019
  35. PastaPastaPasta referenced this in commit 175d68ac21 on Jun 26, 2019
  36. barrystyle referenced this in commit 97250b7dc4 on Jan 22, 2020
  37. deadalnix referenced this in commit 3d81fdd40f on Aug 31, 2021
  38. MarcoFalke locked this on Sep 8, 2021
Contributors
sipafanquakelaanwjMarcoFalke
Labels
RPC/REST/ZMQ
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me