Names: BIP9 vs versionbits #10463

pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:b15-bip8-cherry-reanme changing 8 files +23 −24
  1. jtimon commented at 12:53 AM on May 27, 2017: contributor

    Whether bip8 it's adopted or not it seems clear bip9 was flawed in its assumptions, the version bit part was right and will be continued by proposed extensions.

    This should be orthogonal to #10462, but maybe it helps in review before or after and it's better documentation long term.

  2. fanquake added the label Refactoring on May 27, 2017
  3. shaolinfry commented at 4:04 AM on May 27, 2017: contributor

    Can someone restart the two failed jobs, they look like random Travis related fails.

  4. fanquake commented at 4:51 AM on May 27, 2017: member

    Restarted both jobs. For reference the errors were:

    stdout:
2017-05-27 01:32:40.308000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20170527_013135/p2p-compactblocks_160
2017-05-27 01:32:40.564000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in start_nodes
    rpcs.append(start_node(i, dirname, extra_args[i], rpchost, timewait=timewait, binary=binary[i]))
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 242, in start_node
    wait_for_bitcoind_start(bitcoind_processes[i], url, i)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 216, in wait_for_bitcoind_start
    raise Exception('bitcoind exited with status %i during initialization' % process.returncode)
Exception: bitcoind exited with status 1 during initialization
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 146, in main
    self.setup_network()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 81, in setup_network
    self.setup_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 94, in setup_nodes
    self.nodes = start_nodes(self.num_nodes, self.options.tmpdir, extra_args)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 283, in start_nodes
    stop_nodes(rpcs)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 303, in stop_nodes
    assert not bitcoind_processes.values() # All connections must be gone now
AssertionError
2017-05-27 01:32:40.565000 TestFramework (INFO): Stopping nodes
stderr:
************************
EXCEPTION: St12out_of_range       
map::at       
bitcoin in AppInit()       
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-compactblocks.py", line 945, in <module>
    CompactBlocksTest().main()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 162, in main
    self.stop_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 206, in stop_nodes
    stop_nodes(self.nodes)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 301, in stop_nodes
    for i, node in enumerate(nodes):
TypeError: 'NoneType' object is not iterable
.......................................................
p2p-segwit.py failed, Duration: 5 s
stdout:
2017-05-27 01:33:04.891000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20170527_013135/p2p-segwit_156
2017-05-27 01:33:10.047000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in start_nodes
    rpcs.append(start_node(i, dirname, extra_args[i], rpchost, timewait=timewait, binary=binary[i]))
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 242, in start_node
    wait_for_bitcoind_start(bitcoind_processes[i], url, i)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 216, in wait_for_bitcoind_start
    raise Exception('bitcoind exited with status %i during initialization' % process.returncode)
Exception: bitcoind exited with status 1 during initialization
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 146, in main
    self.setup_network()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-segwit.py", line 120, in setup_network
    self.setup_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 94, in setup_nodes
    self.nodes = start_nodes(self.num_nodes, self.options.tmpdir, extra_args)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 283, in start_nodes
    stop_nodes(rpcs)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 303, in stop_nodes
    assert not bitcoind_processes.values() # All connections must be gone now
AssertionError
2017-05-27 01:33:10.048000 TestFramework (INFO): Stopping nodes
stderr:
************************
EXCEPTION: St12out_of_range       
map::at       
bitcoin in AppInit()       
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-segwit.py", line 1952, in <module>
    SegWitTest().main()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 162, in main
    self.stop_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 206, in stop_nodes
    stop_nodes(self.nodes)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 301, in stop_nodes
    for i, node in enumerate(nodes):
TypeError: 'NoneType' object is not iterable
  5. Rename -bip9params to -vbparams 29c07196d0
  6. scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/
    -BEGIN VERIFY SCRIPT-
sed -i 's/BIP9DeploymentInfo/VBDeploymentInfo/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
    b463bc9215
  7. jtimon force-pushed on May 30, 2017
  8. jtimon commented at 5:23 PM on May 30, 2017: contributor

    Sorry, the error was just one s/-bip9params/-vbparams/ lost in rebase, not a problem with travis. Updated.

  9. shaolinfry commented at 6:21 AM on May 31, 2017: contributor

    @fanquake can you rerun Travis - looks like the VM errored and stopped the build process prematurely.

    utACK assuming they pass.

  10. fanquake commented at 8:05 AM on May 31, 2017: member

    @shaolinfry Restarted, looks like they are all passing now.

  11. shaolinfry commented at 2:45 PM on May 31, 2017: contributor

    utACK b463bc9

  12. laanwj commented at 9:35 AM on June 1, 2017: member

    Concept ACK, I think this naming is better because it is more general.

  13. benma commented at 11:32 AM on June 1, 2017: none

    utACK b463bc9

  15. laanwj merged this on Jun 6, 2017
  16. laanwj closed this on Jun 6, 2017
  17. laanwj referenced this in commit 323a46e034 on Jun 6, 2017
  18. jtimon deleted the branch on Jun 14, 2017
  19. PastaPastaPasta referenced this in commit 07d9607829 on Jun 20, 2019
  20. PastaPastaPasta referenced this in commit ad72594075 on Jun 22, 2019
  21. PastaPastaPasta referenced this in commit a33dc58bda on Jun 22, 2019
  22. PastaPastaPasta referenced this in commit ecd11b1a43 on Jun 22, 2019
  23. PastaPastaPasta referenced this in commit 5fd52d46c7 on Jun 22, 2019
  24. PastaPastaPasta referenced this in commit 9aecb85fa3 on Jun 22, 2019
  25. PastaPastaPasta referenced this in commit 7d273e0201 on Jun 22, 2019
  26. PastaPastaPasta referenced this in commit 65819019e7 on Jun 22, 2019
  27. PastaPastaPasta referenced this in commit 220092d3cc on Jun 26, 2019
  28. PastaPastaPasta referenced this in commit 3b36bcbe62 on Jun 26, 2019
  29. PastaPastaPasta referenced this in commit 8178afceaa on Jul 5, 2019
  30. PastaPastaPasta referenced this in commit b2b13660b2 on Jul 5, 2019
  31. PastaPastaPasta referenced this in commit 2ff002ab35 on Jul 6, 2019
  32. PastaPastaPasta referenced this in commit 42985c31bb on Jul 8, 2019
  33. barrystyle referenced this in commit 52f1be21f7 on Jan 22, 2020
  34. DrahtBot locked this on Sep 8, 2021
Contributors
jtimonshaolinfryfanquakelaanwjbenmainstagibbs
Labels
Refactoring
Linked (view graph)
#10462 Consensus: Modified BIP8 implementation
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me