Fix for listsinceblock not filtering conflicted transactions #10470

1. 
   mchrostowski commented at 8:59 pm on May 27, 2017: contributor

   Fix for issue #8752 which, if merged, replaces PR #8757

   I prepped functional/listsinceblock.py for additional tests. Wrote a test for the above issue. Made a fix to rpcwallet.cpp:listsinceblock(…).

   The fix takes advantage of CMerkleTx::GetDepthInMainChain() returning a negative value for conflicted transactions. The negative value represents the depth of the transaction with which it is conflicted. Taking abs(…) of this lets us use the same logic for filtering un-conflicted transactions to filter the conflicted ones.

2. Refactor in preparation for additional tests. 593b66dce6
3. Added test for issue 8752.

   Tests that conflicted transactions are not returned by calls
   to listsinceblock that filter out the confirmed transaction
   with which they are conflicted.

   9389d33338
4. Fixes issue 8752 in listsinceblock RPC.

   listsinceblock now checks that returned transactions are not
   conflicting with any transactions that are filtered out by
   the given blockhash.

   df09c3aaca
5. fanquake added the label RPC/REST/ZMQ on May 28, 2017
6. fanquake added the label Wallet on May 28, 2017
7. 
   RHavar commented at 10:37 pm on June 22, 2017: contributor

   ACK - I can reproduce the problem, and this does fix it =)
8. 
   jonasschnelli commented at 7:34 pm on August 15, 2017: contributor

   utACK df09c3aaca3d261a0679a2fcc04da9ee01fb824a
9. 
   jonasschnelli commented at 7:34 pm on August 15, 2017: contributor

   Needs rebase though now.
10. 
    TheBlueMatt commented at 6:58 pm on September 29, 2017: member

    @mchrostowski any plans to rebase this?
11. fanquake added the label Up for grabs on May 17, 2018
12. fanquake closed this on May 17, 2018

    ---

13. fanquake removed the label Up for grabs on Oct 25, 2019
14. meshcollider referenced this in commit bfc4c896d6 on Nov 5, 2019
15. sidhujag referenced this in commit c06d5017eb on Nov 7, 2019
16. sidhujag referenced this in commit cc82e86c7f on Nov 10, 2020
17. DrahtBot locked this on Dec 16, 2021

Contributors
mchrostowski RHavar jonasschnelli TheBlueMatt

Labels
Wallet RPC/REST/ZMQ