Sorry to resubmit this, I spent some more time testing and messed up my repo. In any case there are no changes from the original. Just gavin's portoption and the removal of the 2h penalty for non-standard port clients.
Portoption #105
pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:portoption changing 2 files +10 −9-
TheBlueMatt commented at 6:43 PM on March 7, 2011: member
-
Apply Gavin's portoption patch. f462d784f7
-
Remove the 2h penalty for clients which don't use the default port. This is unnecessary as outgoing connections are already limited to one IP per /16. dabb425f8b
-
jgarzik commented at 8:25 PM on March 9, 2011: contributor
Given that -port is oft-requested and oft-implemented, and a standard option on other servers, I think we should include that.
However, I am not sure we should be removing penalties until things like ensuring diversity of incoming connections is handled.
-
TheBlueMatt commented at 9:27 PM on March 9, 2011: member
Phantomcircuit started a topic on the forum to discuss Sybil attacks and what, exactly, we should to to prevent them (http://www.bitcoin.org/smf/index.php?topic=4335.0). I would, however, like to point out that the penalties removed here have nothing to do with incoming connections and the penalties here are really unnecessary as the client only makes one outbound connection per /16.
-
TheBlueMatt commented at 6:31 PM on March 10, 2011: member
After the discussion on IRC and a bit of soul searching, I came to the conclusion that having a -port option is bad for the overall network. The problem rests with the ability of people to more easily run multiple nodes on the network. This should be discouraged as it increases load on IRC, etc. Anyone who has enough ability to want an alternate port for whatever reason can easily do this with firewall rules or with a compilation with the above commits.
- rdponticelli referenced this in commit c48cdc4cb3 on Nov 26, 2014
- dexX7 referenced this in commit 92c3e1df82 on Jul 4, 2015
- MarcoFalke referenced this in commit c917587cb0 on Mar 26, 2016
- TheBlueMatt referenced this in commit 83b1931cb5 on Oct 3, 2016
- cryptapus referenced this in commit 9d5fe0d635 on Aug 31, 2018
- lateminer referenced this in commit 6ccfb8499f on Feb 23, 2019
- rajarshimaitra referenced this in commit a77bca8819 on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021