Clarify prevector::erase and avoid swap-to-clear #10534

1. 
   sipa commented at 7:18 pm on June 5, 2017: member
2. 
   laanwj commented at 9:24 am on June 6, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/10534/commits/38a52358f9f145d16f1e4ebab0266740cee86868, thanks for adding the clarifying comment.
3. laanwj added the label Utils and libraries on Jun 6, 2017
4. in src/prevector.h:390 in 38a52358f9 outdated

   386@@ -387,6 +387,12 @@ class prevector {
   387     }
   388 
   389     iterator erase(iterator first, iterator last) {
   390+        // Erase is not allowed the change the object's capacity. That means
   

   ---

   ---

   

   sdaftuar commented at 3:59 pm on June 7, 2017:

   nit: “to” change the object’s capacity.
5. sdaftuar approved
6. 
   sdaftuar commented at 4:01 pm on June 7, 2017: member

   Looks good, thanks for adding. One typo in the comment.
7. 
   TheBlueMatt commented at 5:21 pm on June 7, 2017: member

   utACK 38a52358f9f145d16f1e4ebab0266740cee86868 +/- grammar
8. Clarify prevector::erase and avoid swap-to-clear e241a63c23
9. sipa force-pushed on Jun 9, 2017
10. 
    sipa commented at 8:23 pm on June 9, 2017: member

    Fixed.
11. laanwj merged this on Jun 13, 2017
12. laanwj closed this on Jun 13, 2017

    ---

13. laanwj referenced this in commit a514ac3dcb on Jun 13, 2017
14. sipa deleted the branch on Jun 23, 2017
15. PastaPastaPasta referenced this in commit c7c9ab5452 on Jul 5, 2019
16. PastaPastaPasta referenced this in commit 7065f2fc8a on Jul 5, 2019
17. PastaPastaPasta referenced this in commit 6bb54bd521 on Jul 6, 2019
18. PastaPastaPasta referenced this in commit 98d63201c7 on Jul 8, 2019
19. PastaPastaPasta referenced this in commit 26915a9173 on Jul 9, 2019
20. PastaPastaPasta referenced this in commit c1c24205b7 on Jul 9, 2019
21. barrystyle referenced this in commit c3126c1973 on Jan 22, 2020
22. Fuzzbawls referenced this in commit 8dfc4806f7 on May 19, 2020
23. DrahtBot locked this on Sep 8, 2021

Contributors
sipa laanwj sdaftuar TheBlueMatt

Labels
Utils/log/libs