Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of #10545

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:list_of changing 16 files +108 −124

practicalswift commented at 7:31 PM on June 6, 2017: contributor

Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of.
Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of 3fb81a8480
sipa commented at 7:39 PM on June 6, 2017: member

Concept ACK ACK ACK
MarcoFalke commented at 10:01 PM on June 6, 2017: member

Seems closely related to #10477
practicalswift commented at 10:06 PM on June 6, 2017: contributor

@MarcoFalke Ah, that one seems to tackle a subset of the map_list_of/list_of:s found in one specific file (src/chainparams.cpp). This PR fixes the entire code base.
fanquake added the label Refactoring on Jun 6, 2017
fanquake added this to the "Later" column in a project

fanquake moved this from the "Later" to the "In progress" column in a project

dcousens approved
laanwj commented at 2:11 PM on June 7, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/10545/commits/3fb81a8480582d96e8c87ef1b963a11c55064d57, looks a lot better like this (checked that all values stay the same).
jonasschnelli commented at 6:29 AM on June 8, 2017: contributor

Finally. utACK 3fb81a8480582d96e8c87ef1b963a11c55064d57
paveljanik commented at 10:32 AM on June 8, 2017: contributor

compilesACK 3fb81a8

Looks good!
laanwj merged this on Jun 8, 2017
laanwj closed this on Jun 8, 2017
laanwj referenced this in commit 29f80cd230 on Jun 8, 2017
fanquake moved this from the "In progress" to the "Done" column in a project

Contributors

Labels