Avoid printing generic and duplicated "checking for QT" during ./configure #10549

drizzt commented at 4:54 PM on June 7, 2017: contributor

Print "checking for QT4" and "checking for QT5" instead

Reported by wumpus on irc

laanwj added the label RPC/REST/ZMQ on Jun 7, 2017

laanwj added the label Build system on Jun 7, 2017

laanwj removed the label RPC/REST/ZMQ on Jun 7, 2017

in build-aux/m4/bitcoin_qt.m4:402 in 080e252daf outdated

 398 | @@ -399,17 +399,17 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITH_PKGCONFIG],[
 399 |      qt4_modules="QtCore QtGui QtNetwork"
 400 |      BITCOIN_QT_CHECK([
 401 |        if test x$bitcoin_qt_want_version = xqt5 || ( test x$bitcoin_qt_want_version = xauto && test x$auto_priority_version = xqt5 ); then
 402 | -        PKG_CHECK_MODULES([QT], [$qt5_modules], [QT_INCLUDES="$QT_CFLAGS"; have_qt=yes],[have_qt=no])

laanwj commented at 4:59 PM on June 7, 2017:

Does the first argument here influence anything else besides how it is printed in the logging? https://developer.gnome.org/anjuta-build-tutorial/stable/library-autotools.html.en Seems to imply LIB_CFLAGS and LIB_LDFLAGS get defined based on this parameter.

fanquake commented at 12:47 AM on June 8, 2017: member

OSX and linux builds failed.

  OBJCXX   qt/qt_bitcoin_qt-macdockiconhandler.o
  OBJCXX   qt/qt_bitcoin_qt-macnotificationhandler.o
In file included from qt/macdockiconhandler.mm:5:
./qt/macdockiconhandler.h:8:10: fatal error: 'QMainWindow' file not found
#include <QMainWindow>
         ^
In file included from qt/macnotificationhandler.mm:5:
./qt/macnotificationhandler.h:8:10: fatal error: 'QObject' file not found
#include <QObject>
         ^
1 error generated.
make[1]: *** [qt/qt_bitcoin_qt-macdockiconhandler.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 error generated.
make[1]: *** [qt/qt_bitcoin_qt-macnotificationhandler.o] Error 1
In file included from qt/bitcoin.cpp:9:
./qt/bitcoingui.h:14:10: fatal error: 'QLabel' file not found
#include <QLabel>

Making check in src
make[1]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make[2]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
  CXX      qt/qt_bitcoin_qt-bitcoin.o
  CXX      qt/qt_libbitcoinqt_a-bantablemodel.o
In file included from qt/bitcoin.cpp:9:0:
qt/bitcoingui.h:14:18: fatal error: QLabel: No such file or directory
 #include <QLabel>
                  ^
compilation terminated.
make[2]: *** [qt/qt_bitcoin_qt-bitcoin.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from qt/bantablemodel.cpp:9:0:
qt/guiutil.h:12:23: fatal error: QHeaderView: No such file or directory
 #include <QHeaderView>

jonasschnelli added the label GUI on Jun 8, 2017

Avoid printing generic and duplicated "checking for QT" during ./configure

Print "checking for QT4" and "checking for QT5" instead

7222388bb2

drizzt force-pushed on Jun 8, 2017

paveljanik commented at 10:31 AM on June 8, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/10549/commits/7222388bb24a2da47b0e3d47b67a91d7ab9495da

The build log diff is only:

-checking for QT... yes
+checking for QT5... yes

laanwj commented at 2:46 PM on June 8, 2017: member

Looks good to me now. Ping @theuni

fanquake commented at 6:56 AM on June 10, 2017: member

utACK 7222388

laanwj commented at 2:17 PM on June 12, 2017: member

Tested ACK 7222388

checking for QT5... no
checking for QT4... no
configure: WARNING: Qt dependencies not found; bitcoin-qt frontend will not be built

laanwj merged this on Jun 12, 2017

laanwj closed this on Jun 12, 2017

laanwj referenced this in commit ad1a13e85c on Jun 12, 2017

theuni commented at 7:11 PM on June 13, 2017: member

post-merge utACK.

PastaPastaPasta referenced this in commit c21ae9e5bb on Jul 5, 2019

PastaPastaPasta referenced this in commit a05e39e997 on Jul 5, 2019

PastaPastaPasta referenced this in commit a8b13c5e1b on Jul 6, 2019

PastaPastaPasta referenced this in commit 74b2aba0fe on Jul 8, 2019

PastaPastaPasta referenced this in commit b72a2ae781 on Jul 9, 2019

PastaPastaPasta referenced this in commit e80ca5361c on Jul 9, 2019

barrystyle referenced this in commit 8b3fd3d48a on Jan 22, 2020

DrahtBot locked this on Sep 8, 2021